From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D37C88E72 for ; Mon, 14 Sep 2026 13:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE1296B0096; Mon, 14 Sep 2026 09:52:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A92616B0098; Mon, 14 Sep 2026 09:52:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CDF26B0099; Mon, 14 Sep 2026 09:52:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7BECA6B0096 for ; Mon, 14 Sep 2026 09:52:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0FA6E40113 for ; Mon, 14 Sep 2026 13:52:15 +0000 (UTC) X-FDA: 85212507030.19.5037D12 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 3D4BF16000E for ; Mon, 14 Sep 2026 13:52:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=arm.com header.s=foss header.b=Pfzm5hJ3; spf=pass (imf08.hostedemail.com: domain of usama.anjum@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=usama.anjum@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1789393933; b=EtTNG30Xi4KvsX0uCqUGFc4iemo1H3GnnK/JRAqNYdel9Nhd9ppQ6fA53G5utdX6S0I8Wt 9xteBJ9B4fYpINtL5lc2Px85+ACr7tMnKghuaNicXXRcPc+JfQBblNbHZ42OwISWW2ea/B gpMUsY0a9E1QkVo8dk235Lnc7KoHNwc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=arm.com header.s=foss header.b=Pfzm5hJ3; spf=pass (imf08.hostedemail.com: domain of usama.anjum@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=usama.anjum@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1789393933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5c+7YKxbb37QN6+/DrU0zqhCjEWNxIf9vXbIaiDob8I=; b=Zp4qG38zdLznzJhWV/5E0lx7Dn9V0/AOKfke1+VJT4h0M/xpZdAYFo7O+tLC6M3v8YTTkg UIZUA258MEsSY9q19CoEI4drHFI9U7bnnSHpIwlbWmWhceiAahnAXpkptVSjKEAKrJ9l7g 1pxn6Qy093SrGywEWc7q6skpijrjFa8= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4A051570; Mon, 14 Sep 2026 06:52:08 -0700 (PDT) Received: from [127.0.1.1] (e142334-100.cambridge.arm.com [10.2.198.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2F60A3F882; Mon, 14 Sep 2026 06:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1789393932; bh=a0XPwGbhmPF/8HQB5tl0tfRDc3dHm2jdpy2fD9dIAOw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Pfzm5hJ3feethkE3Lt+/Yi0zFezDiFNBYm62UaeS/yrfFexyWZ5fbgJcnY5dDxP/0 2T9TOcPMJpLUxmKN/g4RlGweBDexJjW+SpVe4eoyBWvQbUpGj2MaSFuD6QqTOaw7RS AGhWCYfmKhKFpjN5exzGFjhmlpyiygeQNVXzo1rM= From: Muhammad Usama Anjum Date: Mon, 14 Sep 2026 14:51:32 +0100 Subject: [PATCH 2/6] arm64: use hw_pte_val for HW PTE atomics MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260914-pte0_arm-v1-2-bb53b663e396@arm.com> References: <20260914-pte0_arm-v1-0-bb53b663e396@arm.com> In-Reply-To: <20260914-pte0_arm-v1-0-bb53b663e396@arm.com> To: Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , Ilias Apalodimas , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Muhammad Usama Anjum X-Mailer: b4 0.16.0 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3D4BF16000E X-Stat-Signature: nrgjshwazp9xhx3wd6mkdnnwx5aa9m37 X-HE-Tag: 1789393933-405658 X-HE-Meta: U2FsdGVkX1/ZEQUdpZ2C9J1jeURoqeHCKE67JuTuasYDo7lQkY1b2HVNpYcb+Xntmi5U00BIf2XoEBKE4zMAqP4zI7kIEBwBbI0atOWXe6WgQQyrZFLvb6Nd6nn/GPV6G9ZkwxTM/ZUFJeqd+773g7+zHktqBlq82uGY67EjHh1oR3bfsDrKOguOHRvlGZw3P8vUll+gHcqHW0Sf4mEXwfKQRtsBUbmSrwPLlkrMgpbuG8+2MzcOx7/sKIo0ETjenTf0qD4TtNJfYqx9yoZsvPcO5axYUDrh3e4lRNZCOoa4SK4JZ6nxr7J6LLW8f+t8AjtnlVaeqb+N98ToVhJHNBoV/my0+47qbbhmfwTdqJQLYQMYSj+Nhj34K+yh5A6LVwXGsB7jtQu4aLlLpgScO6m0vsSf9ak6SEM3FpRnjdcJdQJHKN04zdXRIyI5oQi+dPUNtKuMSQZEwOnE2vGl1u4EvNplG53R1wVz1E1znWNK1c66Y1Yp/rrQA16d8XK7ribV3defrUXNOwjf5El3XVa0LVsKAEBOTlHdFFPOEzGlgu6MEojNXYjOg3fTZbsM08dK8rHO3f7O15UJK/AzV+LPolkNXOqgkB74fHLIvIENkuq7CsXYdyEvHkMh703RUa7okthjgw6lKpAEmDP0jjv/0aNETQ0IziZqljo7TZKxh/cbDYJLPrjiqYwBjPx4512q6GPEXQfx5uE5/rbN8qCysVTkJPLtvh03oi+cM+dDrwnIwVCVsx9WG2SgGUx6ZdeYfDt/kQzjR3X32tONHn0pY66zrMxLtw8yZgpW/idzAzNMQJedpYe7CTlj/gBvuVStsHeAZ13BIVzl8V5qcaNO/ssOjyWYjm+b38WZZzaK8xV5iY2YyzPBV0oBWbnFBDFgBVE8Y8oegwtAhtNDkpFY8LPc8Frt2KduuJ9woiIWk3RUxf6Pc+RUZ/20rZ6Hhwrx2n3wIxjuiSO8EZ6 B/ZA8S8M FQclvgodh/sVz2ekjYmoWXppThFES6VkOHag9V/hwbtVu8Y67qf+HZJ8NLyGYS+iY1RgMsn2vK+Y0p1sC13dtXofUgZ+qBYParsLak5Suh8Cjixl2VOOYA790JNena+YROOyh1kL9mU7VP8w6TU9JGGUW2s+3y3octW+0ANKrC9FvYFXEfNW4rMTLmrg5ITz74EHJ0+wLL/pOMAWnvIavqPx5XbH0SeCqXOYtv9bVkTkRoB46baxRCZjL7RBQtFfFiT+osMoRzCrDq9xPzG7u/kr1HoT344wgAwBooPIZiUHt+jMxbNA6l9r6kQBPmBBLp4gxIF0oMAhR9N8Ni8VH+i+fr1Q1i1pSd3EMRoEUtFazx6xhugWrrWdLWQCzzkXiso7W Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add hw_pte_val() to preserve an lvalue for the HW PTE bits, so atomic updates can take their address. pte_val() expects a SW PTE value and cannot operate directly on a distinct hw_pte_t. With ARCH_HAS_HW_PTE_T, use pte_val() on the wrapper's __pte member; otherwise, use pte_val() directly. The atomic operations and their ordering are unchanged. Signed-off-by: Muhammad Usama Anjum --- arch/arm64/include/asm/pgtable.h | 10 +++++----- arch/arm64/mm/fault.c | 6 +++--- include/linux/pgtable_types.h | 4 ++++ 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 652ce413be389..4768ec59de555 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -1303,7 +1303,7 @@ static inline bool __ptep_test_and_clear_young(struct vm_area_struct *vma, do { old_pte = pte; pte = pte_mkold(pte); - pte_val(pte) = cmpxchg_relaxed(&pte_val(*ptep), + pte_val(pte) = cmpxchg_relaxed(&hw_pte_val(*ptep), pte_val(old_pte), pte_val(pte)); } while (pte_val(pte) != pte_val(old_pte)); @@ -1346,7 +1346,7 @@ static inline pte_t __ptep_get_and_clear_anysz(struct mm_struct *mm, hw_pte_t *ptep, unsigned long pgsize) { - pte_t pte = __pte(xchg_relaxed(&pte_val(*ptep), 0)); + pte_t pte = __pte(xchg_relaxed(&hw_pte_val(*ptep), 0)); switch (pgsize) { case PAGE_SIZE: @@ -1422,7 +1422,7 @@ static inline void ___ptep_set_wrprotect(struct mm_struct *mm, do { old_pte = pte; pte = pte_wrprotect(pte); - pte_val(pte) = cmpxchg_relaxed(&pte_val(*ptep), + pte_val(pte) = cmpxchg_relaxed(&hw_pte_val(*ptep), pte_val(old_pte), pte_val(pte)); } while (pte_val(pte) != pte_val(old_pte)); } @@ -1460,7 +1460,7 @@ static inline void __clear_young_dirty_pte(struct vm_area_struct *vma, if (flags & CYDP_CLEAR_DIRTY) pte = pte_mkclean(pte); - pte_val(pte) = cmpxchg_relaxed(&pte_val(*ptep), + pte_val(pte) = cmpxchg_relaxed(&hw_pte_val(*ptep), pte_val(old_pte), pte_val(pte)); } while (pte_val(pte) != pte_val(old_pte)); } @@ -1830,7 +1830,7 @@ static inline bool ptep_try_set(hw_pte_t *ptep, pte_t new_pte) { pteval_t old = 0; - if (!try_cmpxchg(&pte_val(*ptep), &old, pte_val(new_pte))) + if (!try_cmpxchg(&hw_pte_val(*ptep), &old, pte_val(new_pte))) return false; /* diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index b77f4be88e3ea..7d6c30f27214e 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -225,8 +225,8 @@ int __ptep_set_access_flags_anysz(struct vm_area_struct *vma, /* * Setting the flags must be done atomically to avoid racing with the * hardware update of the access/dirty state. The PTE_RDONLY bit must - * be set to the most permissive (lowest value) of *ptep and entry - * (calculated as: a & b == ~(~a | ~b)). + * be set to the most permissive (lowest value) of the current PTE and + * entry (calculated as: a & b == ~(~a | ~b)). */ pte_val(entry) ^= PTE_RDONLY; pteval = pte_val(pte); @@ -235,7 +235,7 @@ int __ptep_set_access_flags_anysz(struct vm_area_struct *vma, pteval ^= PTE_RDONLY; pteval |= pte_val(entry); pteval ^= PTE_RDONLY; - pteval = cmpxchg_relaxed(&pte_val(*ptep), old_pteval, pteval); + pteval = cmpxchg_relaxed(&hw_pte_val(*ptep), old_pteval, pteval); } while (pteval != old_pteval); /* diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h index d6c5a7548550b..ee4eace5c3e1c 100644 --- a/include/linux/pgtable_types.h +++ b/include/linux/pgtable_types.h @@ -9,9 +9,13 @@ #ifdef CONFIG_ARCH_HAS_HW_PTE_T typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t; #define __pte_from_hw(pte) ((pte).__pte) + +#define hw_pte_val(x) pte_val((x).__pte) #else #define hw_pte_t pte_t #define __pte_from_hw(pte) (pte) + +#define hw_pte_val(x) pte_val(x) #endif #endif /* !__ASSEMBLY__ */ -- 2.47.3