Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Uladzislau Rezki <urezki@gmail.com>
Subject: Re: [PATCH] mm/vmalloc: Use %p for pointer formatting
Date: Fri, 18 Sep 2026 22:14:04 +0200	[thread overview]
Message-ID: <20260918201404.yEHv4zSf@linutronix.de> (raw)
In-Reply-To: <20260918130541.8962a797eeb80cab07b18f19@linux-foundation.org>

On 2026-09-18 13:05:41 [-0700], Andrew Morton wrote:
> On Fri, 18 Sep 2026 12:50:13 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> 
> > Commit 45ec16908e84e ("mm: use %pK for /proc/vmallocinfo") introduced
> > the %pK in order not to leak kernel pointers.
> > Since commit ad67b74d2469d ("printk: hash addresses printed with
> > %p") pointers are hashed by default and the behaviour can be controller
> > by `hash_pointers' boot argument.
> > The policy on %p is to not introduce new ones.
> > Removing %pK makes it possible to remove its handling from the library.
> > 
> > Looking at the output, having the pointer in the output makes it
> > possible to distinguish the individual entries.
> > 
> > Use %p instead %pK.
> 
> Fair enough.
> 
> I added this (important) info to the changelog.  Please confirm its
> accurary.
> 
> : /proc/vmallocinfo has mode 0400, so this change doesn't make kernel
> : pointer information available to unprivileged userspace.

Confirmed.
[%p is hashed by default so things shouldn't change here.]

Sebastian


  reply	other threads:[~2026-09-18 20:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 10:50 [PATCH] mm/vmalloc: Use %p for pointer formatting Sebastian Andrzej Siewior
2026-09-18 20:05 ` Andrew Morton
2026-09-18 20:14   ` Sebastian Andrzej Siewior [this message]
2026-09-19  0:39 ` SJ Park
2026-09-19  7:23   ` Uladzislau Rezki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918201404.yEHv4zSf@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox