From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A434C9831E for ; Sat, 26 Sep 2026 06:19:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7CD16B0093; Sat, 26 Sep 2026 02:19:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D5F6B0095; Sat, 26 Sep 2026 02:19:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44096B0096; Sat, 26 Sep 2026 02:19:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A4EC06B0093 for ; Sat, 26 Sep 2026 02:19:12 -0400 (EDT) Received: from smtpin23.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2133CA07C0 for ; Sat, 26 Sep 2026 06:19:12 +0000 (UTC) X-FDA: 85254910944.23.C992C48 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id 47EF21C0002 for ; Sat, 26 Sep 2026 06:19:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UTmCT6tM; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1790403550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0d2FoQNgB7w5W4igVSjXZBz5vM5BFD2MZGCHDpY+/iY=; b=BfTQTar/zTKvIyq71KFBGQ+gr4I9/9qI9pJ2UBtuRl+e6RbGRcgilkZ7YG1GalgASDep5P oVURnkbidXwtEtz5PpbpTkXJ4RAM0/xysApztUZiPfFt+6RidvRDgGrKBfiyj4oAf20XC/ MyRqABWj8+ErPR21i1Hd8Ody6wWZnc4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UTmCT6tM; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1790403550; b=mOqJYPlRbj54PRwdtQ7Sd1pk31oUM8iBa+WrqAQ3WGI176x3RoSmZcWkqTrk9EiC1FOuLz ysq+ly9O7h3VuZJnibeuwl9BmLSipP4Jt+0AO22OcFaOG71aMd6COGxG1xm7bc3uocJ57p z/a+wds8AndEPSqTBa/f2ZcMbQXY8iQ= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8CA29432E3; Sat, 26 Sep 2026 06:19:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB4691F000FF; Sat, 26 Sep 2026 06:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1790403549; bh=0d2FoQNgB7w5W4igVSjXZBz5vM5BFD2MZGCHDpY+/iY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=UTmCT6tMUksCasct4m6WGBQGIIq91wboZ/ltaw9f0etfNs5HNBcuscWHiY4/AfSPL BF+Ryz+38xr+l3wstvnofOr0t+y/7Ozx6CN/DjlMRcwtAFe75KfAQ223AiHiIfEP6T E+hgCPcbvG4pQJpXrvNXHtGAGpJvfQ8GnCMNLriQ= Date: Fri, 25 Sep 2026 23:19:08 -0700 From: Andrew Morton To: "David Hildenbrand (Arm)" Cc: Kaitao Cheng , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dan Williams , Vishal Verma , Dave Jiang , Alison Schofield , Ira Weiny , Muchun Song , linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, Kaitao Cheng Subject: Re: [PATCH 1/2] mm/page-flags: Define HWPoison test-and-change helpers unconditionally Message-Id: <20260925231908.25febf6c085f52be3a65d59b@linux-foundation.org> In-Reply-To: <6eb272c0-0cfa-4354-a92b-4fc270e3b1fc@kernel.org> References: <20260903053535.17611-1-kaitao.cheng@linux.dev> <20260903053535.17611-2-kaitao.cheng@linux.dev> <6eb272c0-0cfa-4354-a92b-4fc270e3b1fc@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47EF21C0002 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 3seyjnyf7eki35pb7xzqmpbshgzwmjwx X-HE-Tag: 1790403550-521473 X-HE-Meta: U2FsdGVkX1/MlU/rnYIe93Ms9InPzh1IVz0+QC+D/8LtLtAzzyTeBkfQhnLnOuEjiU6ucOJWlfWlT3QL1C4aoWwCO3EGeULft55EeYvIL6BkQ9jsKQMXY1Ou2CZZTnkJ4VWeujC2qESxjq4OK/DB+BcKS7fSN//+q7iF7l5eLqOQ5DG4ibJppZEBUZ5jQkrq4Wd5af/PMjSRuNN2ayUqrjzZGnm3/r2E84iiEKFG2KKCJElrv1dT4DiT1XnnQ3RJQw7hIOVh/c6OioWeQGSQ6QWqhieg1Ygk46Ad47bAwgoH/sDMBulKrGE65OtkfSqu1b69Y/ig81P8eHhvANhUSnxom+oCOwTQqq27H3kfQ2yVax482v8J3FO2vExqKqpusEW8pksoQkuA+MxOFdG6hkdbYNXBliw2/4vo1wUYqvgQ4FvpyhFqZFJF/IYVJGdZWLVwHHSEaxGv4GG4rsnU5S1kpIC3K9kEDoDECcv3c17T0Eu4yKS6PgnwZHDjIeAovxST298sMXYW45C0vEO1gxfPqMRDTTjXPQrG9le0ocyIAz8RMqAUkvpRLVvf3tfFjq24OVcimlBqrHJ5FpGPnuLPeh6Qt95CG5xw5bYF++q2s2wp/ekoG6cY2tkoMYmpKV9CkMxPTHoVrr9mz3hRdxePqwnKIGrzYfZxFl8DlCp9qGZ76DBi7lEWFmjaCqMySmmMX93++VnPjecGd4abjnwD02ZfuV7joOn7463cdphgv/2sowbc77B1QvjwEzAG7b9EVW1nKnxbzIIIHoe64pJ+zifnw6l4lfDtl6yX1MnqfUvZQmkx9WLMmo2iSwPq7PGq8lgK6AbaTC66nlF1dtCLTPsu2zVnSMcYp4seTYF1BfnFeyHdDsFshhHUANDkp2OxqfScHjWKgrgyFEuMw0jT0Puml5gfPSQpFu4pAwqtEKWhUn4/bcCSQ3PR0JQSyM4dS9AP5rkQgYtePMu VJvFMTMR /UHcs3tNkufLQ8BrXgi50YjZ37QuNOV58YonSy3HfGIWLhaJcic561XyQC+z8M00nUvsSertEV+wumxAw4TUMYC8UlbEuK4opdUN98Tk/KdSdaGpc2hfw2lX3k8CcRqpci1OnNwbhyUIasMaRvP8XguITBYJpj6oNNDTmikT6i8LYghV3KE60hJzjOn/Efan9xQacJmno7T2iNWoZXHR+W0Ag+stNk4AblqJoDcMyVWIKBRpNpXqpS8KU+fZZGfXZ8U7kTnx/NNMpkrlJPTypCP4Z6W67mRGeGax44PkoRE86D1AzdNdFgBEicDVpnWQRkOPg/eEASwIPsnc3NxwMe4xvqpueolZfNUjOD6rHzL/ArPtD8yJhMF3R13qg8a4SLrlcsi+ItTQIpXCndaYiYJi033TV8AgIM7uhGurSYUzeX2LErVJ0WsNuPcVR+C3I5csUHa8ny84/nvmC7oOTIOC6m0JjQmmGpO5naySltaRTafPByTaMUWUDVQ== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 7 Sep 2026 17:42:11 +0200 "David Hildenbrand (Arm)" wrote: > On 9/3/26 07:35, Kaitao Cheng wrote: > > From: Kaitao Cheng > > > > Page flag helpers for configuration-dependent flags provide false or no-op > > variants so that their users can be independent of the configuration. > > > > The HWPoison helpers do not fully follow this pattern. When > > CONFIG_MEMORY_FAILURE is enabled, PAGEFLAG() and TESTSCFLAG() provide the > > regular, test-and-set, and test-and-clear operations. When it is disabled, > > only PAGEFLAG_FALSE() is instantiated, leaving TestSetPageHWPoison() and > > TestClearPageHWPoison() undefined. > > > > Use TESTSCFLAG_FALSE() to provide the missing accessors when memory failure > > handling is disabled. Both accessors return false, which is consistent with > > HWPoison state being unavailable, and makes the accessor interface > > consistent across configurations. > > > > Signed-off-by: Kaitao Cheng > > --- > > include/linux/page-flags.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > index 7a863572adce..a2315ab1dd3a 100644 > > --- a/include/linux/page-flags.h > > +++ b/include/linux/page-flags.h > > @@ -656,6 +656,7 @@ TESTSCFLAG(HWPoison, hwpoison, PF_ANY) > > #define __PG_HWPOISON (1UL << PG_hwpoison) > > #else > > PAGEFLAG_FALSE(HWPoison, hwpoison) > > +TESTSCFLAG_FALSE(HWPoison, hwpoison) > > #define __PG_HWPOISON 0 > > #endif > > > > Can we just squash this patch into #2 please? I did that. From: Kaitao Cheng Subject: mm/page-flags: define HWPoison test-and-change helpers unconditionally Date: Thu, 3 Sep 2026 13:35:34 +0800 Page flag helpers for configuration-dependent flags provide false or no-op variants so that their users can be independent of the configuration. The HWPoison helpers do not fully follow this pattern. When CONFIG_MEMORY_FAILURE is enabled, PAGEFLAG() and TESTSCFLAG() provide the regular, test-and-set, and test-and-clear operations. When it is disabled, only PAGEFLAG_FALSE() is instantiated, leaving TestSetPageHWPoison() and TestClearPageHWPoison() undefined. Use TESTSCFLAG_FALSE() to provide the missing accessors when memory failure handling is disabled. Both accessors return false, which is consistent with HWPoison state being unavailable, and makes the accessor interface consistent across configurations. Also remove now-unneeded test_and_clear_pmem_poison() from nvdimm/pmem. Link: https://lore.kernel.org/20260903053535.17611-1-kaitao.cheng@linux.dev Link: https://lore.kernel.org/20260903053535.17611-2-kaitao.cheng@linux.dev Link: https://lore.kernel.org/20260903053535.17611-3-kaitao.cheng@linux.dev Signed-off-by: Kaitao Cheng Signed-off-by: Andrew Morton Acked-by: Muchun Song Acked-by: David Hildenbrand (Arm) Reviewed-by: Oscar Salvador Cc: Alison Schofield Cc: Dave Jiang Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Michal Hocko Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Vishal Verma Cc: Vlastimil Babka Cc: Ira Weiny --- drivers/nvdimm/pmem.c | 2 +- drivers/nvdimm/pmem.h | 12 ------------ include/linux/page-flags.h | 1 + 3 files changed, 2 insertions(+), 13 deletions(-) --- a/include/linux/page-flags.h~mm-page-flags-define-hwpoison-test-and-change-helpers-unconditionally +++ a/include/linux/page-flags.h @@ -655,6 +655,7 @@ TESTSCFLAG(HWPoison, hwpoison, PF_ANY) #define __PG_HWPOISON (1UL << PG_hwpoison) #else PAGEFLAG_FALSE(HWPoison, hwpoison) +TESTSCFLAG_FALSE(HWPoison, hwpoison) #define __PG_HWPOISON 0 #endif --- a/drivers/nvdimm/pmem.c~mm-page-flags-define-hwpoison-test-and-change-helpers-unconditionally +++ a/drivers/nvdimm/pmem.c @@ -80,7 +80,7 @@ static void pmem_mkpage_present(struct p * here since we're in the driver I/O path and * outstanding I/O requests pin the dev_pagemap. */ - if (test_and_clear_pmem_poison(page)) + if (TestClearPageHWPoison(page)) clear_mce_nospec(pfn); } } --- a/drivers/nvdimm/pmem.h~mm-page-flags-define-hwpoison-test-and-change-helpers-unconditionally +++ a/drivers/nvdimm/pmem.h @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ #ifndef __NVDIMM_PMEM_H__ #define __NVDIMM_PMEM_H__ -#include #include #include #include @@ -31,15 +30,4 @@ long __pmem_direct_access(struct pmem_de long nr_pages, enum dax_access_mode mode, void **kaddr, unsigned long *pfn); -#ifdef CONFIG_MEMORY_FAILURE -static inline bool test_and_clear_pmem_poison(struct page *page) -{ - return TestClearPageHWPoison(page); -} -#else -static inline bool test_and_clear_pmem_poison(struct page *page) -{ - return false; -} -#endif #endif /* __NVDIMM_PMEM_H__ */ _