From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FF59C9832A for ; Tue, 29 Sep 2026 03:43:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B0786B00A0; Mon, 28 Sep 2026 23:43:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 488D46B00A1; Mon, 28 Sep 2026 23:43:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A0296B00A2; Mon, 28 Sep 2026 23:43:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0FA9A6B00A0 for ; Mon, 28 Sep 2026 23:43:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7FCB5C0383 for ; Tue, 29 Sep 2026 03:43:10 +0000 (UTC) X-FDA: 85265404140.07.768F4A0 Received: from flow-b2-smtp.messagingengine.com (flow-b2-smtp.messagingengine.com [202.12.124.137]) by imf08.hostedemail.com (Postfix) with ESMTP id 9571A160004 for ; Tue, 29 Sep 2026 03:43:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ownmail.net header.s=fm1 header.b="m/bjmYXV"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=Pxstf1lI; dmarc=pass (policy=none) header.from=ownmail.net; spf=pass (imf08.hostedemail.com: domain of neilb@ownmail.net designates 202.12.124.137 as permitted sender) smtp.mailfrom=neilb@ownmail.net ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1790653388; b=v1x20SvamxpAi4FuIaeK1nZHABU/JK4czx3bOEedw0inPQ8Sdr3JA+eJ/i7FEEWSbZLdLT 5BnWGjJFtnAcdmQN2rEb0rqiBiGE705rgQahcL4bXyYgmnTtxgv4/FKCkRQ4XNZg9HHWwb v16oRzLN/BWWE3DSfGw9k4GDmcez+B4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ownmail.net header.s=fm1 header.b="m/bjmYXV"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=Pxstf1lI; dmarc=pass (policy=none) header.from=ownmail.net; spf=pass (imf08.hostedemail.com: domain of neilb@ownmail.net designates 202.12.124.137 as permitted sender) smtp.mailfrom=neilb@ownmail.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1790653388; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mN/2SSV8bIw24exSybjBxan284YWLD0YYt6t0Umtf4c=; b=RumZiSn5Lf5u2Gt99Nu5LVhQSoctQyE2QSq4rQSOL9tqRbdcu2x8rwQyumnQ5PNugqXNpR I+WCiuP52GniwMbM8NB1WeUIPzNKGKAlu2B8p/xvPJIuXoecj3IAqHI1IkCFGunLrMt3jJ pxbvVdDPeHAXKqFm2WSSVbIiVt6w3HI= Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.stl.internal (Postfix) with ESMTP id 51A15130193A; Mon, 28 Sep 2026 23:43:07 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Mon, 28 Sep 2026 23:43:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ownmail.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to; s=fm1; t=1790653387; x=1790660587; bh=mN/2SSV8bIw24exSybjBxan284YWLD0YYt6t0Umtf4c=; b= m/bjmYXVAasRh0xyF47KEJG7Zmxn+6bI3gtqt6ip5j8TEoMZ9giVbJuvHbF32LqQ J1gB7diA96j64dY9ryX7i43LR5NE/GXc6xeEHLMIUsXaApdieqrSshs1tGV7eGIN cBUfQXA+T6z0cao/bSPqATRc0x9EDT8ldEERb05yMPmFLsMlN+L72e9O680wJRJZ zK7L9yLeSEqtGdum6RwlFdBIeS66RVKw4AAvBo6WoY8CFdqTosftV2pKqhxPvgit x2WTD0Y/SNSJJTWkGVgXjDNZ/Wzano1HkG4RwF+n94lSOkPGDOYxUrtjK2wxrbGE B8ypvNrW2u15OJmYsv/n/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1790653387; x=1790660587; bh=m N/2SSV8bIw24exSybjBxan284YWLD0YYt6t0Umtf4c=; b=Pxstf1lIaYJ6It2Dt XYl09MKu5wXe6DyBDfDoIngstyuriZxvJ66IXljztAMGQlQaTTz8Wzp6hPdCF8bb +h2Py2iXvqZ3nuMfdPLVhtcxaefT9HM9QXlb4zifQPYLblx1Zo8b+xcBl4kW/7nt xsspas6tl2BRodH/Dz6SRFhmXjGiGpwVJPUrPxRshJibVDKdao9wBMfufPkOCJl8 HEkWPmseCLuMoKx5AHjwkTeocSsqSAaVRicS/nEjoxk9yj3XlxsQg5q+0cF1F+Hz z3eVrnBAdkaSXew2JYNo9t8EW2OdRoRhPvgdaoA9HuZsIIVeu3BDFuWC6a8PCAhQ 5E41g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGoJB+17Zq7ThrEPjmxn4ZGYu519RzWwVi/88aejzKjstMboztaed73ef7D6avpE+ +4ud1a3y7i3orjwLfnXoctNyz4isc8MlqqkCj9w/LgYTxltRiENCW6GCIqrBIGfd6BoOtn 3U4T9DnMQq0t334tHmkLT0tBGbfhvTaaBwaOBKtxwtl6WpY46qwankbHLMumQlIvXZxJZX MK4M+NdZABlSsm1lFGpu8Zoavf0+po6/QQ3FmqOSdXOPNwreWLw4U6EONlQdAFPuoTNGlS rFYPmLdcGE1rV4M0fAMpJKofG+st3+8PfQ+b7I9sMwGW86B3jq8HWH1QNmIbUmtd6GqseK WXBUUBpFFgHeK9liDg6OqtGpj503qSZRpKFKN80ywKozzDLGfTIpNSRIpB0J7X9j9kdDFo NfP0M85lsYUf++BKyCpxcDEiYTPrJoAH8DW5zTa5+tEaGnTn6IQGdE5otaXfk/OhUSHo+d QtS1DlHqPu5wnj79Rv5/H8vkxZKWrTFKnHex9Nm3oRCq/HyRSwEmRvgSr1/p+Cr6f7cDut lLam5cR2VTzEn2u/ohPNQCHnE/CPKmlmMgCBKphlenALV49psp5KqhSOhI3YnTVHwZ8CPq nywlxVlrO0ModMzqKT8z8ZRgDn5Mr5lMOd5yuzk4bhk/SVJdYTVGY/z5TZwQ X-ME-Proxy: Feedback-ID: i9d664b8f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Sep 2026 23:42:59 -0400 (EDT) From: NeilBrown To: Miklos Szeredi , Amir Goldstein , Kees Cook , Joel Granados , Richard Weinberger , Anton Ivanov , Johannes Berg , Breno Leitao , Andreas Hindborg , Jan Harkes , Hugh Dickins , Baolin Wang , Namjae Jeon , Hyunchul Lee , Carlos Maiolino , Alexander Viro , Christian Brauner Cc: Jeff Layton , Jan Kara , linux-fsdevel@vger.kernel.org, fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-um@lists.infradead.org, codalist@coda.cs.cmu.edu, coda@cs.cmu.edu, linux-mm@kvack.org, ntfs@lists.linux.dev, linux-xfs@vger.kernel.org Subject: [PATCH 4/7] configfs: remove d_add() calls before configfs_attach_group() Date: Tue, 29 Sep 2026 13:36:04 +1000 Message-ID: <20260929034158.1455429-5-neilb@ownmail.net> X-Mailer: git-send-email 2.50.0.107.gf914562f5916.dirty In-Reply-To: <20260929034158.1455429-1-neilb@ownmail.net> References: <20260929034158.1455429-1-neilb@ownmail.net> Reply-To: NeilBrown MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Stat-Signature: o5b65oc47m47xw7ktn151jo1wibro3nu X-Rspam-User: X-Rspamd-Queue-Id: 9571A160004 X-HE-Tag: 1790653388-878872 X-HE-Meta: U2FsdGVkX19vgYXMbwV4jK9ioQYxIQIxyP8807ziLGvgSD9pJ2PtJnXFwNmH28xAoEjuuQxwCWW6cRwC/Z+lE1XHImQHa5v7Qgk9TKt5uKqIluzsGbu+CTHaE8ulGbyNjhsw+3aVntQzT45cw/rfLGVZ5dFh1dd89BJhA+99uNej8K8VFBlXxs55zJq6T30ZRCk0ufBFgGMAqjEV0KcbcZO2jcPTMTihtF3cG6HiasIOx0Routmf4sl0TTy5tUVUKasEd023/A8K1TsAbefBiWh8bozIcP/Qhfkruova0IvRYTxh59t8sTJC9OUzrZFafYQCoN3KyskF2FJAa6S86b2QLnt7OXLQlW/eRQE2AUkIm2LHxucxWxxEUhXrA+OX2luetPK8y5D3xUKxJolSQow099NwG7WJwTiz5gpXhpvhssCW8xDtTfsEjjzsGFisLdE4ZyZEECNd//xMpIQiIMW3NyIMx/f7EEaFsIi5IYNT/Z9hGBJt2+IsCHwVGxqGEpZzTW6syAcn+rtlxwZEXOiLum0ktnbaMLY2+VrDb5cPUUzxX2QJTNDP5xfQP4S+YUngfvjMzzHzszZS+Tz7WHt7daDXURTWQ0e682c6RyfWktf9E81rNLPrueU384EGD3n6wahsw07l+BtvTNGWIp8DqZzmhi17ynVEbBLPRvMYeQqK29jltEVrawrZ38dco9xllyYgVG0Jxw/fUjhFqODNxBelc33jboanZtqG9V0wugz0Rt4FoDVRU+0g0ANIE6hkEOJDC1QQ69ZQHE87Nb8Q68qiRX5xMhiuV9eSp9zPLUeqDreJFpWjzi9jtBWOhtLlhgpJaarbPG+r2jO3Dv1L20Of81+UnfjZXV3YruugZq33HHkfdkx9lYjbe2mivxotG8NcR9xkfVgEQgGHQ9NZtUqN95mFJM00lgbayt48bF98R269wgk6GIsJO0WProoSTr6GTE5s8SxQtrp OGXw8uYp WUclEndBzPTv3TsY/MLhQBVx/EETvmMvm+172T+otTD8HgGqnaG+ENiZXx+5CdrCSEEoeTRHhhfhFKg14+XQSXLHQ3TLs1qdSiASXzZQdZAemLi9JvDqpuZMifXVYQKuABMHG+4DUzZJnXg9SWwysTM9S1mhKjBl7fEkjDxdVypjUucBgkurtaU6sinfX1xqfQ43pvEOewe90gwIoCJx6Bog18wcIogIDdswLy07q0xNbHXPMNSkZvUIOk0pNFgXXD3JS8z11zU7hQHjBW7K35bqoXxjJXTvt1Ngtzl2s77RTxl0z7WFhXNaHJ1Hg4Im5aup5hdM9RUdV7v/sHKd5ij1GQ7q8uCBKTU3EbebQ8Lr+alqWz8QWzafu9TYzOiorLnc5Yjd2nGsABp2GKePbTgi+40LKlNsRjFrSPxrs1la4eEuSXd6HHxEbfA0At8OfzUr/yDXmPTMjGi11JBO0Z37bDd08iclt+6hJ9oB5IVud/Fas0JrTuveR+GyaySm2x6HW7SzRZvO+IBiQTOr0ksOjrQBwOfT6E5Kb1q6g4ts+zQ2hXt6AwudPtyj7LUOKWAbNTESzH/rob7yvy46bLTskSq7UbT6a4ubn6lCzbR0RxPLo6dEXFDbuP74vBc4Q8CC1c/qjkZIurwpcvkrHcozOhYvJif3mUcExKVtts2uP2CtA+Hz4QaOI7yfC1MHGJBLiAL49YV7y+VymeMia/u4Qfg== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: NeilBrown These d_add() calls cannot be necessary. The inode given is NULL so all they do is attach the dentry to the hash table. If configfs_attach_group() fails, then d_drop() is called so the dentry will be detached. If configfs_attach_group() succeeds, then configfs_attach_group -> configfs_attach_item ->configfs_create_dir must have succeeded, so d_instantiate() will have been called and the dentry hashed there. So the only effect is that the dentry will be hashed-negative for a short period which will allow a lookup to find nothing without waiting for the directory i_rwsem. I can find no indication that this might be important. Adding a dentry as negative, and then later making it positive is an unusual pattern and appears to be unnecessary, so it is best avoided. Signed-off-by: NeilBrown --- fs/configfs/dir.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 3c88f13f1ca2..145a092171fe 100644 --- a/fs/configfs/dir.c +++ b/fs/configfs/dir.c @@ -715,8 +715,6 @@ static int create_default_group(struct dentry *parent, ret = -ENOMEM; child = d_alloc_name(parent, group->cg_item.ci_name); if (child) { - d_add(child, NULL); - ret = configfs_attach_group(&group->cg_item, child, frag); if (!ret) { sd = child->d_fsdata; @@ -1901,8 +1899,6 @@ int configfs_register_subsystem(struct configfs_subsystem *subsys) err = -ENOMEM; dentry = d_alloc_name(root, group->cg_item.ci_name); if (dentry) { - d_add(dentry, NULL); - err = configfs_dirent_exists(dentry); if (!err) err = configfs_attach_group(&group->cg_item, -- 2.50.0.107.gf914562f5916.dirty