Re: [PATCH] mm/damon/reclaim: improve grammar and style

[SJ Park <sj@kernel.org>]

On Fri, 16 Oct 2026 20:34:51 +0800 Aveline Noir <jm5905938@gmail.com> wrote:

> Hi Manuel,
> 
> A few suggestions from my view for you here :)
> 
> On Thu, 15 Oct 2026 10:06:23 +0200, Manuel Ebner wrote:
> 
> > @@ -30,12 +30,12 @@ guests could mitigate this problem.
> > -DAMON_RECLAIM finds memory regions that didn't accessed for specific time
> > +DAMON_RECLAIM finds memory regions that weren't accessed for specific time
> >  duration and page out. To avoid it consuming too much CPU for the paging out
> 
> "weren't accessed" fixes the grammar, but "page out" still doesn't
> agree with the subject. How about "DAMON_RECLAIM identifies memory
> regions that have not been accessed for a specified period and
> attempts to reclaim their pages.".

That's entire sentence rewriting.  We could consider doing that, but maybe
that's better to be done via another patch.  Let's focus on simple grammar and
style in this patch.

How about simply 's/page out/pages out those/'?

> 
> >  operation, a speed limit can be configured. Under the speed limit, it pages
> > -out memory regions that didn't accessed longer time first. System
> > +out memory regions that weren't accessed longer time first. System
> >  administrators can also configure under what situation this scheme should
> 
> "weren't accessed longer time first" sounds a little strange to me.
> Maybe "Within the configured speed limit, it prioritizes regions
> that have been idle longer for reclamation." would read better?

Let's do such rewriting with another patch.

> 
> > @@ -88,11 +88,11 @@ identifies the region as cold, and reclaims it.
> >  sampling and aggregation intervals. The auto-tuning aims to capture meaningful
> >  amount of access events in each DAMON-snapshot, while keeping the sampling
> > -interval 5 milliseconds in minimum, and 10 seconds in maximum. Setting this as
> > -``N`` disables the auto-tuning.
> > +interval to 5 milliseconds in minimum, and to 10 seconds in maximum. Setting this
> > +to ``N`` disables the auto-tuning.
> 
> Maybe "between 5 milliseconds and 10 seconds" would read more
> naturally here.

I concern if readers could confuse if the range is inclusive or exclusive.  I'd
prefer the current sentence.

> 
> > @@ -113,8 +113,8 @@ quota_sz
> >  Limit of size of memory for the reclamation in bytes.
> >
> > -DAMON_RECLAIM charges amount of memory which it tried to reclaim within a time
> > -window (quota_reset_interval_ms) and makes no more than this limit is tried.
> > +DAMON_RECLAIM recordes the amount of memory which it tried to reclaim within a time
> > +window (quota_reset_interval_ms) and stops when this memory limit is reached.
> 
> Agree with SJ that "charges" fits better here, since this is quota
> accounting. 

Makes sense to me.  What do you think, Manuel?

> 
> > -While keeping the caps that set by other quotas, DAMON_RECLAIM automatically
> > +While keeping the caps set by other quotas, DAMON_RECLAIM automatically
> >  increases and decreases the effective level of the quota aiming this level of
> >  memory pressure is incurred.
> 
> Maybe "While respecting the limits imposed by other quotas," would
> be another option I think.

I feel like that's out of the scope of this patch.

If both of you agree to my abovely suggested/agreed changes ('s/page out/ pages
out those/' and 's/records/charges/'), I will update this patch in damon/next
tree with those changes.


Thanks,
SJ

[...]