From: SJ Park <sj@kernel.org>
To: CharSyam <charsyam@gmail.com>
Cc: SJ Park <sj@kernel.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
akpm@linux-foundation.org, bijantabatab@micron.com,
ravis.opensrc@micron.com, bijan311@gmail.com
Subject: Re: [PATCH] mm/damon/vaddr: preserve migration weights above UINT_MAX
Date: Tue, 27 Oct 2026 17:54:52 -0700 [thread overview]
Message-ID: <20261028005452.157810-1-sj@kernel.org> (raw)
In-Reply-To: <CAMrLSE6ySuzsJJX-KXoeG49pS4ZVbNWZve1dwj1v1avAhHeEdQ@mail.gmail.com>
Apparently Bijan's micron email is no more working. I added Bijan's gmail to
Cc list.
On Wed, 28 Oct 2026 08:57:06 +0900 CharSyam <charsyam@gmail.com> wrote:
> Hi, SJ.
>
> Thanks for your reply.
You're welcome!
>
> 1. I found this by code inspection, not from a real-world bug report.
> I consider it a correctness issue for valid inputs.
Thank you for clarifying.
> 2. I would prefer a u64 total over rejecting those inputs, since the
> interface does not document a limit on the sum of weights.
But I doubt the value of documenting it. I wonder if real users will find the
behavior at all. I think it would be not too late to consider documenting it
after we get an issue report from a real world user.
Even just keeping the current behavior looks not really bad to me, as long as
it is easy to test and only shoot the foot of users who didn't run test for
their weird inputs. We can revisit after a real issue report is delivered.
What do you think?
> 3. Given the lack of a reported real-world impact, I do not think Cc:
> stable is needed.
Makes sense, I agree.
Please avoid top-posting [1] from the next time.
[1] https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-10-28 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 3:54 [PATCH] mm/damon/vaddr: preserve migration weights above UINT_MAX Daemyung Kang
2026-10-27 6:45 ` Aveline Noir
2026-10-27 13:53 ` SJ Park
2026-10-27 23:57 ` CharSyam
2026-10-28 0:54 ` SJ Park [this message]
2026-10-28 14:44 ` CharSyam
2026-10-28 15:00 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028005452.157810-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bijan311@gmail.com \
--cc=bijantabatab@micron.com \
--cc=charsyam@gmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=ravis.opensrc@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox