Re: [RFC PATCH v2 6/6] selftests/damon: remove unused imports of os and sys modules

[SJ Park <sj@kernel.org>]

On Sun, 01 Nov 2026 17:20:33 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] selftests/damon: commit subject names wrong removed modules
> --
> 
> commit dfc99fb0f6f595e8bf824229e67f0b391cab2a8e
> Author: SJ Park <sj@kernel.org>
> 
> selftests/damon: remove unused imports of os and sys modules
> 
> This commit removes unused Python module imports from
> sysfs_no_op_commit_break.py and sysfs_update_schemes_tried_regions_hang.py
> in the DAMON selftests.
> 
> >     selftests/damon: remove unused imports of os and sys modules
> >     
> >     sysfs_no_op_commit_break.py imports 'sys' module but never uses it.
> >     sysfs_update_schemes_tried_regions_hang imports 'time' module but never
> >     uses it.  Remove the unnecessary imports.
> >     
> >     The issue is found using flake8.
> >     
> >     Signed-off-by: SJ Park <sj@kernel.org>
> 
> [Severity: Low]
> As reported by Sashiko on RFC [1], should the commit subject be updated to
> refer to the sys and time modules instead of os and sys?

Yes, I forgot updating the subject.  I will do in the next spin.

> 
> In tools/testing/selftests/damon/sysfs_no_op_commit_break.py, the patch
> removes import sys while import os remains and is used in
> dump_damon_status_dict():
> 
>     file_dir = os.path.dirname(os.path.abspath(__file__))
>     dump_script = os.path.join(file_dir, 'drgn_dump_damon_status.py')
> 
> In tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py,
> the patch removes import time while both import os and import sys remain and
> are used at module scope:
> 
>     sys.path.append(os.path.dirname(os.path.abspath(__file__)))
> 
> [1] https://lore.kernel.org/r/sashiko-outbox-192115@kernel.org
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261101171630.81477-1-sj@kernel.org?part=6
> 


Thanks,
SJ