From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 91904606B918 for ; Wed, 4 Nov 2026 17:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=k29wYoDm Received: by kanga.kvack.org (Postfix) id A73CC6B05BF; Wed, 4 Nov 2026 12:29:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A243B6B05C0; Wed, 4 Nov 2026 12:29:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 913616B05C1; Wed, 4 Nov 2026 12:29:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7361D6B05BF for ; Wed, 4 Nov 2026 12:29:52 -0500 (EST) Received: from smtpin13.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 07D6A1C3D51 for ; Wed, 4 Nov 2026 17:29:52 +0000 (UTC) X-FDA: 85398124224.13.0487177 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf17.hostedemail.com (Postfix) with ESMTP id 3531D40002 for ; Wed, 4 Nov 2026 17:29:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=k29wYoDm; spf=pass (imf17.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1793813390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jP/hayhlpAKZdjJKk3r9BHeVVOYyvJcLU3d1z3kH9u8=; b=g3OeiqSE1kxJr8se0Z1O9xmOXE3gv85NOlZV2x9Vjp21GmMG12bC24Kp8aLEWURmWcdz+O C7f0uIZ3QXknR94S5RQvSrlYZv17ihgSFRzOduv/P6Yg0tRFf50RGk0OhHc+e9MI/3mHx1 1cvSTBpvMxCIN1aLT/CErE+0Y4CoAl8= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1793813390; b=d5VmQ7DNjXGlHTHy/aSKqUojEPgcGRKaSqCI3Y4mGhevas2JdZxFumvuLz3GCyq7qwVjqJ tyYzgkTAiB8n3slgwwJJ8lkyzntCxPVqxu2YdUkcT28ctKDTn+AIfsXExBFQsxFpk0zDWp kmbEZDUmxAVMXi/v/E/7hozLxgGXLOw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=k29wYoDm; spf=pass (imf17.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8AA6140888; Wed, 4 Nov 2026 17:29:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F7C51F000C1; Wed, 4 Nov 2026 17:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793813389; bh=jP/hayhlpAKZdjJKk3r9BHeVVOYyvJcLU3d1z3kH9u8=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=k29wYoDmBb6ORIk/YigyTAaPtSyeooMT9Gehkig8HAb2s5/Z8UK6XLxRTz9EDVGnx eGiDz9bKPGnbG5+h4f2SaQeQuToessREwOdzcuVK45laKtepD5/4l2EkSVetuFazGP CpZi4D+axCqGJyyCzcjUodz4iFV75O3vIJZr+FuouuBv26oCOdXws7TH/pp445vvA+ XWOP3PhxdwKX/fQLJFUO/FuU7suEDOp3lVbp7cTbUmYfkzbYCBmWMOBUGP0APptS+H BJ5uoSpfpKEmuDle2PpFnddFwy9xwQS99ffHUVrrShSkfHcu9R7iUf2ztEg6CLx6Z0 avdFtYzV4BmjA== From: Christian Brauner Date: Wed, 04 Nov 2026 18:27:22 +0100 Subject: [PATCH v2 05/51] xtensa: simdisk: remove the proc entry before the disk X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261104-work-procfs-bugfixes-v2-5-bbf7d5546809@kernel.org> References: <20261104-work-procfs-bugfixes-v2-0-bbf7d5546809@kernel.org> In-Reply-To: <20261104-work-procfs-bugfixes-v2-0-bbf7d5546809@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Jann Horn , Josef Bacik , Chris Mason , Jeff Layton , NeilBrown , Eric Dumazet , Thomas Gleixner , Al Viro , Jonathan Corbet , Christoph Hellwig , Greg Kroah-Hartman , Joel Granados , Kees Cook , Jan Kara , Jan Kara , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" , Chuck Lever , stable@vger.kernel.org X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1246; i=brauner@kernel.org; h=from:subject:message-id; bh=f7Qg/00vnZM3tuJ138yAFxD6JPv6/GBN+HDx2x0z8gg=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWS9zvo3+8l6vuY9izMzGv+zF0+8zvxIgy/yWdNkY/Huk 2e/XjWN6ihlYRDjYpAVU2RxaDcJl1vOU7HZKFMDZg4rE8gQBi5OAZhIUDXDX1nmkANzS/S1E9dt 3WFX/Lro3morHw1n24ovs6+YTz8QwsjwT6HT/Ztok6F1lkCbjcPRzduKzU87T1/j1tyZf3L9t5Y fLAA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Rspamd-Server: rspam09 X-Stat-Signature: hgue13bykqxnmu5gkbxsecg7tr8ork9f X-Rspamd-Queue-Id: 3531D40002 X-Rspam-User: X-HE-Tag: 1793813390-376417 X-HE-Meta: U2FsdGVkX1+bujdwX2+pIrkGfcKDNfIxVkv24ovc1kVZfOGjtmEophEm/uUo4blnXBghG1QyDebqrgL/Fj7IzaMY5ELU2EgOHOIlsZervZeXtXcrN4pYqLegBApGVgZIulP+E4gMx4DDl1ykgATtqlckb10G/6Ok0NXIH/KeccOMGKOM+SqMzRaZtxygO5jvfTEHXq24eLR8mIg4zWOwC5ACVYXVviXisnAp5acFQFWAcdlt9i8Qjh6vFt5xIEvE0hUVA/qGvz0nM9SAgXL0hmx10hRTLKvdJo1XDbJwNXYUjPceG5A3EpAx+ZswEbUCHKNTtLS+uX9nrFAZZ3IZltNNzJ7uLzMafRfYNkALSzQoapavVU59hNCDe2bdRj6Y7XR3pnmG38kbZbvbbx5bWMY6B2vCpRGCRDvg2rYLpPa2L0rxH6YKxiFIbELIUKm93b+RjhR3nulFQtrBVUYBZ8iZlLeHl+SWmf9jsadVag8HQK1TDRf0Z8q2OZ6FkbETKXJAFF8Jon9gQ6Lyxx1y4ElFnG6Ait4GZwTL0cHK+VnRX8XVT4B/1WuV2CZ74R08+SarHay0dQC7hrNd+xTveIUyHXBvAC9qdXC3DZ5hu1PCb4vJ5/pG6KtaLmUxn+YShDpo5tJSpIlGpMb3qWb3ShH0WZR1scG6JAwZji9rn2EQpBsVTixzduXZ042M5vNyvqe+L1nxs7iK2dJP702jyXn7OM7OYh/KbtPQfO1ww2FtJVN710NhJYHRISn887hBM5opEqsTLDkJriESCwWKlNYKOMj3mXraZqUTHn9CnvZc/OqnLEJLtJhIyQmZ5o2UcmFhMe/UoAAx+pNoD/wooUHMUaZa8nkB88g6zs7Y5579tM8nQGQrbkuUTJHiqbn5mhgcXROgqRrWo/E+Zo2cteKbBggTwsElAMGnIVzjGbL3JnNfDYwEenG9VNPAaf10hXhaGIjCugK4lfblglf lljrQ4Ze UbtsJPH31WBOHAoMkVJHvlGONLIV7ptw9AZ7WDMtKnweoo44QtJNzYWu66+kop7iD9yYA62MLRYZRelhulkPvDP3lpPHQ73UnrQo2JaBo/wzW2yDFeFnHH0juzl/5xenY1poM4Sutx05lYKCYyIyxJt4hKEDS5sXv5LmYftOORpNhjF0ChPoKtu+koroQxCkbhmT7Uuaaj7Lap5w86HBKdwCWd6AH8rkTLRibacvNwyYDXZKv88nlCpEHQGzsAe27uhdpwiZJBJ0otVwxZJ8nvPW4VucpeVZMOYcK Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 simdisk_teardown() frees the gendisk and only then removes /proc/simdisk/. A write to that entry in between attaches the file that was written to the disk, and simdisk_attach() sets the capacity of the gendisk that is gone. Remove the entry first, remove_proc_entry() waits for a writer that is in the middle of that. Fixes: b6c7e873daf7 ("xtensa: ISS: add host file-based simulated disk") Cc: stable@vger.kernel.org Signed-off-by: Christian Brauner (Amutable) --- arch/xtensa/platforms/iss/simdisk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index a2ddb49c269d..e51edb8cf872 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -379,12 +379,13 @@ static void simdisk_teardown(struct simdisk *dev, int which, { char tmp[2] = { '0' + which, 0 }; + /* a write to the entry attaches a file to the disk, so it goes first */ + remove_proc_entry(tmp, procdir); simdisk_detach(dev); if (dev->gd) { del_gendisk(dev->gd); put_disk(dev->gd); } - remove_proc_entry(tmp, procdir); } static void __exit simdisk_exit(void) -- 2.53.0