From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 696CF606A329 for ; Mon, 16 Nov 2026 14:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YU0t6OjF Received: by kanga.kvack.org (Postfix) id 55A1E6B05B0; Mon, 16 Nov 2026 09:21:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E43A6B05B1; Mon, 16 Nov 2026 09:21:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ABBE6B05B2; Mon, 16 Nov 2026 09:21:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0C49D6B05B0 for ; Mon, 16 Nov 2026 09:21:39 -0500 (EST) Received: from smtpin04.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7F89EA86CA for ; Mon, 16 Nov 2026 14:21:38 +0000 (UTC) X-FDA: 85441195476.04.16D58E8 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf11.hostedemail.com (Postfix) with ESMTP id A568A4000A for ; Mon, 16 Nov 2026 14:21:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=YU0t6OjF; spf=pass (imf11.hostedemail.com: domain of a.hindborg@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1794838896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=avroJVXI7FYPP9BX1mpXsZCBZ9F8Uq429Emp0GZBvxk=; b=iZaPxL6deOQ4LjBjz3puStFF8e6IcNOqk7DtWAccSlbQ2RVQZ6sU+y4/K6g5arozOJPhLM OwvPoGYWSHfIdIXPa11ZUJyPODVp9SYgBwTQpMWqVPDvp+5hqq0cMh/6dNO/lLcV+BVuJE 3oNOB6Nb8r+XXmJ9OfbQQLeunCSBJUw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=YU0t6OjF; spf=pass (imf11.hostedemail.com: domain of a.hindborg@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1794838896; b=xgVOH2HGodXeraNeLEfN14pspWT74UE1l+2F/9d89alGzzz+Iz0c0Xbp03mktmucgg8TLG Xft0kqi7xzxxYO+KaWt7SMMEaJmpfZbjYS8uXW5q5Sn1I7r6X7C6EuasTmVzMusIKi9Du7 Pfn5zhb9L9dCTWdTkovBdPkFhhKc8Rg= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D0F86437F8; Mon, 16 Nov 2026 14:21:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7252A1F000C4; Mon, 16 Nov 2026 14:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794838895; bh=avroJVXI7FYPP9BX1mpXsZCBZ9F8Uq429Emp0GZBvxk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=YU0t6OjFrvjgkDDvOuuKnQWnjekr+xxSg16q9vPrkImGDCbn83dqyPNqFv3qxxNR5 PqGdB4hyPeN8vKZM9TMClVa9zrVFeVMdStgn/w6FsWiFsYEtwvas/FpLblwu6NjmJV deO7Kzzs4mspJZo+TFxUHMy9EmBcQYPpTBv3ixAq15LH2YKdp3KlQMOSf9t7QofZtK a8c1VfGYV5BYm03eznfItWSdAbeampwj6gSVV6gDC9C4eQ+Z2je8dhxtp/q9VE9F9a UNxy4wOW4nK4zjryOzmqYBDmc99ysNZI4gRC90BtHx9DP8Fo/Fblf4P7wX3xv3c1PA 05TY6YhW2AAUQ== From: Andreas Hindborg Date: Mon, 16 Nov 2026 15:21:00 +0100 Subject: [PATCH v22 3/5] rust: implement `ForeignOwnable` for `Owned` X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261116-unique-ref-v22-3-12029383206d@kernel.org> References: <20261116-unique-ref-v22-0-12029383206d@kernel.org> In-Reply-To: <20261116-unique-ref-v22-0-12029383206d@kernel.org> To: Danilo Krummrich , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Lyude Paul , Greg Kroah-Hartman , Christian Brauner , "Rafael J. Wysocki" , Dave Ertman , Leon Romanovsky , Paul Moore , Serge Hallyn , David Airlie , Simona Vetter , Alexander Viro , Jan Kara , Igor Korotin , Viresh Kumar , Nishanth Menon , Stephen Boyd , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Pavel Tikhomirov , Michal Wilczynski , Ira Weiny , Matthew Brost , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Johan Hovold , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Dave Jiang , Jason Gunthorpe , Saeed Mahameed , Zhi Wang , Jonathan Cameron , Markus Probst , Ira Weiny Cc: Andreas Hindborg , Philipp Stanner , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, driver-core@lists.linux.dev, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-serial@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3413; i=a.hindborg@kernel.org; h=from:subject:message-id; bh=yxSwAMf1WCPKfeJBxmCTAk/DQrKQubqT1B9hug50/gI=; b=owEBbQKS/ZANAwAKAfpQKQiqxb3QAcsmYgBq+xFS+9cTttA9+oADXGC7GEWmmDosjg6s4Ao7a qKVHkrzi2yJAjMEAAEKAB0WIQRXitnI2WZ2JirAaob6UCkIqsW90AUCavsRUgAKCRD6UCkIqsW9 0O3jD/49Splh6UzX1b0EokN7/Bp9lpjcX/DWmN5abF8blBytH3yV6+s4lAYrTuN4IbwrH6lGWP+ G0TE5WjwSJMFPIGikWQ+VuqTHmrYBgy34ckfY3sgSCgpLZe1Ulq4aeRUqc6LPTBcW/PcxZzctJc SMWpuB9vMTCEX7wCDBCFIGA0I7XZKRZ+sT2eSleHRevwnmQ5qG/k7uG6qot2gWi5xWFi67AH29M 39V8/VIFeNaKaGWj5FcEUAYL0i/c3GHNiDONnKhPkzRsBspNENw1A1ljRP1a/aP6vCE1yaIOxWF u/eWmPlBAvD1DN3JxG2QHn89Lb3tvpETyGuXRfp/vExtaQhPcK6hhjI8glNSy+taBQUhUciaZ7o HbMhLvYLOZ+DI187LcoitByoRm7L5ZpQZxwB6mmIvcrL2kBLNVD3WueR9xrMAGTmBItRXInawml lVoE/5RXApo+8R3y903FvVcx1P79l9P/KRf+DEmo/S1yyd84RPEvWjD6rBnZDZ2atX8zB/AhAw4 Lv4hSHlmrR//tO9SiqOnLgWhiw0S8YrY502KaW0j7zpyoGvQzn6cJq1dsO7xsw1KockvDh597lr xBMInACeni6dtSLhueSr4IqgRIC9vD9lUhfcvQNA0/JX3iA2+U0UpmEc3526Y2BUhOsLgth0g+Y FZT/S29GIWWp2GQ== X-Developer-Key: i=a.hindborg@kernel.org; a=openpgp; fpr=3108C10F46872E248D1FB221376EB100563EF7A7 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A568A4000A X-Stat-Signature: m5fhxao8oezyajk5yzd9tw9z8bs4a9wp X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-HE-Tag: 1794838896-685132 X-HE-Meta: U2FsdGVkX19kPilXrkn6iDXBJKBBM9s8tyVAHX592/92NsOQxgNnh5b4PagK3x46C+nXTqbD7r7XGBAXIKHAMgb+XyhvBcq8AsHpWUP840a9UUfVwsNXFoaGYgXDkYYDAJXLxoO/D7/Ykheyn+R7+bOY2DzxgGCZCmVl77n4VMdmsWawPvrOfBXNtSQ7pTtfMkNKFZG0lvVyoAEoLKLt7bGEmEKgZMf8uwon5NyCFDyaKCNf6O9tefeInjyq7cmajuH/vdFGEaqGhaTyprQVXLVP/L62RVkNEEiWYvEm/C6xPqIK5v2RB3La8k0AEWAX9uh3UqOe4yp7fsliKAZ9F+vi42nc+Dq1yXuxorpjopxBDPEoxJA1NqJd8QQYisIUwXGrujYWUhrIJJHShlETATK64STKCwgkb6SVQQEYPgmvdi7hkZhHgFiaorBlcQeRsZ7kRnyApZX5ehWAuHF5AVrHWIzsSqITudF4LOLdN9GYsZrdAYGCX/+Dlhv0X5xRkLqgVYFCp9FPGK5vSwEcA1k60NcMMPCOormbRv00bhsNy/wMohUy0bKbSHFUNGqvoR7+iCVSOhshpiAkbf1gNiJiQxeRYzasNRKOLdJd1Oftz7sYcPLTEvT2V3azkC/cvyXF5JoheK3aPCgOCMbjUl47/isbsRFCu+FWTzSBsQtrZfm0TUsa2pI6AKkTLd4cfkofIe4ifBI6XRoyDfntU4g0XagXXtSY6cyRdLGiu+yxPpMDey0jcCnLRnzsLMz8INahCabyCX/sEQXfmK4cFsvz7KGOrfw0XAumAAT09u2ampEYoXZJ0+iVCXeSCVot/sQWN3q+xCfsP/yUUZxvIlgJ8PWeT/8PgqK7T3yBSdUYIkCeq2sfbvCNqBcPhcc1X038CnTtIUVRLYjS1ktOedxzQQ/+c8+guCsMCOB3ghiinYlQuehon9PpmbNGeiagFer9NI5MQ06XFIqs/If nS2HKF+m LLXOepOXWYzQFxSCGQX5oam8BETvBF+lwJZ+sywE2RwJOh7D32fBP8V8iaJAJpfww7QZO0XbkAqgwXPYuN2Ex64RBct42WtVkFOOATIayiWXWwfgmGvrSTe0MH+zst6SSQ3zh4LWKBz7xUcFZM/dGpf/z2tFape6NKeKpjVI4yNv55F4+eTRS76yCgtjw7OmDwkWNEZjNo09+1fgzRk2i1qiFjlbTcd7giMUPZLFH4Po+mRd4Z7p+y7FLt4ghHwQaL1FEzjMEFti2R3ZUxFOqiSJdwstEBFmuEkghB1/kOGmCKTFYgaFznydlG0RChsC6FIjd Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Implement `ForeignOwnable` for `Owned`. This allows use of `Owned` in places such as the `XArray`. Note that `T` does not need to implement `ForeignOwnable` for `Owned` to implement `ForeignOwnable`. Signed-off-by: Andreas Hindborg --- rust/kernel/owned.rs | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/rust/kernel/owned.rs b/rust/kernel/owned.rs index 51da9bc7e1f4..c255420f8383 100644 --- a/rust/kernel/owned.rs +++ b/rust/kernel/owned.rs @@ -15,6 +15,8 @@ ptr::NonNull, // }; +use kernel::types::ForeignOwnable; + /// Types that specify their own way of performing allocation and destruction. Typically, this trait /// is implemented on types from the C side. /// @@ -272,3 +274,58 @@ fn drop(&mut self) { unsafe { T::release(self.ptr) }; } } + +// SAFETY: We derive the pointer to `T` from a valid `T`, so the returned +// pointer satisfy alignment requirements of `T`. +unsafe impl ForeignOwnable for Owned { + const FOREIGN_ALIGN: usize = core::mem::align_of::(); + + type Borrowed<'a> + = &'a T + where + Self: 'a; + type BorrowedMut<'a> + = Pin<&'a mut T> + where + Self: 'a; + + #[inline] + fn into_foreign(self) -> *mut kernel::ffi::c_void { + Owned::into_raw(self).as_ptr().cast() + } + + #[inline] + unsafe fn from_foreign(ptr: *mut kernel::ffi::c_void) -> Self { + // SAFETY: By function safety contract, `ptr` came from `into_foreign` and cannot be null. + let ptr = unsafe { NonNull::new_unchecked(ptr.cast()) }; + + // SAFETY: By the function safety contract, `ptr` was returned by `into_foreign`, which + // consumed an `Owned` without calling `T::release`. The requirements that were upheld + // for that `Owned` are still upheld, as the ownership it represented was only held by + // the foreign pointer in the meantime. We retake that ownership here. + unsafe { Owned::from_raw(ptr) } + } + + #[inline] + unsafe fn borrow<'a>(ptr: *mut kernel::ffi::c_void) -> Self::Borrowed<'a> { + // SAFETY: By function safety requirements, `ptr` came from `into_foreign` and the + // `Owned` it was created from is not reconstructed or mutably borrowed during `'a`. By + // the type invariants of that `Owned`, `ptr` points to a valid `T` and it is sound to + // create a shared reference to the `T` for `'a`. + unsafe { &*ptr.cast() } + } + + #[inline] + unsafe fn borrow_mut<'a>(ptr: *mut kernel::ffi::c_void) -> Self::BorrowedMut<'a> { + // SAFETY: By function safety requirements, `ptr` came from `into_foreign` and the + // `Owned` it was created from is not reconstructed or otherwise borrowed during `'a`. By + // the type invariants of that `Owned`, `ptr` points to a valid `T` and it is sound to + // create a mutable reference to the `T` for `'a`, given that we only hand it out as a + // `Pin<&mut T>` below. + let inner = unsafe { &mut *ptr.cast() }; + + // SAFETY: We never move out of inner, and we do not hand out mutable + // references when `T: !Unpin`. + unsafe { Pin::new_unchecked(inner) } + } +} -- 2.54.0