Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: muchun.song@linux.dev
Cc: sashiko-reviews@lists.linux.dev, songmuchun@bytedance.com,
	akpm@linux-foundation.org, david@kernel.org, osalvador@suse.de,
	rppt@kernel.org, lizhe.67@bytedance.com, apopple@nvidia.com,
	balbirs@nvidia.com, ljs@kernel.org, liam@infradead.org,
	vbabka@kernel.org, surenb@google.com, mhocko@suse.com,
	jthoughton@google.com, lance.yang@linux.dev, qi.zheng@linux.dev,
	linux-mm@kvack.org
Subject: Re: [PATCH v2 02/14] mm/hugetlb: optimize bootmem hugepage tail vmemmap init
Date: Mon, 16 Nov 2026 15:55:40 +0800	[thread overview]
Message-ID: <20261116075540.51374-1-lance.yang@linux.dev> (raw)
In-Reply-To: <D1F34237-066F-43E8-89F5-2D7A6217D72B@linux.dev>


On Fri, Nov 13, 2026 at 12:10:13PM +0800, Muchun Song wrote:
>
>
>> On Nov 13, 2026, at 12:07, sashiko-bot@kernel.org wrote:
>> 
>> Thank you for your contribution! Sashiko AI review found 1 potential
>> issue to consider:
>> - [Low] mm/hugetlb: commit message mismatches
>>  memmap_init_page_from_template()
>> --
>> 
>> commit 7cc97c08b2296fc2518d9ae6da5950cb731c48eb
>> Author: Li Zhe <lizhe.67@bytedance.com>
>> 
>> mm/hugetlb: optimize bootmem hugepage tail vmemmap init
>> 
>> This commit speeds up boot-time HugeTLB tail page vmemmap initialization
>> by seeding a template from the first tail page and initializing the
>> remaining tail pages with memmap_init_page_from_template().
>> 
>>> Initialize the first tail page normally, then initialize the remaining
>>> tails with hugetlb_init_tail_page().  This copies the already
>>> initialized first tail page with memcpy() and refreshes only the
>>> PFN-dependent fields in the destination page, while avoiding the full
>>> __init_single_page() and prep_compound_tail() sequence for state that is
>>> identical across tail pages in the same huge page.
>> 
>> [Severity: Low]
>> This isn't a bug, but the commit message appears to describe an earlier
>> version of the patch.  hugetlb_folio_init_tail_vmemmap() copies the first
>> tail page into a stack template and calls memmap_init_page_from_template()
>> (which refreshes the template before copying) rather than a
>> hugetlb_init_tail_page() helper.  The commit message also omits the change
>> in memmap_init_page_from_template() that restricts memcpy_nontemporal() to
>> ZONE_DEVICE pages and uses memcpy() for other zones.
>
>My bad. I forgot to update the commit message, the corrected commit message
>is as follows:
>
>Boot-time HugeTLB allocation has to initialize tail struct pages itself
>when HugeTLB vmemmap optimization (HVO) is unavailable or fails.  For
>gigantic pages, this can cover a large number of tail pages.  Most state
>installed by __init_single_page() and prep_compound_tail() is identical
>for every tail page in the same huge page, so repeating the full
>initialization sequence for each tail page is unnecessary.
>
>Initialize the first tail page normally and use it as a template for the
>remaining tail pages.  Before each copy,
>memmap_init_page_from_template() refreshes the PFN-dependent fields in
>the template, avoiding repeated initialization of state shared by all
>tail pages.
>
>This extends memmap_init_page_from_template() from ZONE_DEVICE to normal
>memory.  Keep memcpy_nontemporal() for ZONE_DEVICE pages and use
>memcpy() for pages in other zones.  memcpy_nontemporal() was also tested
>for the HugeTLB path, but did not provide a similar benefit; on x86-64,
>memcpy() performed better for this workload.
>
>The fallback path was measured on a v7.4-rc2 base with a temporary
>jiffies-based printk modeled after the existing timing in
>memmap_init_zone_device(), using 4K base pages and 64 boot-time 1G
>hugepages.  HVO is unavailable on arm64; on x86-64,
>hugetlb_free_vmemmap=off was used to exercise the fallback path.
>
>  arch    base      with this patch  reduction
>  arm64   360.8 ms  256.0 ms         29.05%
>  x86-64  171.0 ms  165.0 ms          3.51%
>

with the updated commit message, LGTM!

Reviewed-by: Lance Yang <lance.yang@linux.dev>


  reply	other threads:[~2026-11-16  7:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:34 [PATCH v2 00/14] mm: Unify memmap initialization for compound pages Muchun Song
2026-11-13  3:34 ` [PATCH v2 01/14] mm/mm_init: factor out memmap_init_page_from_template() Muchun Song
2026-11-16  4:40   ` Lance Yang
2026-11-13  3:34 ` [PATCH v2 02/14] mm/hugetlb: optimize bootmem hugepage tail vmemmap init Muchun Song
2026-11-13  4:07   ` sashiko-bot
2026-11-13  4:10     ` Muchun Song
2026-11-16  7:55       ` Lance Yang [this message]
2026-11-13  3:34 ` [PATCH v2 03/14] mm/mm_init: verify zones for template-initialized pages Muchun Song
2026-11-16  8:41   ` Lance Yang
2026-11-13  3:34 ` [PATCH v2 04/14] mm/mm_init: factor out common struct page initialization Muchun Song
2026-11-13  3:34 ` [PATCH v2 05/14] mm/mm_init: simplify zone device " Muchun Song
2026-11-13  3:34 ` [PATCH v2 06/14] mm/mm_init: factor out frozen compound " Muchun Song
2026-11-13  3:34 ` [PATCH v2 07/14] mm/hugetlb: drop boot-time HVO handling for gigantic folios Muchun Song
2026-11-13  3:34 ` [PATCH v2 08/14] mm/hugetlb: initialize all struct pages for bootmem hugepages Muchun Song
2026-11-13  3:34 ` [PATCH v2 09/14] mm/hugetlb: use common compound page initialization helper Muchun Song
2026-11-13  3:34 ` [PATCH v2 10/14] mm/mm_init: make __init_single_page() static Muchun Song
2026-11-13  3:34 ` [PATCH v2 11/14] mm/mm_init: make memmap_init_page_from_template() static Muchun Song
2026-11-13  3:34 ` [PATCH v2 12/14] mm/cma: centralize CMA pageblock initialization Muchun Song
2026-11-13  4:07   ` sashiko-bot
2026-11-13  5:47     ` Muchun Song
2026-11-13  3:34 ` [PATCH v2 13/14] mm/cma: localize init_cma_pageblock() to cma.c Muchun Song
2026-11-13  3:34 ` [PATCH v2 14/14] mm/mm_init: move pageblock migratetype init to memmap helpers Muchun Song
2026-11-16  4:20 ` [PATCH v2 00/14] mm: Unify memmap initialization for compound pages Lance Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116075540.51374-1-lance.yang@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=balbirs@nvidia.com \
    --cc=david@kernel.org \
    --cc=jthoughton@google.com \
    --cc=liam@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=lizhe.67@bytedance.com \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=qi.zheng@linux.dev \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=songmuchun@bytedance.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox