Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Mattathias Pinchover via B4 Relay
	<devnull+mattathias.pinchover.uber.com@kernel.org>
Cc: SJ Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	damon@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	Mattathias Pinchover <mattathias.pinchover@uber.com>
Subject: Re: [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last
Date: Mon, 16 Nov 2026 18:22:42 -0800	[thread overview]
Message-ID: <20261117022242.110258-1-sj@kernel.org> (raw)
In-Reply-To: <20261116-damon-sz-ops-b4-v1-3-1cffe7227e6d@uber.com>

On Mon, 16 Nov 2026 19:10:06 +0000 Mattathias Pinchover via B4 Relay <devnull+mattathias.pinchover.uber.com@kernel.org> wrote:

> From: Mattathias Pinchover <mattathias.pinchover@uber.com>
> 
> Add a kunit test for the sz_ops_filter_passed_last DAMOS
> stat.  The test runs kdamond_apply_schemes() for multiple apply intervals
> with a stub apply_scheme() operation that reports a given ops
> filter-passed size, and checks that the stat is set to the value of the
> last apply interval rather than the accumulated value, and that it is
> kept unchanged until the next apply interval is completed.
> 
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
> ---
>  mm/damon/tests/core-kunit.h | 92 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 92 insertions(+)
> 
> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index a5ca4bfe2f0d..ec83598fff0e 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
[...]
> +	s = damon_new_scheme(&pattern, DAMOS_STAT, 0, &quota, &wmarks,
> +			NUMA_NO_NODE);
> +	if (!s) {
> +		damon_destroy_ctx(c);
> +		kunit_skip(test, "scheme alloc fail");
> +	}
> +	damon_add_scheme(c, s);

Sashiko concerns [1] the fact s->core_filters_default_reject is unset.  How
about calling damos_set_filters_default_reject() just before
damon_add_scheme()?

[1] https://lore.kernel.org/sashiko-outbox-217563@kernel.org


Thanks,
SJ

[...]


  parent reply	other threads:[~2026-11-17  2:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
2026-11-17  2:03   ` SJ Park
2026-11-16 19:10 ` [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
2026-11-17  2:10   ` SJ Park
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-16 19:30   ` sashiko-bot
2026-11-17  2:22   ` SJ Park [this message]
2026-11-16 19:10 ` [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-17  2:25   ` SJ Park
2026-11-16 19:10 ` [PATCH 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
2026-11-17  2:29   ` SJ Park
2026-11-16 19:10 ` [PATCH 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
2026-11-17  2:31   ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117022242.110258-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=damon@lists.linux.dev \
    --cc=devnull+mattathias.pinchover.uber.com@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mattathias.pinchover@uber.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox