From: SJ Park <sj@kernel.org>
To: Mattathias Pinchover via B4 Relay
<devnull+mattathias.pinchover.uber.com@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Mattathias Pinchover <mattathias.pinchover@uber.com>
Subject: Re: [PATCH v2 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat
Date: Tue, 17 Nov 2026 18:07:08 -0800 [thread overview]
Message-ID: <20261118020709.97589-1-sj@kernel.org> (raw)
In-Reply-To: <20261117-damon-sz-ops-b4-v2-0-439888fa04ac@uber.com>
On Tue, 17 Nov 2026 23:22:14 +0000 Mattathias Pinchover via B4 Relay <devnull+mattathias.pinchover.uber.com@kernel.org> wrote:
> DAMOS stat sz_ops_filter_passed shows the total bytes that passed
> operations layer-handled DAMOS filters, accumulated from the beginning
> of the scheme's execution. Users who want the amount for only the
> latest apply interval, e.g., the size of a workload's anonymous memory
> that is cold as of now, have to keep the previous value in user space
> and compute the difference. To know how many apply intervals a
> difference covers, they have to rely on nr_snapshots. But nr_snapshots
> is increased once per target per apply interval, so the computation is
> complicated for contexts having multiple targets.
>
> This series introduces a new DAMOS stat, sz_ops_filter_passed_last. It
> shows the amount of sz_ops_filter_passed increase in the last apply
> interval of the scheme. It is updated at the end of each apply
> interval, and kept unchanged until the next apply interval is
> completed. Like the other DAMOS stats, it is exposed under the stats/
> directory of the scheme in the DAMON sysfs interface, and refreshed
> together with the other stats when refresh_ms expires or
> update_schemes_stats is written.
[...]
> Changes in v2:
> - Patch 2: join the attribute declaration onto one line
> - Patch 3: call damos_set_filters_default_reject() before adding the
> scheme
> - Patch 4: keep only the stats list bullet, dropping the explanation
> that the stat is not accumulated
> - Patch 5: wrap the stats line in the usage document
> - Link to v1: https://patch.msgid.link/20261116-damon-sz-ops-b4-v1-0-1cffe7227e6d@uber.com
Thank you for addressing all comments I added to v1. However, you didn't
directly reply to the comments on the v1 thread. That might confuse some
future readers. From the next time, please make sure the previous version
thread is complete by replying to all comments and waiting sufficient time to
let any other chime in if they have opinions.
All patches in this version look good to me.
This series is applied to damon/next [1] tree. I will repost it soon (~1 week)
as an mm.git merge request. So, no action from your side is needed for now.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-11-18 2:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 23:22 [PATCH v2 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
2026-11-17 23:22 ` [PATCH v2 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
2026-11-18 1:51 ` SJ Park
2026-11-17 23:22 ` [PATCH v2 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
2026-11-18 1:53 ` SJ Park
2026-11-17 23:22 ` [PATCH v2 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-18 1:59 ` SJ Park
2026-11-17 23:22 ` [PATCH v2 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-18 2:00 ` SJ Park
2026-11-17 23:22 ` [PATCH v2 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
2026-11-18 2:01 ` SJ Park
2026-11-17 23:22 ` [PATCH v2 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
2026-11-18 2:02 ` SJ Park
2026-11-18 2:07 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118020709.97589-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=devnull+mattathias.pinchover.uber.com@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mattathias.pinchover@uber.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox