From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81E33606D370 for ; Wed, 18 Nov 2026 19:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KALLz5Qa Received: by kanga.kvack.org (Postfix) id 9534C6B05B9; Wed, 18 Nov 2026 14:35:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92A6C6B05BA; Wed, 18 Nov 2026 14:35:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 819706B05BB; Wed, 18 Nov 2026 14:35:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5FFEE6B05B9 for ; Wed, 18 Nov 2026 14:35:56 -0500 (EST) Received: from smtpin05.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BA08EA0887 for ; Wed, 18 Nov 2026 19:35:55 +0000 (UTC) X-FDA: 85449245070.05.8B1FC96 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id 1636F1C0007 for ; Wed, 18 Nov 2026 19:35:53 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=KALLz5Qa; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of jarkko@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1795030554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=glmqSz2x+APivEM/vonQfanbbokAEU7WMuncz0VaekQ=; b=8L7b4Y1hOSAWn+/Xb3LG2jlclBgh+0BW3iySs2Tp8pgtMRXjlPKMOSa8cGkaxvVHydn96Z s+z1clzST3DGRU2r9wD2iq/XS0c/3UQVkSTahCQdPoXwktuyeXhI4yunVS6VprGBW8LXQY Wlv9xlHdKHCKNrMhkmk+9N1Hin+AbKs= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1795030554; b=YTkmzMqOfs5EHcY3cHLgAVHA7Dqi7XVpMrf9I6DTGHCTIqwaF3pmbUp1M5HZez5T/efW/Z rAtJA6nNwmlVhnCUdRTcSh5rb6BkPpK8H/kWAkrdGyLSwYh3/dNzBk+2FZy+t9nBmv9Jt9 kmp+L4LIPfrorSy4uiyVm6XGS6hGqj8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=KALLz5Qa; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of jarkko@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=jarkko@kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with UTF8SMTP id 299B344B8A; Wed, 18 Nov 2026 19:35:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 4E14C1F000C5; Wed, 18 Nov 2026 19:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795030553; bh=glmqSz2x+APivEM/vonQfanbbokAEU7WMuncz0VaekQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KALLz5Qa0xo3dgf99GmRRZI3kaXuy8ffj4AmAdcU6IUpWIq9o3rJJAOa3KO1QLHf6 NpCGxHjvUkHYpFYFOwe7r8EmoMvyoii7KdbfVvpsdRmdJCN7gzqbdLyJetSXjpazad rV7VL2mi62IgF4UfZFFyUyqRJX62aHEsor7d1ysyF+ZUljeYc4TNbgwW23x6IkUt81 WII7huMAnZanX3DAoBqQG3DHHvM6NewgJzyGKOjWYXPalKsXW6Bcc4PjXsc2KmwpH3 XT/ZbYek13JAfQwElU+R7POwev1fR0Dwuh5tNvHt59bpG3JgQLr/tuwHDp1VGxel3g hG51CZ1+fgxjA== From: Jarkko Sakkinen To: David Howells Cc: Jarkko Sakkinen , linux-api@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, Alexander Viro , Andrew Morton , Andy Lutomirski , Anna-Maria Behnsen , Ben Segall , Christian Brauner , David Hildenbrand , Davidlohr Bueso , Dietmar Eggemann , Frederic Weisbecker , Ingo Molnar , Jan Kara , John Johansen , Jonathan Corbet , Juri Lelli , Kees Cook , K Prateek Nayak , "Liam R. Howlett" , Lorenzo Stoakes , Manfred Spraul , Mel Gorman , Michal Hocko , Mike Rapoport , Neal Gompa , Paul Moore , Pavel Tikhomirov , Peter Zijlstra , Randy Dunlap , Serge Hallyn , Shuah Khan , Steven Rostedt , Suren Baghdasaryan , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Vincenzo Frascino , Vlastimil Babka , Zygmunt Krynicki Subject: [RFC PATCH v3 01/13] nsproxy: Pass nsproxy to create_new_namespaces() Date: Wed, 18 Nov 2026 21:35:27 +0200 Message-ID: <20261118193539.240065-2-jarkko@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118193539.240065-1-jarkko@kernel.org> References: <20261118193539.240065-1-jarkko@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1636F1C0007 X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Stat-Signature: n6sb3xq7utgunwtbwyfmhihby95bmmdm X-Rspam-User: X-HE-Tag: 1795030553-883711 X-HE-Meta: U2FsdGVkX18cdaBssQHkZeHFnS6wUrgKTPOGvUJBDQ24f/BpZmIaK08Hue58Sqb16dyyLrqw/xbr6qQdl6s4rGJQJ6DVv0GlTbjZYGkV6SVirnYkmhuWRftTjkgK0TlSkL1BMrgLaObx5HG3immdlywjpr1LdMi8dTH+6bSlu6yJapPEWapmO/iIGxPxruYKnZuwcE7gmQi4KaQySkM6sLwAqaGd7vFKpbkhV97TYoBF9tkOi7Y1qVDFbTTUl1OZ8WXXCkpOhTaT5kmKS9Ab0M4zSWXjotyrmh2Mq+JWp9jOVPlzuCme+lmZH7Mwbmt+B+SOz6ruJfdUFTdcrsQ+faqIaQW/xOVBnuLVa9uwjBqedFM6KejvIH8QZpXmaNiTNp8dNk9I+NKnbrVaxnBI2G1VHmwNrbVjo/1pDc3xvc2hRf3PD0hRHUrRK/6x/ye94V8aAFSq6wfKiIf51PC0cPHii2ZCAvmYSVFCG5bTk+MMCorCPR+jfAZNefXCJSs0tPhpf7mT+L8guMSCHb7WECqY+rB+C9fxVp74M7gTEntQfH7HzWSq9kYA4RsRpR6SR6jWH1BhP6AnH8ejlzHz+hklRlBccYlFVlQG1k3PfLTEb1JNCv29ZyLc08EA55oMIgzO6C2j3WxqD22FUFf0is/J8LgYs08srcM6/RN92YRB982PXub7sgSnhE8Q4R4VQ0UfZ+gWdCGtALxd+8RP4eWsBPHbUxWpkJ0ISaL/6fMqBlk3crapHhtGlnH2XuDhjhFwNbW+949EElSSkdDc/Yq0iIHKjmqfvoMbnjTbYksh1fS2v7m+m95UT7arF6rYr6AV272kCi1Jds+hNSpRjTie81h6OzwgZ8lfwxtnE1UKQt7mvPfxyONPBOESTM72OQxW3f4jMst0tM9lxZYDpF4VeaqTP8ATIKj9gfpw9XVhZluL9McB3cdQgKFk2ksKeZNsg6G67PARlWJurfS V3CCj0wM +8/2jQybqp69s2Tq+Z9+VDoB4timlJAlgeWhguUfnSTA63ZpQL3kFrvq4BAX1an8zwvRef+bLqHRRIz5pVzA3ewaPWW5gPEJc4xA9TehL5Cf1I3l/jx1du17V+TtsF6q0qQW57Zxh6GhmggLgyBPad8f9JNlfiSi/zP5LUipFi+dS20q8zG1PrL77ybjmpCXgzAA3Zg2mXqHS335QUpX9jO0UXI/ogmbU7HQn6oUEc5/Jvao3yCm8kW8sq2IrfFKjVvt3GcfKMoFIN/Hv6wpm39HZ1xrIM+E6zw8cmuoA6E8MviyBpe3NLPERRKJJEC3beLUSW/EbZNmKWKxEnbXTa9T57QHWYAXBTDHJ Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 create_new_namespaces() takes a struct task_struct pointer even though it only reads tsk->nsproxy, preventing callers outside kernel/nsproxy.c from constructing a child nsproxy without mutating a task. Expose create_new_namespaces() and pass the source struct nsproxy pointer directly so root namespace creation can allocate a detached namespace set from current->nsproxy. Co-developed-by: David Howells Signed-off-by: David Howells Signed-off-by: Jarkko Sakkinen --- include/linux/nsproxy.h | 5 +++++ kernel/nsproxy.c | 32 ++++++++++++++++---------------- 2 files changed, 21 insertions(+), 16 deletions(-) diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h index dc2447f5f092..cacbbbe3f1ce 100644 --- a/include/linux/nsproxy.h +++ b/include/linux/nsproxy.h @@ -12,6 +12,7 @@ struct ipc_namespace; struct pid_namespace; struct cgroup_namespace; struct fs_struct; +struct user_namespace; /* * A structure to contain pointers to all per-process @@ -92,6 +93,10 @@ static inline struct cred *nsset_cred(struct nsset *set) * */ +struct nsproxy *create_new_namespaces(u64 flags, + struct nsproxy *ns, + struct user_namespace *user_ns, + struct fs_struct *new_fs); int copy_namespaces(u64 flags, struct task_struct *tsk); void switch_cred_namespaces(const struct cred *old, const struct cred *new); void exit_nsproxy_namespaces(struct task_struct *tsk); diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c index 2dcf105e8ee2..8a3c6d4e94e2 100644 --- a/kernel/nsproxy.c +++ b/kernel/nsproxy.c @@ -85,9 +85,10 @@ void deactivate_nsproxy(struct nsproxy *ns) * Return the newly created nsproxy. Do not attach this to the task, * leave it to the caller to do proper locking and attach it to task. */ -static struct nsproxy *create_new_namespaces(u64 flags, - struct task_struct *tsk, struct user_namespace *user_ns, - struct fs_struct *new_fs) +struct nsproxy *create_new_namespaces(u64 flags, + struct nsproxy *ns, + struct user_namespace *user_ns, + struct fs_struct *new_fs) { struct nsproxy *new_nsp; int err; @@ -96,52 +97,51 @@ static struct nsproxy *create_new_namespaces(u64 flags, if (!new_nsp) return ERR_PTR(-ENOMEM); - new_nsp->mnt_ns = copy_mnt_ns(flags, tsk->nsproxy->mnt_ns, - user_ns, new_fs); + new_nsp->mnt_ns = copy_mnt_ns(flags, ns->mnt_ns, user_ns, new_fs); if (IS_ERR(new_nsp->mnt_ns)) { err = PTR_ERR(new_nsp->mnt_ns); goto out_ns; } - new_nsp->uts_ns = copy_utsname(flags, user_ns, tsk->nsproxy->uts_ns); + new_nsp->uts_ns = copy_utsname(flags, user_ns, ns->uts_ns); if (IS_ERR(new_nsp->uts_ns)) { err = PTR_ERR(new_nsp->uts_ns); goto out_uts; } - new_nsp->ipc_ns = copy_ipcs(flags, user_ns, tsk->nsproxy->ipc_ns); + new_nsp->ipc_ns = copy_ipcs(flags, user_ns, ns->ipc_ns); if (IS_ERR(new_nsp->ipc_ns)) { err = PTR_ERR(new_nsp->ipc_ns); goto out_ipc; } new_nsp->pid_ns_for_children = - copy_pid_ns(flags, user_ns, tsk->nsproxy->pid_ns_for_children); + copy_pid_ns(flags, user_ns, ns->pid_ns_for_children); if (IS_ERR(new_nsp->pid_ns_for_children)) { err = PTR_ERR(new_nsp->pid_ns_for_children); goto out_pid; } new_nsp->cgroup_ns = copy_cgroup_ns(flags, user_ns, - tsk->nsproxy->cgroup_ns); + ns->cgroup_ns); if (IS_ERR(new_nsp->cgroup_ns)) { err = PTR_ERR(new_nsp->cgroup_ns); goto out_cgroup; } - new_nsp->net_ns = copy_net_ns(flags, user_ns, tsk->nsproxy->net_ns); + new_nsp->net_ns = copy_net_ns(flags, user_ns, ns->net_ns); if (IS_ERR(new_nsp->net_ns)) { err = PTR_ERR(new_nsp->net_ns); goto out_net; } new_nsp->time_ns_for_children = copy_time_ns(flags, user_ns, - tsk->nsproxy->time_ns_for_children); + ns->time_ns_for_children); if (IS_ERR(new_nsp->time_ns_for_children)) { err = PTR_ERR(new_nsp->time_ns_for_children); goto out_time; } - new_nsp->time_ns = get_time_ns(tsk->nsproxy->time_ns); + new_nsp->time_ns = get_time_ns(ns->time_ns); return new_nsp; @@ -192,7 +192,7 @@ int copy_namespaces(u64 flags, struct task_struct *tsk) (CLONE_NEWIPC | CLONE_SYSVSEM)) return -EINVAL; - new_ns = create_new_namespaces(flags, tsk, user_ns, tsk->fs); + new_ns = create_new_namespaces(flags, tsk->nsproxy, user_ns, tsk->fs); if (IS_ERR(new_ns)) return PTR_ERR(new_ns); @@ -231,7 +231,7 @@ int unshare_nsproxy_namespaces(unsigned long unshare_flags, flags |= CLONE_EMPTY_MNTNS; } - *new_nsp = create_new_namespaces(flags, current, user_ns, + *new_nsp = create_new_namespaces(flags, current->nsproxy, user_ns, new_fs ? new_fs : current->fs); if (IS_ERR(*new_nsp)) { err = PTR_ERR(*new_nsp); @@ -289,7 +289,7 @@ int exec_task_namespaces(void) if (tsk->nsproxy->time_ns_for_children == tsk->nsproxy->time_ns) return 0; - new = create_new_namespaces(0, tsk, current_user_ns(), tsk->fs); + new = create_new_namespaces(0, tsk->nsproxy, current_user_ns(), tsk->fs); if (IS_ERR(new)) return PTR_ERR(new); @@ -356,7 +356,7 @@ static int prepare_nsset(unsigned flags, struct nsset *nsset) struct task_struct *me = current; nsset->flags = flags; - nsset->nsproxy = create_new_namespaces(0, me, current_user_ns(), me->fs); + nsset->nsproxy = create_new_namespaces(0, me->nsproxy, current_user_ns(), me->fs); if (IS_ERR(nsset->nsproxy)) return PTR_ERR(nsset->nsproxy); -- 2.47.3