From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64661606BA9D for ; Sat, 21 Nov 2026 00:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=QHmCpSNi Received: by kanga.kvack.org (Postfix) id 262796B05CF; Fri, 20 Nov 2026 19:10:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 213346B05D1; Fri, 20 Nov 2026 19:10:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B3296B05D2; Fri, 20 Nov 2026 19:10:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D16546B05CF for ; Fri, 20 Nov 2026 19:10:24 -0500 (EST) Received: from smtpin02.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 568BFA026E for ; Sat, 21 Nov 2026 00:10:24 +0000 (UTC) X-FDA: 85457194368.02.9882A37 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf31.hostedemail.com (Postfix) with ESMTP id B4D5020003 for ; Sat, 21 Nov 2026 00:10:22 +0000 (UTC) Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=QHmCpSNi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of jarkko@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1795219822; b=QnVavCkiq3+bb1JTw3E12fzxrOFDabSnWix2pFVRbWfCbJBYSZkHxCfCdMddDmsSWaE5Cn syjUfmXi6k2BoLFa8uTfLisFv/055ZMzcxpeVNYA5Ea83j6xodqqVxf6f+b5kvpG7gINSW YMJA6u6W1t1CB26HwbF7QziYR8yuSbo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1795219822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fv+4rTw2hN1zfy9KsnwOHnSYpn2531DaMXgpubCM6BE=; b=8FF2IR9TIyuNELKM3LG49Ym3ORVEnUFM4s9D9ro7Sxec3BbPEVszzXhEP85Qufco5nAuUS Ap/IDSyi6WszowwhdA5f4y32pcj6O+Oe2HPAxSBuHntlTelmj2gaKDThQeNTSNeVqat4lT KqTqpW8S42ho0Vl3F+dbjOTqZXfYorc= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=QHmCpSNi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf31.hostedemail.com: domain of jarkko@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jarkko@kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with UTF8SMTP id 3F1DC623A3; Sat, 21 Nov 2026 00:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 361621F000D2; Sat, 21 Nov 2026 00:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795219821; bh=Fv+4rTw2hN1zfy9KsnwOHnSYpn2531DaMXgpubCM6BE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QHmCpSNi5+s2VCw6nAr8zwsBFvo9+GDOMY92DDhxqDWH5XcKurQ4h/9XEoBkpchwm 6pqeAPxWEQ1PiiBDWOB87AMs/upAJkB1UyE6R0M69FIljrbSqk5z4ym0MN2jBD+mtn BZ9TvgU+2VamFdf1innh8LeyXEcvCmy3zHuV46epEa8yuDBbQS0yYgb7Zx4uBDxEz/ 7q6xwmUT5b6IvZ/w9lX1/KtgDGGX6YC+LKc5mVobFr55Oisedr4fiNKyPAwcOcFPYR VNPa1aQl9YgueiI3a815AVmj6I+9w6ApbxP/eHxy+tM2Rad3gCTo0XNAd8tNNeUtw1 GrXNckhTs5KBQ== From: Jarkko Sakkinen To: linux-fsdevel@vger.kernel.org Cc: Jarkko Sakkinen , linux-api@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, Alexander Mikhalitsyn , Alexander Viro , Andy Lutomirski , Christian Brauner , David Howells , Jan Kara , Jonathan Corbet , Josef Bacik , Kees Cook , Neal Gompa , Paul Moore , Serge Hallyn , Zygmunt Krynicki Subject: [RFC PATCH v5 20/25] security: Add rootns LSM hooks Date: Sat, 21 Nov 2026 02:08:39 +0200 Message-ID: <20261121000844.1863324-21-jarkko@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261121000844.1863324-1-jarkko@kernel.org> References: <20261121000844.1863324-1-jarkko@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 3b85jk1zfj6u8z9e6dqgj5iianekkfs1 X-Rspamd-Queue-Id: B4D5020003 X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1795219822-132726 X-HE-Meta: U2FsdGVkX192R2dWf6PmnttKRHctiOrJaCHshhWbUheT6nHeCXiP7kL7e5Ip2jQ/s1K+4COhz8l24YqL4t4vQC5zZ4kp8xDu+j+S/yieKEfcz4v5BD0aVqu8E61p5ZWSzLzY28XZBNZ8bl9jh4qiJkTsV44WXXRO8RN87jNpMO+hZBoqNY00lQzLZVixtK6TEhxMtlciy8KTvhGHQlJv9+9Pfz8sxy9vtDPm8Fan80igf7rGkk+wEuLNKdHszJCVslpJq2P9tKyU7DifHq2Ig5ufjynnA8E9kj6NnvqnU0xQfMfzwi07hsJHy7aQntr5JZFpRPUPCnm0pqfgsOw7CpamxCh+P5hUlfhu15KVMBfaGKyn2cvIeErhMlSFJ0mJSVqS7y61LJ1+AgmRN6UdcSRxV8h7ecpJAbLxjtc7njSurmFaQKqP/JRcOAGUGT94EbK05BhEAfqhJMEeAyzV4xxnp4L4k0/1wm7NVzUo4o9eN7hAYiWHcj3qAAkXKRpomtrgtYn5o201mMaILB5nQPAMaYGL0UUsH5SiHL3OGHzEW55+BMFv9jltm9vv0FPy+0IHhhRv15miz7t+Oeh/NI0jjDXfCLrQJ0fc94S8MhOobZcBqE1Ubdyj6p3+luAQjrf9v1YAcM3WQBGyWRKCYZLuYGgWSs1vaZaBllpvy7YEFlIaWj8PYlq4Ol/RFzKmEH452o+EO8yX36R6+FcCWdRA83B9K4Y5wZqji4gZFTFVBJPOoY+jlg0Ct4MOzKnns+RCnAeYScEjYzIJWi+CyZdIo9FfYrHaBZm6K5kvXGONDNOroarBS7eXWyRx/NITk86AMaWPTqtena1lEJTmSwVAz7rmansjtyw3zzJxBWn/6j8auodBFUHDkXt3HugnHwJMa8jVvQpkKsH0p0lQCmFpr6L+y7EN8hLoFz/Td8ajGJxttSASBVFsbHF6TqsEn8WjA6uhZmPjCKup8XG jkMll4ir qHA4yqbzx6herYtdOPjhf3f2s326qpG+jZE20kmi8aJjoHNQZ8A1uDTEILD8tkK/6g+xuQbR0S0wz/QMQQg1vrIcgxMdmb7HAX00sHH22l7GmV5M4Ck3uPDUOgQJ6Io2bL/a9f1zPFuq2upuZvyHmAqkdvSEF997tauWBmhscFfaTZBe4omME0ftozucf2AEGaRjR8/B0vS95gYQeGCZsnwSRyuHjXHBY3RVVINv/WYUkm9KpRQDukLRGIsu/Cb4WwUjivsDpP1znbgucOTaM0Y9+bJ0RSYa+VFzZHu6ixSzZVOSXQ1v05LSd5Vli4Y33uXzPU2swihX+Zxlfw9nsaKrZz8LeEAMsbVk+g7qeMOs8VypMFwTbWuzZa3qjlugpPuF7I26Zec5Ps2kXfM0PImqIFZii5SWKa/FYpOi1oohET28WNyA213zyLziWJ0Uni/Q/ Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Security modules need visibility into root namespace creation, teardown, process entry, and container-wide signal delivery so policies can attach per-rootns security state and mediate operations on rootns file descriptors. Add lbs_rootns and rootns->security blob management alongside security_rootns_alloc(), security_rootns_free(), security_rootns_clone(), and security_rootns_kill(). Co-developed-by: David Howells Signed-off-by: David Howells Signed-off-by: Jarkko Sakkinen --- include/linux/lsm_hook_defs.h | 7 +++ include/linux/lsm_hooks.h | 3 ++ include/linux/rootns.h | 3 ++ include/linux/security.h | 30 ++++++++++++ kernel/rootns.c | 44 +++++++++++++----- security/lsm_init.c | 6 +++ security/security.c | 86 +++++++++++++++++++++++++++++++++++ 7 files changed, 167 insertions(+), 12 deletions(-) diff --git a/include/linux/lsm_hook_defs.h b/include/linux/lsm_hook_defs.h index 87d9d06710cb..2cb90ddedc14 100644 --- a/include/linux/lsm_hook_defs.h +++ b/include/linux/lsm_hook_defs.h @@ -480,3 +480,10 @@ LSM_HOOK(int, 0, bdev_alloc_security, struct block_device *bdev) LSM_HOOK(void, LSM_RET_VOID, bdev_free_security, struct block_device *bdev) LSM_HOOK(int, 0, bdev_setintegrity, struct block_device *bdev, enum lsm_integrity_type type, const void *value, size_t size) + +#ifdef CONFIG_ROOTNS +LSM_HOOK(int, 0, rootns_alloc, struct rootns *rootns, unsigned int flags) +LSM_HOOK(void, LSM_RET_VOID, rootns_free, struct rootns *rootns) +LSM_HOOK(int, 0, rootns_clone, struct rootns *rootns) +LSM_HOOK(int, 0, rootns_kill, struct rootns *rootns, int sig) +#endif /* CONFIG_ROOTNS */ diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h index 13621e9e233e..217a59d428b1 100644 --- a/include/linux/lsm_hooks.h +++ b/include/linux/lsm_hooks.h @@ -121,6 +121,9 @@ struct lsm_blob_sizes { unsigned int lbs_bpf_map; unsigned int lbs_bpf_prog; unsigned int lbs_bpf_token; +#ifdef CONFIG_ROOTNS + unsigned int lbs_rootns; +#endif }; /* diff --git a/include/linux/rootns.h b/include/linux/rootns.h index 68590b27e4ee..1301bc6961f1 100644 --- a/include/linux/rootns.h +++ b/include/linux/rootns.h @@ -32,6 +32,9 @@ enum rootns_state { struct rootns { refcount_t usage; int exit_code; /* The exit code of 'init' */ +#ifdef CONFIG_SECURITY + void *security; /* LSM security blob */ +#endif struct user_namespace *user_ns; /* Owning user namespace */ struct nsproxy *ns; /* This rootns's namespaces */ struct pid *init_pid; /* The 'init' task's TGID (pid ref) */ diff --git a/include/linux/security.h b/include/linux/security.h index 40831fab5470..995292f1c92e 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -84,6 +84,7 @@ struct audit_krule; struct ns_common; struct user_namespace; struct timezone; +struct rootns; enum lsm_event { LSM_POLICY_CHANGE, @@ -2469,4 +2470,33 @@ static inline void security_initramfs_populated(void) } #endif /* CONFIG_SECURITY */ +#ifdef CONFIG_ROOTNS +#ifdef CONFIG_SECURITY +int security_rootns_alloc(struct rootns *rootns, unsigned int flags); +void security_rootns_free(struct rootns *rootns); +int security_rootns_clone(struct rootns *rootns); +int security_rootns_kill(struct rootns *rootns, int sig); +#else +static inline int security_rootns_alloc(struct rootns *rootns, + unsigned int flags) +{ + return 0; +} + +static inline void security_rootns_free(struct rootns *rootns) +{ +} + +static inline int security_rootns_clone(struct rootns *rootns) +{ + return 0; +} + +static inline int security_rootns_kill(struct rootns *rootns, int sig) +{ + return 0; +} +#endif /* CONFIG_SECURITY */ +#endif /* CONFIG_ROOTNS */ + #endif /* ! __LINUX_SECURITY_H */ diff --git a/kernel/rootns.c b/kernel/rootns.c index 6fb49c20cc2d..bf3174023d97 100644 --- a/kernel/rootns.c +++ b/kernel/rootns.c @@ -54,6 +54,7 @@ #include #include #include +#include #include /* @@ -65,14 +66,8 @@ struct rootns *get_rootns(struct rootns *c) return c; } -/* - * Drop a reference on a rootns and clear it if it is no longer in use. - */ -void put_rootns(struct rootns *c) +static void free_rootns(struct rootns *c) { - if (!c || !refcount_dec_and_test(&c->usage)) - return; - if (c->ns) put_nsproxy(c->ns); if (c->init_pid) @@ -84,6 +79,18 @@ void put_rootns(struct rootns *c) kfree(c); } +/* + * Drop a reference on a rootns and clear it if it is no longer in use. + */ +void put_rootns(struct rootns *c) +{ + if (!c || !refcount_dec_and_test(&c->usage)) + return; + + security_rootns_free(c); + free_rootns(c); +} + /* * Allow the user to poll for the rootns dying. */ @@ -167,6 +174,7 @@ static int rootns_kill_members(struct rootns *rootns, int sig) bool any_perm = false; int other_err = 0; struct pid *pid; + int ret; int nr; if (!pidns_is_ancestor(pid_ns, task_active_pid_ns(current))) @@ -174,6 +182,10 @@ static int rootns_kill_members(struct rootns *rootns, int sig) if (READ_ONCE(rootns->state) != ROOTNS_RUNNING) return -ESRCH; + ret = security_rootns_kill(rootns, sig); + if (ret) + return ret; + scoped_guard(rcu) { read_lock(&tasklist_lock); idr_for_each_entry(&pid_ns->idr, pid, nr) { @@ -368,31 +380,35 @@ static struct rootns *create_rootns(unsigned int flags) user_ns = create_rootns_user_ns(); if (IS_ERR(user_ns)) { ret = PTR_ERR(user_ns); - goto err_put; + goto err_free; } c->user_ns = user_ns; ns_ref_active_get(user_ns); if (!ns_capable(user_ns, CAP_SYS_ADMIN)) { ret = -EPERM; - goto err_put; + goto err_free; } ns = create_new_namespaces(clone_flags, current->nsproxy, user_ns, NULL); if (IS_ERR(ns)) { ret = PTR_ERR(ns); - goto err_put; + goto err_free; } timens_activate_nsproxy(ns); c->ns = ns; nsproxy_ns_active_get(ns); + ret = security_rootns_alloc(c, flags); + if (ret < 0) + goto err_free; + return c; -err_put: - put_rootns(c); +err_free: + free_rootns(c); return ERR_PTR(ret); } @@ -488,6 +504,10 @@ int rootns_prepare_fork(struct kernel_clone_args *args) if (!pidns_is_ancestor(pid_ns, task_active_pid_ns(current))) return -EXDEV; + ret = security_rootns_clone(rootns); + if (ret) + return ret; + ret = mnt_ns_get_root(rootns->ns->mnt_ns, &root); if (ret) return ret; diff --git a/security/lsm_init.c b/security/lsm_init.c index 8d5ecea99c46..56b515b20812 100644 --- a/security/lsm_init.c +++ b/security/lsm_init.c @@ -316,6 +316,9 @@ static void __init lsm_prepare(struct lsm_info *lsm) lsm_blob_size_update(&blobs->lbs_bpf_map, &blob_sizes.lbs_bpf_map); lsm_blob_size_update(&blobs->lbs_bpf_prog, &blob_sizes.lbs_bpf_prog); lsm_blob_size_update(&blobs->lbs_bpf_token, &blob_sizes.lbs_bpf_token); +#ifdef CONFIG_ROOTNS + lsm_blob_size_update(&blobs->lbs_rootns, &blob_sizes.lbs_rootns); +#endif } /** @@ -460,6 +463,9 @@ int __init security_init(void) lsm_pr("blob(bpf_map) size %d\n", blob_sizes.lbs_bpf_map); lsm_pr("blob(bpf_prog) size %d\n", blob_sizes.lbs_bpf_prog); lsm_pr("blob(bpf_token) size %d\n", blob_sizes.lbs_bpf_token); +#ifdef CONFIG_ROOTNS + lsm_pr("blob(rootns) size %d\n", blob_sizes.lbs_rootns); +#endif } if (blob_sizes.lbs_file) diff --git a/security/security.c b/security/security.c index 4727b8347fc4..919d4bb63701 100644 --- a/security/security.c +++ b/security/security.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include @@ -395,6 +396,22 @@ static int lsm_ns_alloc(struct ns_common *ns) return lsm_blob_alloc(&ns->ns_security, blob_sizes.lbs_ns, GFP_KERNEL); } +#ifdef CONFIG_ROOTNS +/** + * lsm_rootns_alloc - allocate a composite rootns blob + * @rootns: the rootns that needs a blob + * + * Allocate the rootns blob for all the modules + * + * Return: Returns 0, or -ENOMEM if memory can't be allocated. + */ +static int lsm_rootns_alloc(struct rootns *rootns) +{ + return lsm_blob_alloc(&rootns->security, blob_sizes.lbs_rootns, + GFP_KERNEL); +} +#endif /* CONFIG_ROOTNS */ + /** * lsm_fill_user_ctx - Fill a user space lsm_ctx structure * @uctx: a userspace LSM context to be filled @@ -5795,3 +5812,72 @@ void security_initramfs_populated(void) { call_void_hook(initramfs_populated); } + +#ifdef CONFIG_ROOTNS +/** + * security_rootns_alloc() - Check creation of a new rootns and init LSM blob + * @rootns: the new rootns + * @flags: creation flags passed to rootns() + * + * Check whether a new rootns may be created and initialize its LSM security + * blob. + * + * Return: Returns 0 on success, negative error code on failure. + */ +int security_rootns_alloc(struct rootns *rootns, unsigned int flags) +{ + int rc; + + rc = lsm_rootns_alloc(rootns); + if (unlikely(rc)) + return rc; + + rc = call_int_hook(rootns_alloc, rootns, flags); + if (unlikely(rc)) + security_rootns_free(rootns); + + return rc; +} + +/** + * security_rootns_free() - Release LSM security data from a rootns + * @rootns: the rootns being freed + * + * Release security data attached to @rootns before the structure is freed. + */ +void security_rootns_free(struct rootns *rootns) +{ + call_void_hook(rootns_free, rootns); + kfree(rootns->security); + rootns->security = NULL; +} + +/** + * security_rootns_clone() - Check permission to spawn a task into a rootns + * @rootns: the target rootns + * + * Check permission before spawning a child process into @rootns via + * clone3(CLONE_INTO_ROOTNS). + * + * Return: Returns 0 if permission is granted, negative error code on failure. + */ +int security_rootns_clone(struct rootns *rootns) +{ + return call_int_hook(rootns_clone, rootns); +} + +/** + * security_rootns_kill() - Check permission to signal a rootns + * @rootns: the target rootns + * @sig: signal number to deliver (or 0 for permission check) + * + * Check permission before broadcasting @sig to member thread groups in @rootns + * via ioctl(ROOTNS_KILL). + * + * Return: Returns 0 if permission is granted, negative error code on failure. + */ +int security_rootns_kill(struct rootns *rootns, int sig) +{ + return call_int_hook(rootns_kill, rootns, sig); +} +#endif /* CONFIG_ROOTNS */ -- 2.47.3