From: Pankaj Gupta <pagupta@redhat.com>
To: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, pbonzini@redhat.com,
dan j williams <dan.j.williams@intel.com>,
jack@suse.cz, hch@lst.de, yu c zhang <yu.c.zhang@intel.com>,
linux-mm@kvack.org, rkrcmar@redhat.com,
yi z zhang <yi.z.zhang@intel.com>
Subject: Re: [PATCH V3 1/4] kvm: remove redundant reserved page check
Date: Thu, 9 Aug 2018 05:13:41 -0400 (EDT) [thread overview]
Message-ID: <2036397219.889906.1533806021412.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <d2345e628a697ee17fdd6e360f7a6790caab10d5.1533811181.git.yi.z.zhang@linux.intel.com>
>
> PageReserved() is already checked inside kvm_is_reserved_pfn(),
> remove it from kvm_set_pfn_dirty().
>
> Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com>
> Signed-off-by: Zhang Yu <yu.c.zhang@linux.intel.com>
> ---
> virt/kvm/kvm_main.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 8b47507f..c44c406 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1690,12 +1690,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty);
>
> void kvm_set_pfn_dirty(kvm_pfn_t pfn)
> {
> - if (!kvm_is_reserved_pfn(pfn)) {
> - struct page *page = pfn_to_page(pfn);
> -
> - if (!PageReserved(page))
> - SetPageDirty(page);
> - }
> + if (!kvm_is_reserved_pfn(pfn))
> + SetPageDirty(pfn_to_page(pfn));
> }
> EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty);
Acked-by: Pankaj Gupta <pagupta@redhat.com>
>
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2018-08-09 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 10:52 [PATCH V3 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-08-09 9:02 ` Jan Kara
2018-08-13 17:33 ` Zhang,Yi
2018-08-09 10:52 ` [PATCH V3 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-08-09 9:13 ` Pankaj Gupta [this message]
2018-08-10 11:23 ` David Hildenbrand
2018-08-09 10:53 ` [PATCH V3 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-08-09 8:59 ` Jan Kara
2018-08-09 10:53 ` [PATCH V3 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-08-09 9:23 ` Pankaj Gupta
2018-08-13 17:41 ` Zhang,Yi
2018-08-13 14:29 ` Jerome Glisse
2018-08-09 10:53 ` [PATCH V3 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-08-09 8:32 ` Pankaj Gupta
2018-08-13 17:32 ` Zhang,Yi
2018-08-10 13:27 ` [PATCH V3 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio David Hildenbrand
2018-08-13 17:25 ` Zhang,Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2036397219.889906.1533806021412.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yi.z.zhang@intel.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).