From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B389C61CE7 for ; Wed, 11 Jun 2025 08:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D54C6B0093; Wed, 11 Jun 2025 04:38:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AD0F6B0095; Wed, 11 Jun 2025 04:38:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EA566B0096; Wed, 11 Jun 2025 04:38:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0C3DF6B0093 for ; Wed, 11 Jun 2025 04:38:18 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A544F120479 for ; Wed, 11 Jun 2025 08:38:17 +0000 (UTC) X-FDA: 83542467834.04.1C36BD5 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf04.hostedemail.com (Postfix) with ESMTP id 94FD340011 for ; Wed, 11 Jun 2025 08:38:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=n5AGUCNV; dmarc=pass (policy=reject) header.from=neon.tech; spf=pass (imf04.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.52 as permitted sender) smtp.mailfrom=sharnoff@neon.tech ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749631095; a=rsa-sha256; cv=none; b=3EuSIlJz8VNINXr+i79xRY4h6WnRtwO/maMsDeVa84jmsjnPnlJ0HLVYJFTh1EwBO+zqry PVORsq+9sm5BMvBMFxDG+ToKLNYU/ftXfWKHsSRZtsZ5PHT+kxJjr/Y+SN6C6PWm5ArsMD 16dA2vBnRobtzghXqoyfTA0PcthSteA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=n5AGUCNV; dmarc=pass (policy=reject) header.from=neon.tech; spf=pass (imf04.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.52 as permitted sender) smtp.mailfrom=sharnoff@neon.tech ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749631095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D64AGcRCPHcvDx1jfHJpg23zObBF7fp6mUeiKWe/Mks=; b=RQ8gxy3FK25A+yH/MAYXQjQVSaAt/lO4CKua6Gb3IZlCJ3qi+YgPVl4TJ5lHl3BDpsQq32 YIo2kZ5kNEYR5QviOHFtYGKLAu2jpjYNK6YcL6zTrYnATzkQh1pZaWHBIR5ylflI6jIpMS keMPl8Z2dWEXOZ3LD37Zv9gQ6aD7Eaw= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-601dfef6a8dso11132630a12.1 for ; Wed, 11 Jun 2025 01:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1749631094; x=1750235894; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D64AGcRCPHcvDx1jfHJpg23zObBF7fp6mUeiKWe/Mks=; b=n5AGUCNVkkEzWVEaSYwPHU0oQ4CSHnkMN/+uqMxOsgnKieU4O/ScanYMm96i2YJnKO tCjxTjhPRfvYjyFlKmVrSUi96LYd9355kTkk5uTqwdrp+we7EOoTqxEDt32RoerC5xed 9/0rjiNusi9ShJjH/Kzf0+fntUEeUvFwlw1ds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749631094; x=1750235894; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D64AGcRCPHcvDx1jfHJpg23zObBF7fp6mUeiKWe/Mks=; b=uWh5whB5Dhjsj8ElRIPWoK6mPibSLocqAf5SC9YQ/25oImINqEDzgnoz2XAl1Yez8H /cqWCstfier0WzZO0nNJo+VOuk6jT6U3rHWeiQmGJumdOsFIPwp3hsJ0meJPtPQoKDf4 RLIS1hm588pZaX8bsPOuA4q/8cicezjjYfAK8cinyji6NrAedGi+6Io7MkT/LPLxmi85 IHFdaWedlcKL5iLfU1yQ5+UUzXV9g8C4DAiC6abyLFXQsxUlouMOZQo1wYfbGWc4KgPX EMexaHvZl2ORgYV5vPQ7j8yTMnVZ1ofBKISSJ26Iv6RuP9iODAts0kCdVdzAX73d0vvK T9fg== X-Forwarded-Encrypted: i=1; AJvYcCXqnaW8luTbzEnoFjKYIjdC/Cdwk1J4BD/bAtlrl+/GsXH1mAKoBcEfrthj3uBzWuHCpBvSsmBs0g==@kvack.org X-Gm-Message-State: AOJu0YwYdT+XCnWLcsBChRQy0kjvZZQk9uSLhabODRI+qUu3BBd8T7sa 2eHUE4Y3g86eQu2bqZU7owB41zhhhpCYYAkKjUqNJp5Bpze044TpRJD7ROsXpOC+nZ4= X-Gm-Gg: ASbGnctDjLUscY5KptEHbDvbXQfUfed26u9P8RE26dktPddVN4jNYZ0kiK8JVnNNB90 rAtTXcvyTJr76+clxv1S0CuTpsHP3gJPEQ9BXPjWJX1BlOVkvcPO/3mY7gZW+PhS5DiJECHskb1 ITsoXfXc/U4g+HUewTp3utt3dglzMffjvPmsyZ6QrW/0XRrZ5+VscnqseQHPoo3m6388gj3ZF5C t8BJXxc1O+txBgyXCjuvoiVotVsR2xsh2EiEJaz2DSWzJeGZiXyVHj9IWuwYzgLwtYQkyPmDGaK 2vcm8gj7X9tOs2KNg0dohogxQ6oaPihNnyU4Vj2HJCfYhi5tWV4x8MzbBgvB9xm2Xg== X-Google-Smtp-Source: AGHT+IHfpgxq/IKP0ThT1N5OnbuDnVWyZUPwXmhwvUMbpRGv4tnTD5aJBQbcBrn4Pnd25O2AoX5W1g== X-Received: by 2002:a05:6402:382:b0:608:523c:1365 with SMTP id 4fb4d7f45d1cf-608523c1401mr864164a12.29.1749631093581; Wed, 11 Jun 2025 01:38:13 -0700 (PDT) Received: from [192.168.86.142] ([84.65.228.220]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60778377a38sm7268698a12.27.2025.06.11.01.38.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jun 2025 01:38:13 -0700 (PDT) Message-ID: <2080ec7c-8dc8-4f03-bd96-78ba47e55a97@neon.tech> Date: Wed, 11 Jun 2025 09:38:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*_init() To: Dave Hansen , linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: <22cd0fa8-d14d-4d37-a6a1-5e6827d6182b@intel.com> Content-Language: en-US From: Em Sharnoff In-Reply-To: <22cd0fa8-d14d-4d37-a6a1-5e6827d6182b@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: mi3dcz5ksf3wwp3bwbjmn3acptqu4cdi X-Rspamd-Queue-Id: 94FD340011 X-Rspam-User: X-HE-Tag: 1749631095-26840 X-HE-Meta: U2FsdGVkX18KhO7yUdefxuv594JMn9KOE7k4lbCn88K2pGq619ZsA1HCVhowg/uacMW78E3okIq6aMqLAriumLcL9Y+WYsf3TUdQHW6OYbh9YC8Uci8S+tN276tUAo8u6Nw2xpa/xyJupyVvihE0Xn+bC/ClNaKowfTKInlCH0WVGHqI1VcqAJfEq023Gq1dysXqmFrKSWkEVTkCwwWA41ExYRZV1RcdXkbw0QI38vI3H0oMSKIar/YgKCAtHZD+HV9OEIdqfovZ4rDNRkUK9ANXQLyhMxns4TAJtiFHBeioux+lI+ZNeDuUI+avh0teK8827TKSgNDp6A3nkjl1YnsGix3HmLgumjiHxttOX9UflE6+aWl7Tu6jA7VZFA87xpX5BE31epBOFg29F2eMTkJo00eJdL+qhbo5QsHnEy2EiwXizqQp5F6VJUOYyBRjipj4eOo+GVt+lsfHcTZP21HMpa6+cZJ8YDz6i3sjyB5KuPOVBT4aMAqBaLWm/99PGOtPpEJ2ygsK1GZX4t4wtzBPfRcZ1mENuWDzKmGhZTXVEV/jsBOVk/DTdCBb4wsMjpUIdu6XPd+TZRJ/tJqboP81J6JCehqk5/pd342KAHuzhKc7WrX9KjCFwBdCJ5x8zZ2XHbbJysscW2JbnfHFn5dr8r/eogY71me0WnxuASsm5WonnvpR5oeyRoHmkomx18dqgBAPRwmcWC+r/6IkuFmJDS/tfIcTbsuYLFGq/uKmGw2gpLYoKjboT7i7gqmT+mW365m2oNFNAt/VLW13oLfVYqXkqYM/lKtMtC+0BElZqBFn0YMz3PkaOMvJp6G8e69QxKBSSZWDeskUot74/wbVz8dfkch7TMk03hXhJUSG6mbKELFncX+vC/XojUG5ko4SDExE0HCuFMwE9XQymwb3IGZuuMo0GQ4CG5bw4nv0gpN97HFTlFJvdTiRtiYk0d4RaVZlkifSUsLf85v aJFwNQgf 4B+sel/79w503/qdAjelYrHDyZ4ONG0lXjjO+8/ikGl+P0trpMjPC5gNgjxY51GxlUgv8xtKsETprN5klzJ7m5uj29csSB3PgkiPwQDUPL2BJK9YXTlf5QGwKJJUwkzJ/bS4E190kMlcLowpmxm594hmJmwKVJBPYDkbxZdJPUVvx2xLk6rYI2dsN8xEwXUcz0bHRnNrgFl02Qhv/8tPv8NOOWU7MeEwW5CiuMi2XQovoD5d7f9REitn+kK651RkbyJp3uye8UaWn+0eq/plBpk5UncyQEpctTLyt5ZJyIu+E5ItMVf79nmKvw1QO1xgO3v35Mg/llDZERXWD5myDV0Xg7A7CBU3/syXTyz3dqldgvR8UNiTE7CRo2if/YaUuK4NsYJafPGc3twQbQlrMLaO7kkFK9/CIl8IKr3pxRjFjhnOeuGIShePbiae6QAYAXiQ3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/10/25 15:55, Dave Hansen wrote: > Are there any _actual_ users of 'paddr_last'? I see a lot of setting it > and passing it around, but I _think_ this is the only place it actually > gets used. Here, the fact that it's an address doesn't even matter. I checked and didn't find any other users, but I'm happy to give others a chance to correct me in case I missed something. > Could you please find a way to reduce the number of casts? What do you think about changing the return for these functions to just 'int' for errors? It's a larger change (especially if all callers should be updated to check the return value), but I think much cleaner in the end. > Please write everything in imperative voice. No "we's", please. Noted, thanks - will address in the next version. Em