From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11DEC71135 for ; Fri, 13 Jun 2025 07:34:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 486676B007B; Fri, 13 Jun 2025 03:34:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 430096B0089; Fri, 13 Jun 2025 03:34:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F8276B008A; Fri, 13 Jun 2025 03:34:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D5636B007B for ; Fri, 13 Jun 2025 03:34:15 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7DAFE5F642 for ; Fri, 13 Jun 2025 07:34:14 +0000 (UTC) X-FDA: 83549564028.29.FB4A490 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id D5ACCC0012 for ; Fri, 13 Jun 2025 07:34:11 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YkpaKeHF; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749800052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rcjaf27Gt9/YbDNb0ynWCORuUM3eg3EGEnmFODPaEe0=; b=GLaobSxpynDK13zj8bVdxmqdKjtRNWD7FH4zHke3bKHfzHD7Ji2okYVCFyayA2NfRFYnyt iPO1uOkCX8oQCDbbyoFkIXIh8hWUTpPEHnbN2UJoJOPcfq+TRnaMa8DxSfvNWpVNn0XzY7 1fX0oV48ULhcGB32pSHBdAsCSdTFj0A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YkpaKeHF; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749800052; a=rsa-sha256; cv=none; b=fmrSC75pAiyKJcE9YyuQp0Lp8291rVIIEU1tXHYx4SwO6Rq4xCVAcwH0SlygV0crEW/ow1 PZdW+JrfgM4aj8Tmukl45hqR6EbMZHqx/iwCjRhXzZPZ5aXiSU8CTfgewZi1I3UHNRt/Gu kiJ5Imo8PM49FgRbCzx9HzgSh9v6qzU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749800051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rcjaf27Gt9/YbDNb0ynWCORuUM3eg3EGEnmFODPaEe0=; b=YkpaKeHFaZlA+hwyDfrkgwbTUUB9y6Z85YBxew+XRd4k1GBxBCS0qoIQMkLNsv9MvtFtTr Z8WpZlMlBOLmVh6TKlbrpzC/HmJ0R9J3fGJvoH8nEIhJL5CumdhJ224bc7JfOzOlTIFbco OJD5UKKVMJk0ilkBqq4tn5orqHulMPM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-TUmGUXOOPuK_Mm3X5NI90w-1; Fri, 13 Jun 2025 03:34:08 -0400 X-MC-Unique: TUmGUXOOPuK_Mm3X5NI90w-1 X-Mimecast-MFC-AGG-ID: TUmGUXOOPuK_Mm3X5NI90w_1749800047 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4eb6fcd88so1194283f8f.1 for ; Fri, 13 Jun 2025 00:34:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749800047; x=1750404847; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rcjaf27Gt9/YbDNb0ynWCORuUM3eg3EGEnmFODPaEe0=; b=uHU3uAK+zlIBMqhsFp9ISp1G2roJOkxCxkaYD6R0dWS7t5j5RG0ADRdflVNaUehYS4 pqVLYUsjoB4E4kTc+p6M6oifTyXt7k+BlqILyMHLuPea/ju5FYn8i15OsuBv8ahCIngw XVLme4+Md5EShrvCj0gy2BVSz3DiSEEGH0D5iuj9XfOIcB9txitAHarzgf9J+PGEMHTI o2U7kFf/XkCjr5/l2GmoMmMpgiZ2xlcxlXcFX5NJSczSz8GrMgoPsMUKLvfOhy0F3coI J+t/S+RvMHjuqCVd3f0SeWwgaXA1SsvLhehfbIYlXzWWrtR5wj7geaRqVbXDrLVeozPp dlnA== X-Forwarded-Encrypted: i=1; AJvYcCX0ig2XyE+6oyPf0Y3Asp9xl3vtgmfiCGyp7etOwT5KnCa+vMCoR4IJ2GH/8z6ScQMCOlffaJxHEA==@kvack.org X-Gm-Message-State: AOJu0YxFbvaZVDXTz8ncqXlJDWLEPsCS7qgwKkh+YLOaiP0+ovbS3ZI+ DDOM0c6IhQAe8Ofap5/gScqbnamw/hy2+5snnKQ54nJjZtNt09rtiRPbN/vpu62XXS90BkWEKvx 1xyuTOv+1KeZ+fqwAI4xCQ6Hev4qRz2T6AvW0+e64MfaRKLbDWmV7 X-Gm-Gg: ASbGnctOWmNAILFyUbdUNU73zoOrpeGJ26xW/g+1XQKvQWqkyenWDhpO6huCWDdVpCJ 9vJUmA8Y4TVT4NABjLibtnhCcOsuh784iX2knlk6uYyDfUQcrWI9AfwcelQ9RoY62Q2x0Q4n+ZX psh+hLe6vOITfs6CKwSqKXafM7T9lhYH1WU0WGFV9HlZGPG0gS7WYoP9LkQNAbjqDIPubYZXNUw GXRch/ACVqaAqQh5c/OXvs4rQJt0SNcVV77Sn9Y4sUsURSkR0bxcpqqE5Mfl7Jli7+VjT1yGgz0 HSLYbGofo1WocFrSxtIIrs6lvTlUdmTVLWT1r/i0s/8YMxd/31Z6143ILQSMrP3aNuUPMFPE1C/ 45jUPvvqetNCfUjNe6t370dOvlG7nbO0mSNerA/8Et5Oj2Xt88g== X-Received: by 2002:a05:6000:2204:b0:3a4:e7b7:3851 with SMTP id ffacd0b85a97d-3a56877ff2emr1921891f8f.58.1749800047197; Fri, 13 Jun 2025 00:34:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9TBjfgpd3Vg5LLw43B19uhX7HMLfUYejxZ7ZSVefWQp+nmtkbkT9vAdG3/PBKU2z5qAB6mg== X-Received: by 2002:a05:6000:2204:b0:3a4:e7b7:3851 with SMTP id ffacd0b85a97d-3a56877ff2emr1921854f8f.58.1749800046729; Fri, 13 Jun 2025 00:34:06 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4? (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a7fa9dsm1491399f8f.44.2025.06.13.00.34.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 00:34:06 -0700 (PDT) Message-ID: <2084f57b-056c-41db-baf8-65bbc72a66ff@redhat.com> Date: Fri, 13 Jun 2025 09:34:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] selftests: khugepaged: fix the shmem collapse failure To: Baolin Wang , akpm@linux-foundation.org Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, shuah@kernel.org, ziy@nvidia.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DPgia0uG3NBBTFuT2O5nDD99v4INJVQtp5UyxjmSA1I_1749800047 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ye8xqzzmwe4s8hgjiqa7fwmnd9g1ffay X-Rspamd-Queue-Id: D5ACCC0012 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749800051-280370 X-HE-Meta: U2FsdGVkX1+fE9dtEjl6rkzMMgqn+nSSqesw4AQaEUa01zflY6FvGGn6nJrozDxufel8ecT4Bncd45DXp/huaPazEdYHgG9jKWw7Kg1/WHDNF+AtkIfqPmZoc325KBcp4UALJCGP3bYVZ7XrFZUyh87ooum0Gas5DfIwDsF09L2LBEz1Kl8BkITyb9iO3WmwWiXlKlMmE41cbbNSegxl1v7660PXLTvVKvEwbnzaV5fTr+OP1fLWP3wdUAbk+YAQv+h141dwH7RxDmnxgbzo9C2Gn0UvqhtDPBlqwFExDBZFbDyXKJX4Cv2wU51uhd6I6O9yZ1GRBnTvddR631vEgmft45X6e5dPsE93PqUKGAwTdHSn5/J9l+FHnWgiaImFn9OoPxrOWAndnLfbvF+sBbPtLhLxiKMIlDPyo6odRfJdTFXt+d1SWatnN/mLcpgUAtiG+dWNE2tPENYtgCaRtJKtrx62SJNQeKkLA75CjZaCwD35/MHK6CHCbPNdl30G+csyMMGnCh1wjR7TVv0YeAOTTmOo36p4aYOmaocsh06v13XkLSNWuqfFvo0LXubQk3slXgZZUrE29j5uyM0nI77minme+hH30URCK9DB8BNs7E/L8PUGS16yQcKr48cmQyEFCVGQTuPoEeGYRiTZNMgpqNAd4z3aHNYN+BR+emhKJqCw8T4atwePYThcPiy7uvq0qqxpPxyv7s4BitwpazdSiTvIkWLwfTp9LZvejKDK221BdDITeK/fydx6hSe6Xa6uwId8z8ommK/Q2j2NqXmOAv2CsijSBte0VqcHsKOb15xt2P6tH7OFEDTFPyvwTR87t58FFMSWrPopshQIt/gYAXmtgdNvgN/Vl48AUIH7263PrqPyM6Ifp3xHp3LtP3duX067zHiCgXLZ22SdU5u1j5OiY3yRDHfeo9HqGTnScP9FaxGLLFFIbkQeDDTou8mKthV+AP+BS/rDc+z gaPGOFyF kmVfuk1L5q3rL6rE4bR0v3UALvAY894kw/y85/M3VYzCEjv2Uh7bANFz9Ykp4lYzgm2IX2uVQEV/6zcnjfDmYBN8rzcsVcOhbaeurFhzZNnIIUmBGV7JLRw5SoMneAUC0Zh8dzOMmjReXV59UosoN7ObcxvhHjLbFWUxUzBsp8tsc6M6l3KgkmQoJ6P3dyEUxdbAsBjVOUyL/Ea5O4Iita7TAYzvo0LKWH6Z5HoPMNlG5XjtlbqGhNzZMFEOVlW62UVLlIDZAdroBIosq+gaLqaH7+5h73bnDkrronh/DDxmzYGVR9C/sbgQw+EASKL7xzk1GrDOdDDIWElfqnSexyOPyDUL9ECXcD5eKU839+AUFSE2LhE74v94J6gpFu5ihfeDt+QDtD1uosHGfCJGxh04ISx2QWWN0kspZlKxNcIeKpG6MGilPwFB85CaU98t7BJPAXW/uy5qBeq53bI0JoUkGPneT5RWHr3+S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.25 03:49, Baolin Wang wrote: > When running the khugepaged selftest for shmem (./khugepaged all:shmem), > I encountered the following test failures: > " > Run test: collapse_full (khugepaged:shmem) > Collapse multiple fully populated PTE table.... Fail > ... > Run test: collapse_single_pte_entry (khugepaged:shmem) > Collapse PTE table with single PTE entry present.... Fail > ... > Run test: collapse_full_of_compound (khugepaged:shmem) > Allocate huge page... OK > Split huge page leaving single PTE page table full of compound pages... OK > Collapse PTE table full of compound pages.... Fail > " > > The reason for the failure is that, it will set MADV_NOHUGEPAGE to prevent > khugepaged from continuing to scan shmem VMA after khugepaged finishes > scanning in the wait_for_scan() function. Moreover, shmem requires a refault > to establish PMD mappings. > > However, after commit 2b0f922323cc ("mm: don't install PMD mappings when > THPs are disabled by the hw/process/vma"), PMD mappings are prevented if the > VMA is set with MADV_NOHUGEPAGE flag, so shmem cannot establish PMD mappings > during refault. > > One way to fix this issue is to move the MADV_NOHUGEPAGE setting after the > shmem refault. After shmem refault and check huge, the test case will unmap > the shmem immediately. So it seems unnecessary to set the MADV_NOHUGEPAGE. > > Then we can simply drop the MADV_NOHUGEPAGE setting, and all khugepaged test > cases passed. > > Fixes: 2b0f922323cc ("mm: don't install PMD mappings when THPs are disabled by the hw/process/vma") > Reviewed-by: Zi Yan > Signed-off-by: Baolin Wang > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb