From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448FEC4345F for ; Wed, 17 Apr 2024 12:18:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1BF16B0087; Wed, 17 Apr 2024 08:18:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A49D6B0088; Wed, 17 Apr 2024 08:18:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CFF46B0089; Wed, 17 Apr 2024 08:18:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5C75B6B0087 for ; Wed, 17 Apr 2024 08:18:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D5D1480DC0 for ; Wed, 17 Apr 2024 12:18:21 +0000 (UTC) X-FDA: 82018926402.23.78BEA1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 950B0160022 for ; Wed, 17 Apr 2024 12:18:19 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ayKdFLcL; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713356299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mw1O18gbH7ZpAoJygnjuD6cxPj3U80IsZiWOLT2eTIM=; b=wV76rboXGwsPdOcZhEL21mM2f4y5CRco8tK4fBwKMfqFKwQoX8PG2orxXz9k0hQi91pSDT 7C0xncKIkaFxyqjupVCTEg0mMDz0MxboDusFLVt/uaZDjyxhi97zMA+VbjqRTgzAYixvCN Yl/fE/vg4479NlFA+DBIK/QZ41clRDo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ayKdFLcL; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713356299; a=rsa-sha256; cv=none; b=3DlBWtX9L12COAykI6RKoznkKVlQPP7NHKJZSs3YoIqfOHvYnfaIBIRQ3pxbfUUpyqZnLa rL2yZGV+bAcwPCNH+iOnhQUEh3YsGBu5kOigSX28gRI7t3sHG0BL64/6wg4JHmJPIwy+Bi XDPGzRLSDuMxbre9pIcN4gTiqNrh8lM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713356298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mw1O18gbH7ZpAoJygnjuD6cxPj3U80IsZiWOLT2eTIM=; b=ayKdFLcL5p4VWexykJuWAsT4cTAAXtou/rV/0nnkl5fOYCmE+4LUyPUvPBAX+sEyzFOBne M0c9h9IsRPu7HKUWASRL7X6wvp9fo/ftseOP1FyQy0hEG7RSCnPQE9rqZ+C5ocu0xfq1yG joTXX6fvazaX4NtBFqfOXk1yfltMwQU= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-1XQkff-SMQSwWjs7cT-znQ-1; Wed, 17 Apr 2024 08:18:14 -0400 X-MC-Unique: 1XQkff-SMQSwWjs7cT-znQ-1 Received: by mail-yb1-f199.google.com with SMTP id 3f1490d57ef6-dbf618042daso8357915276.0 for ; Wed, 17 Apr 2024 05:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713356294; x=1713961094; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mw1O18gbH7ZpAoJygnjuD6cxPj3U80IsZiWOLT2eTIM=; b=X7DjXyI7ql1NKrviZ2KRjHlZ6iq2RvWlgmDo4FaXC1S7snn65isY8f+NDOFnzWu7yH wiYg+PH8wm+J81+Z+cvW0qdHNc2p97Jv4qfEEVhjuN+mCNCsquVEen7QZCinquoczXu8 ZN27Jl2CPzbwp5j6J7FtKP1unbuOuW9yT4Vg4ku3MmMYRPeiHrhhwPKp1H+7pYlwpE7N iOqE5zhuqjYsvs7DHlokHGLV2D+keX7SwJuUf6a//cH/120GbMknXimdX2rszKL1l0BS drqkwjlsKgKbNIfm6LyapuslBahZVAX0bUP3/ZLezgi+6U5JaAaDrNzcvSt7mVF0rWI+ asuw== X-Forwarded-Encrypted: i=1; AJvYcCXWmnpS/hCXH1T5NAcuCe9txf6KMy1uHeLFhN8fZxBT5xMikxXaI6uCSojui+pShOv3qxK4qlKYBwexp/1pgUQCYn8= X-Gm-Message-State: AOJu0Yy91WCxLEIS5QbWgMEt58Z2HZV8LSKUHKXLUYZ5vMn6pOQGcecF ErgKxhvpqmBDsvRf02uhDpvLprEUn34YYtFBlWY6Xa0xaObhg+Bv6FC2ux+RjRxAQHbtF47LaIR C/mUsKisu2x9/LQCIFTFB4CbLzlUucwcaStiCzckIaK8LgDrZ X-Received: by 2002:a25:8141:0:b0:dc6:cbb9:e with SMTP id j1-20020a258141000000b00dc6cbb9000emr14945226ybm.41.1713356294158; Wed, 17 Apr 2024 05:18:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHd+ZmfUuFEEA8xWILQJpSD9kj6k2fm0H6n2sACdE/Gv3NryInJq0B2TXKP433mn3U53V+NZQ== X-Received: by 2002:a25:8141:0:b0:dc6:cbb9:e with SMTP id j1-20020a258141000000b00dc6cbb9000emr14945199ybm.41.1713356293856; Wed, 17 Apr 2024 05:18:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:2300:653:c844:4858:570f? (p200300cbc74523000653c8444858570f.dip0.t-ipconnect.de. [2003:cb:c745:2300:653:c844:4858:570f]) by smtp.gmail.com with ESMTPSA id o15-20020a056902010f00b00dc22f4bf808sm2839357ybh.32.2024.04.17.05.18.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Apr 2024 05:18:13 -0700 (PDT) Message-ID: <209b1956-a46f-41aa-bec1-cd65484f36cd@redhat.com> Date: Wed, 17 Apr 2024 14:18:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] fs/proc/task_mmu: convert smaps_hugetlb_range() to work on folios To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Muchun Song References: <20240417092313.753919-1-david@redhat.com> <20240417092313.753919-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: toj5zu7kdyfhpffpj1dfb8k78t1ziyax X-Rspamd-Queue-Id: 950B0160022 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713356299-358206 X-HE-Meta: U2FsdGVkX18Q+8gWgz3/mrt0r4Oqf5sdiG2iE9Hc1RppbuRLPDChtlIxIU2AMCA2HUfHzELO69Jk9ufl1Xj9G4430AqI8+0eew3RflpskxKsbXGNP0kjEVFj+GF6t8+H22SlNlbiBzxgHy0cb78nT+GjVTfkuwoKzL730DVoQpV3oHA0a5PoIsBkpazLBrerMmFTJf3cIyC/4QNBtpLaPYxRRyFCXSDpKT0JVH6wbzDfyQiTiwjO+AlkEOClCg2T5dBiul5K+Xv4OCca3o0eRQa/Hn5yIhEE/5+GMIUDlQPL39CBo9HPCCPq/C/lwthQmsHphPSlyfJzNKxZ/Ox7s7YCEMOARBCpsfTZDtRZC1+riZvN+8W63YvtYEAwpPt2sRbDRzjLlQPtGONu5LK6RwpKYnXX3nynMY692QPEByXkXag1BouXvTG+YGw9/cxaTUZ+LU12uCm8qTtAIuDx5pmnYzJ7ksurw4zM6WOgZKE0UmDj+3kj1R6Ndtyv+Osf/xc866t89qFuWxWMFSFUyrOW1Rh8luLtPxfYan/q4+6UmFtn0KZXIwq7TKNXD+pM33m+x8SE9ZW10fwbElrsYSZxux+NzwARaetejWNzTKxHHuzRE0Ki1oVk5wpQRUCJO766pbX99fqt52YNUy+RWrMMZ8jvMc06+KxPkFQ6LxDYrjabLN8HxpPyMZKsZMxJBLrPQAdEpry1vGyqU0S6OxSmdqdWIukJs5/3IDw3Aa0SC6zJTUlP1qKYKZmL8uDNDADkBvY03xoMJ124RMbDECIR5HOqfeAzFsPKoVba6w3vGxr7UpwN7e7EDbFK22HzUWI4R5Mks/LrvIlXAlNiQjWVG8NrjLxhfaP5EA20VgVMH+/PCl0668Mn+wSzrwZmg8H71Epl5+JB7/sokE7EGAdu7Ne2URfu7ADHyqzW4md5nzJlYLdncGrPED3RdWxxpFpI56ZV83QoeOK51In N6jQaN4j xHs588o8tImYieDVTtAa+fx7GRRiacK0C+NExzQtme8t3//DfyYcEB0Cqbwx59a4hOKEWxsO09WQwd17/FI+Yvo95xw3S0rQzhtO6b7LhyOjyn9IJXi1AbgV/SZjzdTjKqvfurxqz3JkwfYEOUZ7BcxccgOEavMrw9FYEZ3ukWTpG5Tg20nuiVNxvPJHBP28xn9SJpXLMdEEoLWl3zJF+aGzyifsdpbw6/cbmhSN4/XI/fkespFgaDki4ZkHZP0uph+tCoAB+eDYVbjTZ1ADlgfyFwM3vsz5OOFN+s1T/9hr1a2dgog0soha5o3pp+ogB+QfGbMz+Iqi7K6ijv9CoH+31xrNBZqD3DsMSidlEskFs8skcllo+dc+S6n3LKuUWZHaVPRhNMPBEGev2/OZf12hVfF+/Czrjx8hJFDaENqUtx5s82qczx40QIbQgcO9GJcnr7ZfA69umoWdWXrzsHvr0Dg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000338, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.04.24 14:09, Oscar Salvador wrote: > On Wed, Apr 17, 2024 at 11:23:13AM +0200, David Hildenbrand wrote: >> Let's get rid of another page_mapcount() check and simply use >> folio_likely_mapped_shared(), which is precise for hugetlb folios. >> >> While at it, use huge_ptep_get() + pte_page() instead of ptep_get() + >> vm_normal_page(), just like we do in pagemap_hugetlb_range(). > > That is fine because vm_normal_page() tries to be clever about mappings which > hugetlb does not support, right? Right, using vm_normal_page() is even completely bogus. Usually (but not always) we have PMDs/PUDs and not PTEs for mapping hugetlb pages -- where vm_normal_folio_pmd() would be the right thing to do. That's also the reason why hugetlb.c has not a single user of vm_normal_page() and friends ... it doesn't apply to hugetlb, but likely also isn't currently harmful to use it. -- Cheers, David / dhildenb