From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E203C4345F for ; Tue, 16 Apr 2024 12:02:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CD306B0087; Tue, 16 Apr 2024 08:02:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956746B0088; Tue, 16 Apr 2024 08:02:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D0D86B008A; Tue, 16 Apr 2024 08:02:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5D5D36B0087 for ; Tue, 16 Apr 2024 08:02:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D3048140AA7 for ; Tue, 16 Apr 2024 12:02:34 +0000 (UTC) X-FDA: 82015257828.04.06CC2B4 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf17.hostedemail.com (Postfix) with ESMTP id 96D3940023 for ; Tue, 16 Apr 2024 12:02:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=efSm+JIt; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf17.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713268951; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RL4SldF35NlNvMsqOFwvpvMKNHxNrohbBmlz5SARb3A=; b=Bc8AxmJu+aaEkMgr9i3kweH4a5fw66M5I+cRwFMZyjcv0jaVBQlUtTEsSt0d22AWHg8THy HBHYv2xDRI2XDzycLi8nqOU7ZZdUsEaEHHFQ4zfQZ99Ux4qxtko2gEa7UiTQ1xkSTfyKgj MjeNiSRuTQM8qVUkBQvlx+Y0gIY9B44= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=efSm+JIt; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf17.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713268951; a=rsa-sha256; cv=none; b=nztmPG8aE70L5AHJCMuyfltFrldUJHn8NwxbtFN05Ka1y0LdSNTi+iVXnCKQcarKxpgcJy npG2znvOIk4W1eqvgApyLpdGzbqxW6Ux5Qz+KJEZzqkroascrsXQG60QrKUIsWQMnPrg3+ ezML5YPCteHW4DiN9/ua3+0Qaevh4bs= Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43GAScMb031904; Tue, 16 Apr 2024 12:02:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=RL4SldF35NlNvMsqOFwvpvMKNHxNrohbBmlz5SARb3A=; b=efSm+JItYNBcGoyKi3IcXexxmeDEg0KGkbcb0KrVvHA3ComO6H83i1SwsZehZzFpptME diu1IoirH4sLxgs5gV2a+OlehqNnsUMziuxq2jS0w6isJyOzvrxikXZLE5rPeoexUsnL JAGDLFU9O9U0adFa3FI1VuikA7JRT/ECHnfkzv96gwQ1E1OJUNR2HUN7EWEekxG/zsFP Sw5rg8UgwDDkRPEvflR6qavz4FO1zzBa5o+0ChV5hyM4cSThjmPjlMKfkNa1IYznvX4u qG80nmD4zh42mpx7P1TOjTVCx9dt/kz5E+YL0TQYXIbuY2qFVoB1MHLD735YkOWzWlrN MQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhqky0598-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 12:02:30 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43GC28mM004926; Tue, 16 Apr 2024 12:02:29 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xhqky0595-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 12:02:29 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43G9drqv015506; Tue, 16 Apr 2024 12:02:29 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xg5vm5sye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 12:02:28 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43GC2NBS40042794 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Apr 2024 12:02:25 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3764D2004B; Tue, 16 Apr 2024 12:02:23 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 914B120043; Tue, 16 Apr 2024 12:02:22 +0000 (GMT) Received: from [9.152.224.222] (unknown [9.152.224.222]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 16 Apr 2024 12:02:22 +0000 (GMT) Message-ID: <20d1d8c5-70e9-4b00-965b-918f275cfae7@linux.ibm.com> Date: Tue, 16 Apr 2024 14:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests To: Alexander Gordeev , David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Peter Xu , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20240411161441.910170-1-david@redhat.com> <20240411161441.910170-3-david@redhat.com> <8533cb18-42ff-42bc-b9e5-b0537aa51b21@redhat.com> Content-Language: en-US From: Christian Borntraeger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rOCqEBPwxOZabIO0iThK6HIAofE6o9PZ X-Proofpoint-ORIG-GUID: c0NOLnVFYJU1pyCLAA0PU_HqyxkdNqbp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-16_08,2024-04-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 mlxlogscore=768 spamscore=0 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404160074 X-Rspam-User: X-Stat-Signature: wxcpou6mzcrhzwejjiz3c9uhunge7rn4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 96D3940023 X-HE-Tag: 1713268951-715405 X-HE-Meta: U2FsdGVkX1/h54Upphw3mqKtiKEi+6bo6Wx8kE0jwrUUy2AXXX7D/kBtEjSPNTRHowyDf22IVUaEw++sBLK+X/4Znx26pRBvut8r84RJbJ8JZW8iH9MqH/aN+7b0WrHuurGmJU7rqvwFWeagnMdPYX+PVD9KWefjgphrcFva+V7wwJ6O+dIeNjRx3AQ/3gCg4LdkDKbu77hrNUvWd7qrRxMTgWRJW3FTcazLkeJK6qSuMn56kshq7sGn7Z4EAqJTkL7mcZ676kXqwMOY2IFeG21Lxs1BMh0YftOlrLfqdque2ORlr/i7SKr+uiRMZRRckqs3arOV3WAIWv/ffMx4H8Lmd/fAzOF83cELs8ACLxdniZuLgP9N+2V8P5HFg07A092kFUftNieDOAS5dLochpP9Ri75Aq8whnjQL7coL1gG2y8lGLgutDe8prnMwPI1YW05FtXVj5BEFA6cdNVtws9911n+ddUVGeck9H9dFkw07lrZN3no3XBz0eWER+vQVRWjWbY/+Gg0KOf7GxI989+3CFJsdCg0qiFoeD0GDzonpaVAHhBlYTWNW0dvjqF9dAUwP4b3cABMlYJhFt+CpB5B+GFB3frZYc2nowMW5Nj9MTSL26JmlgicmpXJbCYcSjPDQI0RvdwfATb6AtekEScEC1kfx6TSxnqmzVfnBsjNjOl3qVhjPty9UzB7j24+djLd1dIJq01LjyxVjafNubwx2CNxffi49hfaqjJzbUtaFp2AjRSF02PNHFg97lFQAT0kFdSZs4nwfdrl6Uk6okNd1t8g1+bhnaiVZuIFzsYU1TY81oepR0bN5+gPsG+J6Xk182OPypMvWcE06a+KnZ/1IX4LvwEIf2cjKQ97vMBxbstjWnatW5AUX614TQeflOV1VKpARubAehI1U/tO5foyCUNr4UEl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am 16.04.24 um 08:37 schrieb Alexander Gordeev: >> We could piggy-back on vm_fault_to_errno(). We could use >> vm_fault_to_errno(rc, FOLL_HWPOISON), and only continue (retry) if the rc is 0 or >> -EFAULT, otherwise fail with the returned error. >> >> But I'd do that as a follow up, and also use it in break_ksm() in the same fashion. > > @Christian, do you agree with this suggestion? I would need to look into that more closely to give a proper answer. In general I am ok with this but I prefer to have more eyes on that. From what I can tell we should cover all the normal cases with our CI as soon as it hits next. But maybe we should try to create/change a selftest to trigger these error cases?