From: Rik van Riel <riel@surriel.com>
To: Usama Arif <usamaarif642@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org
Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev,
roman.gushchin@linux.dev, yuzhao@google.com, david@redhat.com,
baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org,
willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
kernel-team@meta.com, Shuang Zhai <zhais@google.com>
Subject: Re: [PATCH 4/6] mm: don't remap unused subpages when splitting isolated thp
Date: Tue, 30 Jul 2024 14:07:39 -0400 [thread overview]
Message-ID: <20df6650c834b3d2d6e5d7062876ee6a1e997dba.camel@surriel.com> (raw)
In-Reply-To: <20240730125346.1580150-5-usamaarif642@gmail.com>
On Tue, 2024-07-30 at 13:46 +0100, Usama Arif wrote:
>
> + /*
> + * The pmd entry mapping the old thp was flushed and the pte
> mapping
> + * this subpage has been non present. Therefore, this
> subpage is
> + * inaccessible. We don't need to remap it if it contains
> only zeros.
> + */
> + addr = kmap_local_page(page);
> + dirty = memchr_inv(addr, 0, PAGE_SIZE);
> + kunmap_local(addr);
> +
> + if (dirty)
> + return false;
>
A minor nitpick here. The word dirty has a few different meanings
in memory management already.
Could it be clearer to use something like "contains_data" ?
--
All Rights Reversed.
next prev parent reply other threads:[~2024-07-30 18:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 12:45 [PATCH 0/6] mm: split underutilized THPs Usama Arif
2024-07-30 12:45 ` [PATCH 1/6] Revert "memcg: remove mem_cgroup_uncharge_list()" Usama Arif
2024-07-30 12:45 ` [PATCH 2/6] Revert "mm: remove free_unref_page_list()" Usama Arif
2024-07-30 12:46 ` [PATCH 3/6] mm: free zapped tail pages when splitting isolated thp Usama Arif
2024-07-30 15:14 ` David Hildenbrand
2024-08-04 19:02 ` Usama Arif
2024-08-05 9:00 ` David Hildenbrand
2024-08-06 9:58 ` Usama Arif
2024-07-30 12:46 ` [PATCH 4/6] mm: don't remap unused subpages " Usama Arif
2024-07-30 18:07 ` Rik van Riel [this message]
2024-07-31 17:08 ` Usama Arif
2024-07-30 12:46 ` [PATCH 5/6] mm: add selftests to split_huge_page() to verify unmap/zap of zero pages Usama Arif
2024-07-30 18:10 ` Rik van Riel
2024-08-01 4:45 ` kernel test robot
2024-07-30 12:46 ` [PATCH 6/6] mm: split underutilized THPs Usama Arif
2024-07-30 13:59 ` Randy Dunlap
2024-07-30 14:35 ` [PATCH 0/6] " David Hildenbrand
2024-07-30 15:14 ` Usama Arif
2024-07-30 15:19 ` Usama Arif
2024-07-30 16:11 ` David Hildenbrand
2024-07-30 17:22 ` Usama Arif
2024-07-30 20:25 ` David Hildenbrand
2024-07-31 17:01 ` Usama Arif
2024-07-31 17:51 ` David Hildenbrand
2024-07-31 20:41 ` Usama Arif
2024-08-01 6:36 ` David Hildenbrand
2024-08-04 23:04 ` Usama Arif
[not found] ` <20240806172830.GD322282@cmpxchg.org>
2024-08-06 17:33 ` David Hildenbrand
2024-08-01 6:09 ` Yu Zhao
2024-08-01 15:47 ` David Hildenbrand
2024-08-04 21:54 ` Yu Zhao
2024-08-05 1:32 ` Rik van Riel
2024-08-05 19:51 ` Yu Zhao
2024-08-01 16:22 ` Usama Arif
2024-08-01 16:27 ` David Hildenbrand
2024-08-04 19:10 ` Usama Arif
2024-08-04 23:32 ` Yu Zhao
2024-08-04 23:23 ` Yu Zhao
2024-08-06 11:18 ` Usama Arif
2024-08-06 17:38 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20df6650c834b3d2d6e5d7062876ee6a1e997dba.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=cerasuolodomenico@gmail.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=zhais@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).