From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C5EC3DA49 for ; Tue, 30 Jul 2024 18:07:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 369646B0083; Tue, 30 Jul 2024 14:07:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F2666B0085; Tue, 30 Jul 2024 14:07:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 193376B0089; Tue, 30 Jul 2024 14:07:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EE97B6B0083 for ; Tue, 30 Jul 2024 14:07:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A341AA00F9 for ; Tue, 30 Jul 2024 18:07:57 +0000 (UTC) X-FDA: 82397202594.06.12F55DB Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf04.hostedemail.com (Postfix) with ESMTP id 171564001C for ; Tue, 30 Jul 2024 18:07:54 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722362814; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/JcNkoIjgXIbHmu1R1u9w+iNWtcXvTW+cgMHsiGLfAA=; b=xhwSaBboXFuMsDeCO2NlKTwG67WQXMKynOCPSJobxM2/tvJ6UO5Pd9DpLZnUYSqNA7g0P4 YU5rJ/GUEcFJ3zykL5iZVPa5ECHy9o4VeikacxC3eQRCao9XzdLGZ7eUjK9euu5O4XAgxU pawwlC4ZPjqFXmEK5EkAyOO6X7paBoE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722362814; a=rsa-sha256; cv=none; b=HHNXKxHBuUMfN2lPvcDUxXiVgOJTYcdy46lrkYU0u2fWylfYpOQhEqMjZw/NdU4vUnukme 9aT3Bn8byvF4JVQimCvW6/xiZKGof5EL9pgjPcWkUWC1nOHHai/DVVal2jXX7kooqYLfCJ jKzVV8IJp2M6Inz7T5+l0Z+/pG/3F74= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from [2601:18c:9101:a8b6:6e0b:84ff:fee2:98bb] (helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1sYrG7-000000002kt-1i3g; Tue, 30 Jul 2024 14:07:39 -0400 Message-ID: <20df6650c834b3d2d6e5d7062876ee6a1e997dba.camel@surriel.com> Subject: Re: [PATCH 4/6] mm: don't remap unused subpages when splitting isolated thp From: Rik van Riel To: Usama Arif , akpm@linux-foundation.org, linux-mm@kvack.org Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, roman.gushchin@linux.dev, yuzhao@google.com, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com, Shuang Zhai Date: Tue, 30 Jul 2024 14:07:39 -0400 In-Reply-To: <20240730125346.1580150-5-usamaarif642@gmail.com> References: <20240730125346.1580150-1-usamaarif642@gmail.com> <20240730125346.1580150-5-usamaarif642@gmail.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33Aeo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdYdIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gUmllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986ogEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHVWjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE+BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTeg4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9 Fuy/FD/j ddPxKRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/NefO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0MmG1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tPokBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznnekoTE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44NcQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhIomYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0IpQrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkEc4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 171564001C X-Stat-Signature: f14abo4hou4jno45mm4tsf4y6tmueqwk X-Rspam-User: X-HE-Tag: 1722362874-968193 X-HE-Meta: U2FsdGVkX1/+MEfjQ9kmlH+1VzHWt0ruF2b9ZTd5ta8O8qm1C5fPrcwEWavfPwHB7F/iSUSKHkBl8OZERgFzlQqZvYXWh7YVSVLIwn907JpmCaFrQFmensyTOkEGnL/2jlmMpSrOYWiRJdHkbYIk4zyUYzYdkH3UnYSgSdEdZ1ImXI8Inw8kO2DNdft50PcSjJibRt8JwGcLfhTnq/2ooQ87Byta2cx6AbrdCpSAbGHgIkrph0m8IChpl6I9v+Df0h5gc2nTXbR1UI2sZFznDGjH3VXRY8QEiMJanO0elmCa7erPtskCRQivTYCG92bBf4tamtQNhBsQ5gCXqpzCy3bMZRPfROIxLnB3ZVoCttB9BOMFEPZOzoCFrLmd4PMQwzb7YJgbPKorzjCxFphWaM25tKvrEKuKdncZBBqAtATXEnVKVrrT2jVi88g/+02unXJOOZoE3g+5p5878tCwP9N54QNCs4wd/VoBg3U5DKAWaicQYAY81txxiIGN3JJX8ZegiKC1J/YImnPaWU0K8UmZv8tWUcOU0S5Zu+MVGWtOQLPsGNOJMsTqgq9kyn4oNG9yf58J8qSGOcLatHI77KXCVy6E9JVLegPmdFC/g+XrRib6Vpp4uy0YuFVYGX5bDqz+lxWoOdJzTVs42Mcvc0T3hLU51Iu5GOIx0GMv9aj3+KMW9XEOfPpRYionNZPBjft4cABmCjTSpJP64aDGEXz9eHDvZgrygwuACdFurCtVH1l9A9I2/WEMCHfzIOw/LTkHG7iArq2aAUB/cwTZYj6hq7THkrqX5+YUtbQcrLnHUZOZxOkSI4ORXnxZtlBPyb2U+HWk59ch1buzxNGrDJDg7FfWBPv/JQq1BY8PlaLIK+im9HAVrkpV+3YQ75ddnEIBfhiPPZOHvDZR+YB1IaKVecM5bbZMoHdQFq3rnIDdV8bwemhyAPsW8gXVotH65M5jM/5aggM6cfF8FUg StLfukac Mj+V4ixM9uw4THEuE+ZYyBOavEYnX5/EqOO/EPE8mLa/3ldRe62ePXGOIOmcIxfIrZuPfNZmsrkT8PCJBa0MaR4rK022S9KKQv+czWPqhZzoW+OpjSi9rJGTlMuCLalUAxFgXYN0Ei4kvzV6bKGNV5d1J5AdIOU/zTZByoxYkXnhJF7lsRkANL0n4LUsF9u+pdnQaT9queG1xGbnAnp1sT1C2/tGemXe6HvJFAdzKeUg+b/PPCVzHtWeOCe/PdwyhIUZhSbW1w6+CE8luw0YxXKfFKKnvkCtl0U8W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2024-07-30 at 13:46 +0100, Usama Arif wrote: >=20 > + /* > + * The pmd entry mapping the old thp was flushed and the pte > mapping > + * this subpage has been non present. Therefore, this > subpage is > + * inaccessible. We don't need to remap it if it contains > only zeros. > + */ > + addr =3D kmap_local_page(page); > + dirty =3D memchr_inv(addr, 0, PAGE_SIZE); > + kunmap_local(addr); > + > + if (dirty) > + return false; >=20 A minor nitpick here. The word dirty has a few different meanings in memory management already. Could it be clearer to use something like "contains_data" ? --=20 All Rights Reversed.