From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbirs@nvidia.com>
Cc: Sunny Patel <nueralspacetech@gmail.com>, Zi Yan <ziy@nvidia.com>,
Matthew Brost <matthew.brost@intel.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
Gregory Price <gourry@gourry.net>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page
Date: Wed, 20 May 2026 07:29:25 +0200 [thread overview]
Message-ID: <21286ae3-d8ee-442d-bb8c-fc741b9c465d@kernel.org> (raw)
In-Reply-To: <20260519150010.a1cb46f2c8478414117d6932@linux-foundation.org>
On 5/20/26 00:00, Andrew Morton wrote:
> On Sat, 2 May 2026 10:59:33 +1000 Balbir Singh <balbirs@nvidia.com> wrote:
>
>>>
>>> The issue can be reached if we try to migrate a non private/coherent folio (I assume DAX/P2PDMA)
>>> pages. Even migrate_vma_insert_page() has a similar pattern. Creating the pud/pmd/pte structure
>>> there is unnecessary (but not allocations occur, depends on pmd_none() for example), do we want
>>> to clean up all of it (need to think through)?
>>>
>>> I'll re-review and send fixes as needed. Looks like David sent some fixes out, will review
>>> those as well.
>>>
>>
>> I checked migrate_vma_insert_page() is no affected.
>>
>
> Thanks.
>
> What to do here. We have a cc:stable hotfix which is adequately tested and
> seems to have passed review. And a cleanup patch from David.
>
> I'm inclined to upstream this patch as-is and leave the cleanup on
> David's TODO list (one more can't make any difference ;))
No strong opinion from my side.
--
Cheers,
David
prev parent reply other threads:[~2026-05-20 5:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 11:51 [PATCH v3] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page Sunny Patel
2026-05-01 12:44 ` Andrew Morton
2026-05-01 19:08 ` David Hildenbrand (Arm)
2026-05-02 1:02 ` Balbir Singh
2026-05-08 11:41 ` David Hildenbrand (Arm)
2026-05-07 9:38 ` Huang, Ying
2026-05-02 0:47 ` Balbir Singh
2026-05-02 0:59 ` Balbir Singh
2026-05-19 22:00 ` Andrew Morton
2026-05-20 5:29 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21286ae3-d8ee-442d-bb8c-fc741b9c465d@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=byungchul@sk.com \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=nueralspacetech@gmail.com \
--cc=rakie.kim@sk.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox