From: "Li, Tianyou" <tianyou.li@intel.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
Mike Rapoport <rppt@kernel.org>
Cc: Oscar Salvador <osalvador@suse.de>,
Wei Yang <richard.weiyang@gmail.com>,
Michal Hocko <mhocko@suse.com>, <linux-mm@kvack.org>,
Yong Hu <yong.hu@intel.com>, Nanhai Zou <nanhai.zou@intel.com>,
Yuan Liu <yuan1.liu@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Yu C Chen <yu.c.chen@intel.com>, Pan Deng <pan.deng@intel.com>,
Chen Zhang <zhangchen.kidd@jd.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 2/2] mm/memory hotplug/unplug: Optimize zone->contiguous update when changes pfn range
Date: Wed, 11 Mar 2026 23:02:48 +0800 [thread overview]
Message-ID: <214b2cb0-e0d9-4482-956a-5bc599bae45e@intel.com> (raw)
In-Reply-To: <383e1567-0966-434e-a818-f70bff1d5220@kernel.org>
On 3/9/2026 10:26 PM, David Hildenbrand (Arm) wrote:
> On 3/9/26 01:42, Li, Tianyou wrote:
>> Hi David, Mike & Other maintainers,
> Hi!
>
>> Just a quick update: Yuan and I created a new patch based on David and
>> Mike's code, updated the documentation as well, performed the
>> performance test, double check all the references etc. We observed a
>> slightly performance regression, not sure it was caused by the
>> environment configuration or we triggered some unexpected behavior. We
>> might need a bit more time to investigate. Will send out the patch soon
>> once we have confirmed data for the performance regression. Thanks.
> A performance regression would be rather unexpected, unless we somehow
> don't ever set zone->contiguous=true any more :)
>
> In which test / code path did you observe a regression?
Sorry for the late response, I missed the email by accident. The test is
simply hotplug and unplug the 256GB memory, the time became 3s instead
of 2s for some reason compared to previous patch. Interestingly, for
512GB memory hotplug/unplug, the time remains as 6s. What we planned to
do are: 1. double/triple check with the same and other servers; 2.
collect the perf profile to see what is the diff compared with previous
patch, if the regression consistently persisted.
I will work with Yuan on this and hopefully we can have more information
to be shared here soon. Thanks.
Regards,
Tianyou
next prev parent reply other threads:[~2026-03-11 15:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 16:37 [PATCH v9 0/2] Optimize zone->contiguous update Tianyou Li
2026-01-30 16:37 ` [PATCH v9 1/2] mm/memory hotplug/unplug: Add online_memory_block_pages() and offline_memory_block_pages() Tianyou Li
2026-01-30 16:37 ` [PATCH v9 2/2] mm/memory hotplug/unplug: Optimize zone->contiguous update when changes pfn range Tianyou Li
2026-02-07 11:00 ` David Hildenbrand (Arm)
2026-02-08 19:39 ` Mike Rapoport
2026-02-09 10:52 ` David Hildenbrand (Arm)
2026-02-09 12:44 ` David Hildenbrand (Arm)
2026-02-10 11:44 ` Mike Rapoport
2026-02-10 15:28 ` Li, Tianyou
2026-02-11 12:19 ` David Hildenbrand (Arm)
2026-02-12 8:32 ` Mike Rapoport
2026-02-12 8:45 ` David Hildenbrand (Arm)
2026-02-24 7:15 ` Li, Tianyou
2026-03-09 0:42 ` Li, Tianyou
2026-03-09 14:26 ` David Hildenbrand (Arm)
2026-03-11 15:02 ` Li, Tianyou [this message]
2026-03-11 16:19 ` David Hildenbrand (Arm)
2026-03-19 8:28 ` Li, Tianyou
2026-02-09 11:38 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=214b2cb0-e0d9-4482-956a-5bc599bae45e@intel.com \
--to=tianyou.li@intel.com \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nanhai.zou@intel.com \
--cc=osalvador@suse.de \
--cc=pan.deng@intel.com \
--cc=qiuxu.zhuo@intel.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=yong.hu@intel.com \
--cc=yu.c.chen@intel.com \
--cc=yuan1.liu@intel.com \
--cc=zhangchen.kidd@jd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox