From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3165FC433EF for ; Tue, 7 Dec 2021 17:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC3E06B0071; Tue, 7 Dec 2021 12:14:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A72816B0072; Tue, 7 Dec 2021 12:14:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 913846B0073; Tue, 7 Dec 2021 12:14:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 8515C6B0071 for ; Tue, 7 Dec 2021 12:14:12 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4616E8249980 for ; Tue, 7 Dec 2021 17:14:02 +0000 (UTC) X-FDA: 78891645924.24.EA7FD63 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id C91EF10000AC for ; Tue, 7 Dec 2021 17:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638897241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=COjwenkxm8hGw0a/Dri2jSsDB5SQ1RS6CEtMSB+/ozY=; b=c1ifsPF34s+jREXvyx+5lbluYDokFP7kc+syw9QP0RF6B4TnO0DjtJ1wgEVcUw0pY0rbzd NGgw4a1NMYuMkvFo6FnQFvkPcIA4tUApAc68JRGgBRG2b1QQ6hPe/1mhMusmrNzL0EOx9C UEI1FhjQcBwDLsx1oWYGEJm+aN9epYw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-238-WdvPO4zQO8ulJXZKfjhgvw-1; Tue, 07 Dec 2021 12:13:58 -0500 X-MC-Unique: WdvPO4zQO8ulJXZKfjhgvw-1 Received: by mail-wr1-f70.google.com with SMTP id q7-20020adff507000000b0017d160d35a8so3214582wro.4 for ; Tue, 07 Dec 2021 09:13:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=COjwenkxm8hGw0a/Dri2jSsDB5SQ1RS6CEtMSB+/ozY=; b=Rmi++L8XJ8YOSxyrfMKmkQOx08tCTy74XQuF9cc509+9EMIuwhmDARBuwwPsaEerrB Q5ve/+nTQzdYX/lYMhYawOGj7VZnYunrj7QKqe/6L+lTGM9x5kU44EGN6x1zH+O58l9t cTW3D+5UAaxc2MXDQW7/Emibo+dugMeY3LZNZJz8LiR5aibRJ/UZuNVKFWoa8rA5uDcN 7s+hNPzWNVCDrQMgMIK64pNA6Q45WAEQWMVp14+E+CpKUsAmCC5tngM6Q8C2sjl9X1Ad j+N3Fbj/5XKNig0YtByCvBRfnphIsYQEUhnCDPDeQn4NEe/Ykmtyf34eYkbohpsboHmL Lo4g== X-Gm-Message-State: AOAM530hCcclTSLUEGEqup6psvovSf99iWjcvBT9BEIrCPDIGvWGdnP5 pqU9Gtf29NIU+/hQRjyKHhDDYSsousuWJTwQnYzQ7mFjildb1ebP3CJnEaZh9LbfwYY8b5YaexZ 0zQt6Htu7DnY= X-Received: by 2002:a5d:69c5:: with SMTP id s5mr52069886wrw.283.1638897237001; Tue, 07 Dec 2021 09:13:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCJkHHVGi9mxMYTS+DiyWjrvsVzRsKQc/2NJz+8bbKe4P0ECvPXyPr8uhORN0NXaxXbVLPDQ== X-Received: by 2002:a5d:69c5:: with SMTP id s5mr52069854wrw.283.1638897236754; Tue, 07 Dec 2021 09:13:56 -0800 (PST) Received: from [192.168.3.132] (p4ff23e57.dip0.t-ipconnect.de. [79.242.62.87]) by smtp.gmail.com with ESMTPSA id d2sm3516059wmb.24.2021.12.07.09.13.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 09:13:56 -0800 (PST) Message-ID: <21539fc8-15a8-1c8c-4a4f-8b85734d2a0e@redhat.com> Date: Tue, 7 Dec 2021 18:13:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3] mm: fix panic in __alloc_pages To: Alexey Makhalov , Michal Hocko Cc: Dennis Zhou , Eric Dumazet , "linux-mm@kvack.org" , Andrew Morton , Oscar Salvador , Tejun Heo , Christoph Lameter , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" References: <1043a1a4-b7f2-8730-d192-7cab9f15ee24@redhat.com> <77e785e6-cf34-0cff-26a5-852d3786a9b8@redhat.com> <2E174230-04F3-4798-86D5-1257859FFAD8@vmware.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <2E174230-04F3-4798-86D5-1257859FFAD8@vmware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=c1ifsPF3; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C91EF10000AC X-Stat-Signature: 4fnwxbwth8zaeiaj6fyid3qxfedshq3c X-HE-Tag: 1638897241-515840 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.12.21 18:02, Alexey Makhalov wrote: >=20 >=20 >> On Dec 7, 2021, at 8:36 AM, Michal Hocko wrote: >> >> On Tue 07-12-21 17:27:29, Michal Hocko wrote: >> [...] >>> So your proposal is to drop set_node_online from the patch and add it= as >>> a separate one which handles >>> - sysfs part (i.e. do not register a node which doesn't span a >>> physical address space) >>> - hotplug side of (drop the pgd allocation, register node lazily >>> when a first memblocks are registered) >> >> In other words, the first stage >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index c5952749ad40..f9024ba09c53 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -6382,7 +6382,11 @@ static void __build_all_zonelists(void *data) >> if (self && !node_online(self->node_id)) { >> build_zonelists(self); >> } else { >> - for_each_online_node(nid) { >> + /* >> + * All possible nodes have pgdat preallocated >> + * free_area_init >> + */ >> + for_each_node(nid) { >> pg_data_t *pgdat =3D NODE_DATA(nid); >> >> build_zonelists(pgdat); >=20 > Will it blow up memory usage for the nodes which might never be onlined= ? > I prefer the idea of init on demand. >=20 > Even now there is an existing problem. > In my experiments, I observed _huge_ memory consumption increase by inc= reasing number > of possible numa nodes. I=E2=80=99m going to report it in separate mail= thread. I already raised that PPC might be problematic in that regard. Which architecture / setup do you have in mind that can have a lot of possible nodes? --=20 Thanks, David / dhildenb