From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E57AC83F1A for ; Fri, 11 Jul 2025 10:51:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01B466B00A4; Fri, 11 Jul 2025 06:51:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F34D36B00A5; Fri, 11 Jul 2025 06:51:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFCF26B00A6; Fri, 11 Jul 2025 06:51:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D08036B00A4 for ; Fri, 11 Jul 2025 06:51:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3F06912C160 for ; Fri, 11 Jul 2025 10:51:32 +0000 (UTC) X-FDA: 83651667624.22.896E15E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id D667020013 for ; Fri, 11 Jul 2025 10:51:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SHoMR2mh; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752231089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q8VBQiFLT//EeYl3ROmP1EwYI9fSpWGAhPvrES6B45o=; b=C5g1N1c98iSMg3bZqQDvrD/uXtiBnht0kgSqEpmnXOGAtuz7ii8Ro2JqpR/N5TK0K//goy pGhvOU67foRT5uaqm0snEyQ2bw2VzX3lTzWIk4+2UvZ3fg86hAQDoqhWWX/tZYcNMxux12 PpPDd4AbxfUu5oOqsN6AFQt1PzUikvg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752231089; a=rsa-sha256; cv=none; b=SaXSObpAb/Jaz9RmxFJ6zfCBEa5FKLZR05wofiOCvteFVcKcuLy4A6CUhr7A6pLCxxiHwe cPXcbcikJ0Cc4JBDW4brUNKeZggtVCnTO2eesC7zE1r9v7Qz6WoQ8LJ5RbHSVWRCK1ABJW dcphYXII/fZMhmTUmnoQ588dQxjxzYQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SHoMR2mh; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752231089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=q8VBQiFLT//EeYl3ROmP1EwYI9fSpWGAhPvrES6B45o=; b=SHoMR2mhm0plO9sWIBwjOTjU/k5MDyR7G3N66zxZ5u4yVKWEA/+2htDTdOW/qAiqY5c5Bn o1bczRRU2Fip7VNwqyJ66fR5eWA1zx2nyBQeaT5JseO0u5x7du2Pxfg/10AarTZFDsnQP7 RSgBqM32dcEElyDCvF/2jjdofNL+PpU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-cNh3E5RDMJuYz0uG21QUnQ-1; Fri, 11 Jul 2025 06:51:28 -0400 X-MC-Unique: cNh3E5RDMJuYz0uG21QUnQ-1 X-Mimecast-MFC-AGG-ID: cNh3E5RDMJuYz0uG21QUnQ_1752231087 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3b20f50da27so1445399f8f.0 for ; Fri, 11 Jul 2025 03:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752231087; x=1752835887; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=q8VBQiFLT//EeYl3ROmP1EwYI9fSpWGAhPvrES6B45o=; b=XQdXgnHPehOHEPqDrGImcTn2Mz0FCO9ZzSsRFK11pb94S4JswqFhIsUG80npeBTCxD cRAyO7I8CFgVOQ3djfNbUwAxPvEA2zFAirat5CNfpmrBVakallcS/Zogolz4fV5kIGJc mdx8JFHmi8fcJ9xDlUIb+YbYgiSyOizz2aEOhia1mfFBN6Og+NnxhT/kTmnHdYNPhTEw 1dvdQyjMfKz4ogyrQtj0Bz6Edd18x15SZ3h8RflRJ0BQh2wLvUKGsUdbwq3KVTdwi7vs 5HDnjUQwMQJyUrg9OicKEB/NNoh/mRmPMRCs6ga/UsUOiMUN1GpsktzJhifWcw49f4I0 AmHw== X-Forwarded-Encrypted: i=1; AJvYcCWZyuFTDK8hJBLr3l18APiePBSko1/TejuVG/+i7nfvwl+YsXWSx6sozFbhZOMlV2rdTDKgAJjjyA==@kvack.org X-Gm-Message-State: AOJu0Yziw5oIKj9KKGL3TvsMnCaXjqA+fmBjE8+V3xYFQdqJelCi0xol ZHcJaiMymyPspCm5S5/46I1YV41K1nSGgdvMuANHupQIFSgMTTtSFaJsdKNuCyZjUxclsGlF4Fg Y6uZZ3iy8mRCZrFp4gNOAm3jrz8C+vcYwK6QWPQ6ZUWXuwaDjhHGh X-Gm-Gg: ASbGnctAKnCNKzdO6XAyBi1VJAGFxleS/8DhXf+qGmI24pv6/8q8XISiuhfAWeZ836C PqR103qYgULrDm8U/pwOV960C8tYFf8R+FR9HazjhKxphluFZF4OsEEkxzEVwIm+ILT9nX900Go Eax/kvcX8HlM3NQeHGdfNqIMHEJtjw1gl6OCDFQRwKJ2So6Ja6IFpBu/+cCTN6uLlmKYxkNs3xr N7Uafp0KatZ0FFrHlkRcCNgIQRf0pQjHUIu9EiDOERdAIKO/WGEEv1CHruLGCC7QL//MWxuUPbj DEyODf+9GHec3Zoii8e82doNGE6Apq/8a8dqH40qYjGJJktDyfrZ2GNDJSbzfOdMp4i0iQg6gWr vhTcz2cB7l0qNtELeMg745/EyvOP3Kw+D+lqdTNil1VePJJMgQlF+0sr7dgoa7JNtZo0= X-Received: by 2002:a05:6000:230c:b0:3a4:f7ae:77c9 with SMTP id ffacd0b85a97d-3b5f1c67bb3mr2296089f8f.5.1752231086770; Fri, 11 Jul 2025 03:51:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsGS5dc3KDbynrDW47+++kkEuKHhuStoQal+N9lYCQvCANPyj0LCXBNA1BlZsqbPtddyKJjA== X-Received: by 2002:a05:6000:230c:b0:3a4:f7ae:77c9 with SMTP id ffacd0b85a97d-3b5f1c67bb3mr2296069f8f.5.1752231086371; Fri, 11 Jul 2025 03:51:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0dbddsm4193594f8f.63.2025.07.11.03.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 03:51:25 -0700 (PDT) Message-ID: <21d6b420-c8df-4a48-8b47-ef06135a4d1b@redhat.com> Date: Fri, 11 Jul 2025 12:51:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm: Remove unmap_and_put_page() To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Jordan Rome , Andrew Morton References: <20250709194017.927978-3-vishal.moola@gmail.com> <20250709194017.927978-6-vishal.moola@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250709194017.927978-6-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lhGnRod8HggW-iHIEhXkDgIxbo-MSr2JbTC7mI9CsxE_1752231087 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D667020013 X-Stat-Signature: dibs1crmd3pebhw5cmt4knmsqwpf4ipi X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752231089-985916 X-HE-Meta: U2FsdGVkX1+3e83Bx28ZMiHKtwx1xtB7+fEN+TUGggj+yHPjRGyWg5BMZYqm6Pn+TgHHPxI1J+lbajxBqCsUTIgdfDmPC/XEuIifuXfNi//OV/nwksNyiVhNG2DHsS6RraFHnsZpFJFQpgop7PHFtkvazDoBUEoQlKmpHcYMBWYrmY2CHSNGcLL9Bqw/1fGdwAJugjmCLCUr0OMDrq4b+cXCHD4JspBD7flzufakIeJHUFUseYc3B5oy5TTLAVgriu6KB6Nzfw0Jc4GDcwNC1UU0cCri8CYrzYnIR5IyusUiWH0V7wZ4lvQgsD4B1m50YLajeZaqh8y4XBhMnWYtM6m00xnJJ9tCOE6PZIZuL4Sv9DlSBs3FEj/B9EZOuHlOtIDqGB1h3fPA4/bL/xCTSLhUnbvHqt6dkDzEP+KyunsiGnyEP2kmShqnCPPOK/9MWhhkMAi1yHs/8Z1xjTuS59demC46ahjUYccdeF/aZmN7ygjBF5fzVrHTPv22LoqIU9h7SDPGfwzstop+NA/FGAB2+YQubxkvL41fJt8j31obgyTr0TQlpGH80sq0UYneaiIfbs/diEvEY1nwhXHhHF2tKVUNhKTfhB2AGLcqr1/oW1G0Mlg99Sl0gYuHw3jserDHGWd8tz5Kl9IiArKRTXHBMiS/Xvyxavj12g+Q+tsBPocXpOoXAciSYp/GLL5fuuJjv8QCO0Vi1XZa3+Vz3jjKoOhhczitKR8B6FInxOscetNoMG7MycGpqdk/FTW6o5TGxXhRu5Br0WnD1LL3uhHnkvnv3feeldmjsxz24TwrnOX4qRcbEAnHQT/j8CGsBr28IQBdIkTewd7ed2MjHaxa29GDe/LxJmCbZYKyT9lwUgiEtAqWHOIulv4BxNlJU2qVxBOmv2HxExcpu4MhGtE+M8cd17FN6G1x2XoUQbCjAxOYXRmRcLhpUsyPYUCHEcMkR/xiKDOz16Hwe4u XPJbl89A nM4EgMWG64QDgrhbcEXNDSnSAokcbPlcA/z2FDmJgtuChFsW172/IxTUqdxY1rAQDif7c7dq9gP8EYJoOBEhdWUk+qWQ2Dhk0OqibXCsHrtWZC6IbmAAd4yZruGBVWlqDfPjloazwvdsGyFljOtB40UzjJZoNU91VymOf0Y8k4CXYaAo6oRdnyuA+YykrPLNffWARFlPRxfivTj294y0UMxMRGI3MezIOI5dmrPcjECrXYonPeRwtu9gfdPAaq7Wnk3YU8rnpjuxGesG+/2upGaAt9fQZ+RmX4RoZxxXWCI5kyvov0Vt7e20kHimMOlnlbY0CT8NZfSb0wQSgUqv+X1q/uemAnDUrZtPH5KbG97e54i9/kE9shg/yVejIxJtDPRh8iwFOefkVkjcFKvhy3ak8Au/BQ9rJcdGwFuMJhUQRAdZXpSLcslISlz5b4g9U648nK1HVYNQBeull/uMSXfmT2z5WJTp+DpruTayMCkg4WL7u9ROvxYM1Bpe/NfixHuERJU6wSqmqIuBDIAjjgQ+B0etAg/tWxYpmT2IgHrLdwagqFNXoRrrsxNLDZASLgHh8D9iH10G/keVhfmXscie4Igej1tEYXvOEO/aEzKBCI8EZ/Gr9Fd8PPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.07.25 21:40, Vishal Moola (Oracle) wrote: > There are no callers of unmap_and_put_page() left. Remove it. > > Signed-off-by: Vishal Moola (Oracle) > --- > include/linux/highmem.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/highmem.h b/include/linux/highmem.h > index a30526cc53a7..6234f316468c 100644 > --- a/include/linux/highmem.h > +++ b/include/linux/highmem.h > @@ -682,10 +682,4 @@ static inline void folio_release_kmap(struct folio *folio, void *addr) > kunmap_local(addr); > folio_put(folio); > } > - > -static inline void unmap_and_put_page(struct page *page, void *addr) > -{ > - folio_release_kmap(page_folio(page), addr); > -} > - > #endif /* _LINUX_HIGHMEM_H */ Acked-by: David Hildenbrand -- Cheers, David / dhildenb