linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Alexander Potapenko <glider@google.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Tony Luck <tony.luck@intel.com>,
	linux-kernel@vger.kernel.org,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: Fix two spelling mistakes in highmem.h
Date: Mon, 09 Jan 2023 19:09:46 +0100	[thread overview]
Message-ID: <2269967.ElGaqSPkdT@suse> (raw)
In-Reply-To: <Y7cCprZBVrNO3aZ9@iweiny-desk3>

On giovedì 5 gennaio 2023 18:02:30 CET Ira Weiny wrote:
> On Thu, Jan 05, 2023 at 01:13:05PM +0100, Fabio M. De Francesco wrote:
> > Substitute two occurrences of "higmem" with "highmem" in highmem.h.
> 
> The change looks fine but for Andrew's benefit I believe this patch is based
> on the other one you submitted to fix kmap_local_folio()?[1]  Is that
> correct?

Yes, it is. 
I had completely forgotten that previous patch.
Thanks for noticing it and for providing its link to Andrew.

Fabio

> 
> [1]
> https://lore.kernel.org/all/20230105120424.30055-1-fmdefrancesco@gmail.com/
> 
> With that note:
> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> 
> > Suggested-by: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> > 
> >  include/linux/highmem.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> > index 7b0085a61e67..ae1670ccdf45 100644
> > --- a/include/linux/highmem.h
> > +++ b/include/linux/highmem.h
> > @@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
> > 
> >   * virtual address of the direct mapping. Only real highmem pages are
> >   * temporarily mapped.
> >   *
> > 
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> > 
> >   * comes with restrictions about the pointer validity.
> >   *
> >   * On HIGHMEM enabled systems mapping a highmem page has the side effect 
of
> > 
> > @@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page 
*page);
> > 
> >   * virtual address of the direct mapping. Only real highmem pages are
> >   * temporarily mapped.
> >   *
> > 
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> > 
> >   * comes with restrictions about the pointer validity.
> >   *
> >   * On HIGHMEM enabled systems mapping a highmem page has the side effect 
of
> > 
> > --
> > 2.39.0






      reply	other threads:[~2023-01-09 18:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05 12:13 [PATCH] mm: Fix two spelling mistakes in highmem.h Fabio M. De Francesco
2023-01-05 17:02 ` Ira Weiny
2023-01-09 18:09   ` Fabio M. De Francesco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2269967.ElGaqSPkdT@suse \
    --to=fmdefrancesco@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=glider@google.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tony.luck@intel.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).