From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB37C3DA64 for ; Tue, 6 Aug 2024 12:02:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B7EB6B007B; Tue, 6 Aug 2024 08:02:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 967CD6B0082; Tue, 6 Aug 2024 08:02:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E15C6B0083; Tue, 6 Aug 2024 08:02:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5CC786B007B for ; Tue, 6 Aug 2024 08:02:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0C91FA632D for ; Tue, 6 Aug 2024 12:02:45 +0000 (UTC) X-FDA: 82421683890.17.B65636B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id AC0DD40023 for ; Tue, 6 Aug 2024 12:02:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uc64VMLE; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722945713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rfRkYxe/SPAMiYh4vQI2fbfDI6Yat+EMEMpDOx9VDW4=; b=xPejRjgiqb2QTjXvyLNsXtL4YXiJT5Vwv6E2SJUgMZaF+1xTWvOuYrUbUfmJ91BtNKNBP2 thkw6p69jPjN3uiJg+C7FKW0nd7o9tpeDrZtQElCMd486fg1mB/gh8GwB/pSaFSeTgHocX 0uE5u5kJr+QsFpBxom0pGV9LB14hW/M= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uc64VMLE; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722945713; a=rsa-sha256; cv=none; b=58UmErjj8rWRmO1gVvc10twfJKSp1U68FJw/ghiOdN8slajfpncPVQHp59tC0QpylOvxgG Dmu9rvCCTg1HOGRDGw2rhTZSkzMdLdnS2LKF4lqf4iiYz/SNHRQ6bqe+vPC5ee9cfNPYJb X/junWX6c3/1t+gjLAhGmDKHiPtmXY0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722945762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rfRkYxe/SPAMiYh4vQI2fbfDI6Yat+EMEMpDOx9VDW4=; b=Uc64VMLENaGDt4CI9YC0UAeKEGa1pjupbbDGcY9cnxZsp4cA35mzxM6QAuZpwgeA6Ek2ty JJoxO3gzvAyhVIKLOoxiHDD9FdI1FltVhHd/MvLtiqv3BuUL54FtH77M5itnn7a+jsiNl7 e3iuUas+Wn/hZFQx9pUxWlgBL8gdku8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-QdxeM82OOH-f39_j87StJg-1; Tue, 06 Aug 2024 08:02:38 -0400 X-MC-Unique: QdxeM82OOH-f39_j87StJg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3687f4f9fecso441061f8f.1 for ; Tue, 06 Aug 2024 05:02:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722945757; x=1723550557; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rfRkYxe/SPAMiYh4vQI2fbfDI6Yat+EMEMpDOx9VDW4=; b=Rj5THVSi7BfWvFZvvhUBmotVxjR7jBiVywms5V7ETSCtccQTyUOnnldIGZWxPB9w/Y onXznn79GBKrYSBKqT1PiDKg+NKvD9KmQmol/HH6ZNQOPjpldfjxdH7NqS57U8j+orn8 aeppO/aN3ke/VJKg7VKv5+u/TRAkmjoLuMadK0ty1SD/OCobJoDk1WHmHbkGuRuAEwGz bgkYyBVWIZRwDWfVFbmtO0NxdSYEr1cfrAeTZC6yK6FIZLZqQ1mzietNTj8mEoHUy6PT XpHi/CwvG0J2hfCEtWevugHZmydHeM48EnolYD6s+pPNBLrnAulgST+v2PhkHsjE6E4A LdFw== X-Forwarded-Encrypted: i=1; AJvYcCXXNT9yHYfQxRQv7hmMM4ZISSkzfvjHdapm9VAmgsZQDMgswzPIiRrqUyPWkkf2J/9aynfaAf9ftOK7IumhzXLXWj8= X-Gm-Message-State: AOJu0YzTe6dC39UoDXhyFw48R6+aS8AI1aNQFDM7xAcPhnbtAr8UePZQ OLct4u7vCJ5h2zVCdcpGScRsDT2Jq9Bs4gRTsF11XK2+HsSb7VkvfpIpksUIieU3evctAPMmHxL we5bR8ZrV8oclrE8pt3yQncw54gyULGOfoCzmASWp6NsFhG/h X-Received: by 2002:a5d:568f:0:b0:368:6b56:641b with SMTP id ffacd0b85a97d-36bbc1a6754mr13444201f8f.47.1722945757391; Tue, 06 Aug 2024 05:02:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwjm93au6XMoF3owRpkCyFW+Prx88RdvN7jmkNLtTQhqujQ1NAs/T2s3CwdeRT2LuWx5QtGQ== X-Received: by 2002:a5d:568f:0:b0:368:6b56:641b with SMTP id ffacd0b85a97d-36bbc1a6754mr13444165f8f.47.1722945756917; Tue, 06 Aug 2024 05:02:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:8500:f83c:3602:5300:88af? (p200300cbc73f8500f83c3602530088af.dip0.t-ipconnect.de. [2003:cb:c73f:8500:f83c:3602:5300:88af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428e6e9d1fcsm175829175e9.42.2024.08.06.05.02.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 05:02:36 -0700 (PDT) Message-ID: <2276d983-cb01-4a28-9f12-13ac924a7248@redhat.com> Date: Tue, 6 Aug 2024 14:02:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] mm: Accept memory in __alloc_pages_bulk(). To: "Kirill A. Shutemov" , Andrew Morton , "Borislav Petkov (AMD)" , Mel Gorman , Vlastimil Babka Cc: Tom Lendacky , Mike Rapoport , "Matthew Wilcox (Oracle)" , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240805145940.2911011-1-kirill.shutemov@linux.intel.com> <20240805145940.2911011-3-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240805145940.2911011-3-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: bhy96ezzdfmxhpf3sothqo4fardrbzt1 X-Rspam-User: X-Rspamd-Queue-Id: AC0DD40023 X-Rspamd-Server: rspam02 X-HE-Tag: 1722945762-50617 X-HE-Meta: U2FsdGVkX18ZmHtfghoqi0RvofEnrNH3DUiaAi/576+UqUIhhx5iEk/G9Mf19ATFmYGmVSFzY+MXEhroRJHgiw0pSSyiE32w1iUYB7kH9JJmLsmso9sDglTkd4RL4hcz6hdvA0HPgqDEodPBYJvy+Cpx0wPnMUl4tAs0OPRg3XwObY1VuxzmgoDvpcF9J8O/Fghs4LLqTuEojSK4Dwq7ms2vHthTxLyBZpLq5jyQs+M84uoRr4T0Lw6XEysCxXdyzcFIhiMazu+wg7xkrmSmAckn5DFvSKZWkSN2/UJdALWRNWrvaAIJdH6AwJD0rMA1tTUG33jjQ8BM/nBcMCStf30ce9aQWRqourXFijQopCB58bgB+WpqDPgP3XMlys3BPPlYDnAQS29E9NaFA9V3hONMis+vKLXDchZ9ATrSf6CKZ+W9vChc7mqVrIk8jvbcD+K2bNBur2fo5ubcOAW9HdClZVXS3t3ZMQTW/wev/DbK3Uci4LhJFEHMdoeyWKAblmo7Q2pGrxD8VuW2ryGsx6KtmJRF8Q0liBOBGJN+AFulK5ERQ+vtEy3L0qFbpI7PVUImFgWuvUXBX4v/QJZMUu71siS+4giVpaVkzkeen5EWRc7dL77i6XyxOXU+Kt3mYFsRnZny6uwPYSHd/1fTEYwiIxrOY5SJSg7EZHAJOAOgbP2PEnd0JkhbdfjLQxg/85vSUxCACG0uoxfDDAh8/mCOUR2G9YT1+U2444J8v81AqNt2UW0t/wNUzyNToVxkAOqgjQAkaMcZBdf3Im9TlHYeBPvh926wglaQspVv5ZogsY7lKzOiorw6KaMQ2LOS/5+wTrxCU3mLL1LH2J006W0h01kFc3c5k0MfK3hv6dsEJoD3JQJsTeD9uLfmU2bslIy14XXApzy6doxLYUK2vmBwEClaJw91RsMsceb5hXMBZTl3qRENOks3XNQ2Qsc7cq6VikxzK1eHh8KEarH LH52Kf+9 dRuHSiCejQ53FJhZcMbLyOVS3DGmgMVL7+Q9Z4sJjIN6bY5ZVymk3/8qq76JOMRgfT6LGmD8r1GuqeaJTSzWYOsgfJMV65V0fkF95VHPH0h+j43SkbqejYTHqM2hAJgcXeR4pLDLgMF/KEG0ZFnzXha9XXdc6qnQEFfFx5i8YujngvB7m5L6U27TGxhgVW3qvFfJkQFMYi0gVNmRpHpX2Mx8pkodW383gq1AZZUuY/n2zjvPNt78TTp+pPMz6RAAvmjpZGZTf1F53YEdhylaJAqUPOsoxEw48rbTjIA0ROCQKwhTzoAVseZeMOkfkCrrr8hVBpTMcpVYcOciaoeV8NgK47S9Lhf0a8IiEOQhpgiZLTA+vyqtVgmcx1lnEzfyd1nqCr59SD1vDnTTOX4eYQk6HtFaV143DmXy3m9Fcu0bguXtH74vuLaQOO91kXiBXbTx1ECA3ReSB9PZKY2OC4GZvOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.08.24 16:59, Kirill A. Shutemov wrote: > Currently, the kernel only accepts memory in get_page_from_freelist(), > but there is another path that directly takes pages from free lists - > __alloc_page_bulk(). This function can consume all accepted memory and > will resort to __alloc_pages_noprof() if necessary. > > Conditionally accepted in __alloc_pages_bulk(). > > The same issue may arise due to deferred page initialization. Kick the > deferred initialization machinery before abandoning the zone, as the > kernel does in get_page_from_freelist(). > > Signed-off-by: Kirill A. Shutemov > --- > mm/page_alloc.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index aa9b1eaa638c..90a1f01d5996 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4576,12 +4576,25 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, > goto failed; > } > > + cond_accept_memory(zone, 0); > +retry_this_zone: > mark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK) + nr_pages; > if (zone_watermark_fast(zone, 0, mark, > zonelist_zone_idx(ac.preferred_zoneref), > alloc_flags, gfp)) { > break; > } > + > + if (cond_accept_memory(zone, 0)) > + goto retry_this_zone; > + > +#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > + /* Try again if zone has deferred pages */ > + if (deferred_pages_enabled()) { > + if (_deferred_grow_zone(zone, 0)) > + goto retry_this_zone; > + } > +#endif We could probably avoid the #ifdef if we add a dummy function for _deferred_grow_zone(). Same applies to the other similar users in this file. Acked-by: David Hildenbrand -- Cheers, David / dhildenb