From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F36CD4857 for ; Wed, 4 Sep 2024 18:01:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F35FE6B029B; Wed, 4 Sep 2024 14:01:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE8106B02BE; Wed, 4 Sep 2024 14:01:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5ECD6B02BF; Wed, 4 Sep 2024 14:01:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ADFB46B029B for ; Wed, 4 Sep 2024 14:01:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 59D2D1A179A for ; Wed, 4 Sep 2024 18:01:56 +0000 (UTC) X-FDA: 82527824232.16.51272DB Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf08.hostedemail.com (Postfix) with ESMTP id 3EC9A16001F for ; Wed, 4 Sep 2024 18:01:54 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=hVyT7EVf; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf08.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.45 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725472890; a=rsa-sha256; cv=none; b=vuV0PdlNfwjossZBz2vrKsLc9ZCIVIS7O1P1uQdWf4FiJ9P7xtfLdZ6uHYlyHjCii+RQj/ Tj+OIAivA+K297m3MJoZ8AXdvqmhcNNknrjBDYt+dIS7qJwCmb6PAEHwa650oSuucTR2EP nqmHsIkif4pj+Lflp3DfNqYuPWsDsE0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=hVyT7EVf; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf08.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.45 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725472890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DtTeYjj02Mtv2WzzkSyeLasv4f+WjuGZCMl+K7JYzM0=; b=Dl9jeXg4n9L9EeB9y6B6i38okHhZrgPFAo0LLWZBh37q5a7f0uJShh7UxRbXtq3uQjtWEk GhN9CvDjEkzlSavjTMUk79qGAfY0dyrxXlKBLnLeVyf/c8MtWSAYMqM5gV19U/so3L5eFK E8yD10MVwt914MS6oCSbum6Q65p0Iug= Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-82a1af43502so353452639f.0 for ; Wed, 04 Sep 2024 11:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1725472913; x=1726077713; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DtTeYjj02Mtv2WzzkSyeLasv4f+WjuGZCMl+K7JYzM0=; b=hVyT7EVfQWhhIeiC6faaGFG2B9OYSRqrM5vUbf9h+BjfDRF3z1+7mfUO2RPkNuz+HU WReLYYMEWvmnC7CsvqhsJqobRFHjAyDqNND7zkmTr6ByIpHsgcBG/hI718YidJlsOUMJ EyoOogTfDZWEG1q3CLmaqk/8pG2zP6gbbNR9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725472913; x=1726077713; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DtTeYjj02Mtv2WzzkSyeLasv4f+WjuGZCMl+K7JYzM0=; b=R0pOrT8jsbDQxfRMujoBOMdAU2Tv1sSu6F5is1kL07JDr7KjGrlOFgVcBoLsyRsDy/ WmCUnZEOdvuH38JU3QX7YFSiG5YQ1wPkVI71Mvvpjuk6mytm7q5Sg3epjr9EZBVqSlXP j1rraQwgkHT7+Hh0Mr8v/7lYWbCn6C9bJMvRaLAsg44t1pLY7yyCEjRXVrN4klbGbBvJ LaZ+mEyg8B9GiZHSdtjHQHtQp1Ds7Izc63NNDh4qBl5mGs0M1UP/JqiSv14GyRrPn0f9 Wk3EVFoGXqEAL4P4j3VX8exaXj28m1TOjHxaPiXGpW6V4Y9LtjmjcTNiwIXpfhgYSAvY TvoA== X-Forwarded-Encrypted: i=1; AJvYcCXL5uX4HeyZ1jppXdaafpgcHd5fqnxxFRLTazfZAxPMKD/sxisex2gshKcZbbIEsbWSncH8ERkY6A==@kvack.org X-Gm-Message-State: AOJu0YznkGMVz+4YVwWG+q5uAR+rXpWWtr5ILSHYUbcpPotecRrNW0TH 8dNvGKmWRq7aqc8tC4aUoKPjXT+n4DAPmVA0Oym2VMuU1EK5c+cP4SIlaf0NoFs= X-Google-Smtp-Source: AGHT+IE09d+IBeWwgHe5zjgeYzKqlOeVFBKdTyoUXo2CmM5mem85ZvAmg7ax8y1cyKmmP1BgZ4kZOg== X-Received: by 2002:a05:6602:60c7:b0:807:f0fb:11a2 with SMTP id ca18e2360f4ac-82a11094588mr2605807839f.13.1725472912591; Wed, 04 Sep 2024 11:01:52 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-82a1a49897bsm366616139f.37.2024.09.04.11.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 11:01:52 -0700 (PDT) Message-ID: <22a3da3d-6bca-48c6-a36f-382feb999374@linuxfoundation.org> Date: Wed, 4 Sep 2024 12:01:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2 v2] bcachefs: do not use PF_MEMALLOC_NORECLAIM To: Kent Overstreet , Michal Hocko Cc: Dave Chinner , Andrew Morton , Christoph Hellwig , Yafang Shao , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , "conduct@kernel.org" References: <20240827061543.1235703-1-mhocko@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3EC9A16001F X-Rspamd-Server: rspam01 X-Stat-Signature: a953jr5yb4ikpfqfu4rb8bmxuefwezwu X-HE-Tag: 1725472914-28978 X-HE-Meta: U2FsdGVkX1+RtclbHvioiJE1Z9izoCWrT8VNZeyBwpGlfM9N+/EPeug32HZs41lWFddGv+eN2XJe8dfu7lNvOpkcaReV0K3pWmhJSwargtbvpm+dIJF4jogyToS842XQecTUxfv4qsAyLf2TEmb2OndX7bWY0lo2vb6O4bpDe6VhVPFe+DfGY0LTjqS3TwKU8+u6aHvRqJxVi7xeTXmLYV9Z8fjr1+sDfcqZfoaghf/yj5ZRifIAzylZuiOFz7S7N57NhWHYKi+MYgxt10Klanei2a2Edwl0h76MiQc80k7xMjAha/z/GWyAtM0NFr9n9q2PCddPCA1VUxB/g1M0D5XsQAkgxDsdkO9/VgE6g3yng1N23g6mK7WODsq28nhh1ZoGTceuatx1HBnhUW1CcATEx4OkzPM/eQ/5HdyuzNJ+RoJMSaNxS1aoB//sm/0DfpOiwqqCYFdCRnKFnjcnLizl0E8yJrZ6CMS5yk44h9VLqV5qMG0D3EalfCQMw4HCDuiqU3i0n3vhJFHIyzrgM7EfVUGhjnZpttiOZa1FfqH9Nv5dR/ggpKLVsBX5BcwUjYF9wodRkv+nBnrCWAQTkV8ruebY3qoX6x6x3dO3AL4Uzkqsba8+8flavq4ZnFdZD3O349NAGoasK0TmK3c06anakfavvoK3eK8pW2zGHEwUd5xEDmtregB75O4V8Yi1wo7w1byguaBmBvz//BkRU5y7bZ8HFUClhIlFL3+5z+bodExgKCrASlf6uHOt2KbKyK1xR8CFIJYs4yNGDAKUC15xSPyNpKpQLNWy8UoZx1CEJaPAXog98HlUqMHkfD/MKWpPzzgdlSTYoOI+wh32pJGd1ZnRZUeGP+HV3gV2Dzs8C1gabgrhiPQkUHE6Fn83UrLbzda+vBk3Y0/+qUbNG78ry6iYBJ764k7fLGuyukFvEspP8FqerRg/FJZAiiZOu7Kk1nCSyEXA7U3+IZt ncnk6eVU r6/McB/bsENPY/OrPBk+6uXYxN7ha2T34/4vHuxVYsCjTDTTtl457oo844LlzxZqAuzMlAkMu0GjoxjTCVNNtkFxIqCH+mzVFR0/EA1GcFJ0k4pFy3+cQGrxzxW7mzV6A1KjIPwjN9Ofn8tF4g+nApt/+O0pbIcB+twrsH6ARmdY0qCcTqofGLyPnr7GQ9X3vJswfHSFiscgLT1rwlgMmX4NLcCtsh6HwOYC0ctglXfjb99cNcf7+X1LL4mWVeUe/Gg5B6GeTtQy9hLmrb1Zy97bREcGDq6JZMIWdvL4hkXDbHV0CTi+oHVn4RD78/HDgasfuB4V6Ptpr5IrHxFs7WYdu+S+TJgfAJ2+GhpwsiPS88BfclLOVOs6uAC9N+OfHVSetKmcTZAMf/kUm5FJm2IZrfNGimKxPSrb3d1Q2ktriAJdl6/pZ/UZlgTUbN1F035uaXJvl7MC0aIS801eBcZAYlFIUU9Kz/o8d7+wPm1w44IIwezCZaBbbtPuGvWm6aYdeZB301fipki//vB7QbhNw8HmcQbZxo72kYrRJW8fhkZdnL8rVUXD4rqfCZh8IH+q16qCv2q0yFp8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/2/24 03:51, Kent Overstreet wrote: > On Mon, Sep 02, 2024 at 11:39:41AM GMT, Michal Hocko wrote: >> On Mon 02-09-24 04:52:49, Kent Overstreet wrote: >>> On Mon, Sep 02, 2024 at 10:41:31AM GMT, Michal Hocko wrote: >>>> On Sun 01-09-24 21:35:30, Kent Overstreet wrote: >>>> [...] >>>>> But I am saying that kmalloc(__GFP_NOFAIL) _should_ fail and return NULL >>>>> in the case of bugs, because that's going to be an improvement w.r.t. >>>>> system robustness, in exactly the same way we don't use BUG_ON() if it's >>>>> something that we can't guarantee won't happen in the wild - we WARN() >>>>> and try to handle the error as best we can. >>>> >>>> We have discussed that in a different email thread. And I have to say >>>> that I am not convinced that returning NULL makes a broken code much >>>> better. Why? Because we can expect that broken NOFAIL users will not have a >>>> error checking path. Even valid NOFAIL users will not have one because >>>> they _know_ they do not have a different than retry for ever recovery >>>> path. >>> >>> You mean where I asked you for a link to the discussion and rationale >>> you claimed had happened? Still waiting on that >> >> I am not your assistent to be tasked and search through lore archives. >> Find one if you need that. >> >> Anyway, if you read the email and even tried to understand what is >> written there rather than immediately started shouting a response then >> you would have noticed I have put actual arguments here. You are free to >> disagree with them and lay down your arguments. You have decided to >> >> [...] >> >>> Yeah, enough of this insanity. >> >> so I do not think you are able to do that. Again... > > Michal, if you think crashing processes is an acceptable alternative to > error handling _you have no business writing kernel code_. > > You have been stridently arguing for one bad idea after another, and > it's an insult to those of us who do give a shit about writing reliable > software. > > You're arguing against basic precepts of kernel programming. > > Get your head examined. And get the fuck out of here with this shit. > Kent, Using language like this is clearly unacceptable and violates the Code of Conduct. This type of language doesn't promote respectful and productive discussions and is detrimental to the health of the community. You should be well aware that this type of language and personal attack is a clear violation of the Linux kernel Contributor Covenant Code of Conduct as outlined in the following: https://www.kernel.org/doc/html/latest/process/code-of-conduct.html Refer to the Code of Conduct and refrain from violating the Code of Conduct in the future. thanks, -- Shuah (On behalf of the Code of Conduct Committee)