From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D34C7115C for ; Wed, 25 Jun 2025 08:25:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06DAE6B0098; Wed, 25 Jun 2025 04:25:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 043EB6B0099; Wed, 25 Jun 2025 04:25:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E753E6B00A8; Wed, 25 Jun 2025 04:25:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D44CF6B0098 for ; Wed, 25 Jun 2025 04:25:03 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 798385FD44 for ; Wed, 25 Jun 2025 08:25:03 +0000 (UTC) X-FDA: 83593237686.30.B00E2FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 30F651A000E for ; Wed, 25 Jun 2025 08:25:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eC/iHLDa"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750839901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yjxBqLSglh9w0Bfe6TB64MnO1skEP54m/baUAxHHlrQ=; b=qEr+k2XErn4Q5mP5EMupGt2Kxle1J7jnr/auHTKFB2MSlPshKfolZywsbdTHedA8jGhT5B PLnhe1qobDem0GNGAr5TeVZp3NmxOHh5iqXk7vtodSk0FT5C0iTHM2dzxarahU26KUOFi1 LN2rMBe8JjOyTNNg7mJL6LXGUhTeaOY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750839901; a=rsa-sha256; cv=none; b=I4OPG2Dc163ZUP+SE1LDjhid7RSL6jd4Izs5v+1sGnmr4LwppLjxiRHt+ljjTUTXG1RsjC vOQFsZHmVvTd19maW+OkwNYk2Fl8PahUSP+ExOMgFqOsENB2EcUJzD4uYhCnVffNB1F0IF c68B772VPFfM578L6f0ZU1UiFp7civE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="eC/iHLDa"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750839900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yjxBqLSglh9w0Bfe6TB64MnO1skEP54m/baUAxHHlrQ=; b=eC/iHLDaH51WikVVvdq8kZPN/BZ29o9E+N8GCRGHjJAZtOEyU5h0FEII9HXws3AJVqTP6p rsmM/0EfhSbb+eoYlDqBm6RLi3liZBkfzkSFjzWKeRANU5osnvxPopIbHeGe9Tc3Ehetnj g5ry0X5qrTJT2CCp/A3kyov8tPhx06I= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-E7tgBIAoMbSKtut7VOsJgQ-1; Wed, 25 Jun 2025 04:24:57 -0400 X-MC-Unique: E7tgBIAoMbSKtut7VOsJgQ-1 X-Mimecast-MFC-AGG-ID: E7tgBIAoMbSKtut7VOsJgQ_1750839896 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a50816cc58so596831f8f.3 for ; Wed, 25 Jun 2025 01:24:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750839896; x=1751444696; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yjxBqLSglh9w0Bfe6TB64MnO1skEP54m/baUAxHHlrQ=; b=UlqNtAGt2CjHj5mAZROu1ykg/APA+BD9hD+hq6jf0dm2DwxsaFCdTu6/8YpansJ2Q5 Ko/hvQjl0CfZz2bLjgc0tBwea80//ulMLUhtuZSzeZd78EJOOp/Vh9sitPOd7GDTCIAS XQgEOjLkuQsMYbO2zQUjg69xdWegpkpr3IXtsqwKbLFPgG48r8x24AZez8p9qotFKwKM 6oWJxSCcleDydWmbwb2PY3YkTLpfd2efAGyRDLxHyJYZRtr1NH3tAoQGfRiyJ07hNszn rTo0UTp0eo+NIZdSxWlrmhtdD8SGePBZm9FZCFUqNjK1XvZZvMPABwcDkG+rs5JSH3PX CafA== X-Forwarded-Encrypted: i=1; AJvYcCWw7I2DhpdKy1ioATj+5xXyRXVcTMe8Q7yGdbKXUtIXKaNeDoC6mbqiHPvX9fqPSXEA6Pwb/8Dc9w==@kvack.org X-Gm-Message-State: AOJu0YyadVmOVQZMJKvJzsNWwKyvXirh8kl08DnwPLCsWVlEsJYqwlG2 28vvsgatQ815Jv0ttb5OMZPyefpyRv7DMNiIZH8wTItV8ZFKLGy7P+6iE7sqeYAT0zswGt6i4zR 9hiaGtpD+HjMx4xXBEOg7rzCeGQG7us/n4q6xlWucE6iKfW/Gv+4X X-Gm-Gg: ASbGncseBn2wlR3WTXP92+/Cq37Uyp0kZkkUqyntJkA4fRA8uVSItx6Dkc5khjSKmN7 +nE6dkKn3DU16q+uinVajGQfvg8Y7+izYPHkt286ItgDd3mzktJ7juLxMsf6zWyEpInqmvYrsXj 4rubBC5dU00pJTxT5JWYX8Q0+OmTyOX9hBho+pUuv4KEIHjNJMsMPiBZjb5cGm+ZczieW/DfczJ 2DEkb1ftN9qEqhiBh/50kOPZ2gX1HFJByBn7+SjE0Ictg5oX/731qJaxUPbgMFZtTrs6T6ZeQEx QQmePbAIFdFOJgf1dQuB6I9+PrtDFEhmKDCdDX1j/qwKJmIBa8P6s7WlBoNamYkzmTPb3EnJ1zt gpDieABuli4GaSWltJ3SITtTah6VFv7sKWWOOsS4JGWQi X-Received: by 2002:a05:6000:4b17:b0:3a4:fa6a:9189 with SMTP id ffacd0b85a97d-3a6ed65e833mr1351151f8f.31.1750839896139; Wed, 25 Jun 2025 01:24:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJdi4Mem91gTU6FBagrsf3QJAVRSz9TsoKzr+Rk/R17NjfIBqv05o4O3UswDeP7ARQxo3SWQ== X-Received: by 2002:a05:6000:4b17:b0:3a4:fa6a:9189 with SMTP id ffacd0b85a97d-3a6ed65e833mr1351120f8f.31.1750839895799; Wed, 25 Jun 2025 01:24:55 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e80f264esm3888251f8f.47.2025.06.25.01.24.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 01:24:54 -0700 (PDT) Message-ID: <23b8ad10-cd1f-45df-a25c-78d01c8af44f@redhat.com> Date: Wed, 25 Jun 2025 10:24:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] fix MADV_COLLAPSE issue if THP settings are disabled To: Lorenzo Stoakes Cc: Hugh Dickins , Baolin Wang , akpm@linux-foundation.org, ziy@nvidia.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, zokeefe@google.com, shy828301@gmail.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <75c02dbf-4189-958d-515e-fa80bb2187fc@google.com> <008ec97f-3b33-4b47-a112-9cef8c1d7f58@redhat.com> <01d679f2-fd64-472c-b9dc-ebe87268ce82@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8kSJr2sExEJoSBd4-DS4v11D3WHXMxz8Kg8JkC4_BJA_1750839896 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 30F651A000E X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 9oxsy398y4egss8958kto84eurew67bj X-HE-Tag: 1750839901-386043 X-HE-Meta: U2FsdGVkX1+boGmd6qIalX826p/p41nYSP8LfXoJ/dhk+2Nz4PXYOOROrxiqE42qV9z6jUJ4ttLV/m1JFNeFFY6VeH0Hfrajyzs80Mq3RZI6N7m4ouTr4Go/Mi/b0M64eThqb+IA6gWTbi2A6OtN385fziS6sXBXk/Xh7+a8eXSxpTVJ2CdmQy2Em4ZNfm7fbsu8j1LIMypoXpHOwkN4M0w0xrBgrO4Rw1bK2RwJl/eBWE96namIQW5xTlYQNgrS5OKgsPFhB9lqUX1vdR2jlQCxZIKU2IDGUiaomlvvxd6xwoNtp9Qv5wTCCj4pjYJ3u+r/iUPFi00Am2eTb7UBmwEVoFHPvbi0FMQPvxf9QMuU7/1DNUniORpmd2xx7aTMXpYgNILIoRa2/kjR848mossIX5WK2CM46sTUObN376pWvEAZoEOYUc0vUhJ0Yg2GdV45hwWMPG5L8jilWv4wHhWW/py/sw5j4CNUN3KywpHQnsQrMOVlpnZneXzn9FitLw0THr9FAO8grTya+K8hg5ql+oxMrKQS+wwp0N9gBzHAoDZfkIRazyBupgmvGQP2+Btiv6BfXDGpr4ce6yRZMMluGfmLg0a3bCLG12+aJFg5cyWztmL34UGl/BVac7syF/NgMywXDDL/chyfOuc9fcbwl2Lk6iLLfbz7W03wFp2m46zU73WBpg8Vh0BaLxl6PmpMpz2AUHkay6iIcm9ZdxM+MqW3cYoQxsZF0GfNjYOwdTM8qYJ4K0nOoSXVkQ11E2l50RYWYw3c645DKhiGXtum1qKt5FITzs8fe66+iqHkN5HdVNB5E2MOMU/hHctM6rW+f7Rvh2gVfXJJZY2afp0Yyr7KIpzEfbLGO/rWGZO+1ngUjrUzwQbMI8OhEaNWV0R3BuRVNVAG3QWcoIAd0gJDsqhlyYwkTk1DhZcoXUFu3Fo9WAVTo16sAuGBvjeb+64Gi/8XpajgpwlYWkS 7sPNKYdS DpkDHrBzN41Kl3vpp7wnKtFDOzb2bcUk5XvwkgQasAzJMAeQxCWTFzH5yH7diPe4+NWJRB7ibp5PYUOqR8e9ccDpthGH/IJINA0T3ii+bnzKI31NJWbn9UrN/jjyPvdI3hsQu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 10:12, Lorenzo Stoakes wrote: > On Wed, Jun 25, 2025 at 08:55:28AM +0100, Lorenzo Stoakes wrote: >> I suppose the least awful way of addressing Baolin's concerns re: mTHP >> while simultaneosly keeping existing semantics is: >> >> 1. Introduce deny to mean what never should have meant. > > To fix Baolin's issue btw we'd have to add 'deny' to both 'global' settings > _and_ each page size setting. > > Because otherwise we'd end up in a weird case where say: > > global 'deny' > > 2 MiB 'never' > 64 KiB 'inherit' > > And err... get 2 MiB THP pages from MADV_COLLAPSE :) > > Or: > > global 'deny' > > 2 MiB 'never' > 64 KiB 'always' > > Or: > > global 'never' > > 2 MiB 'never' > 64 KiB 'always' > > Or: > > global 'never' > > 2 MiB 'madvise' > 64 KiB 'always' > > All doing the same. Not very clear is it? > > We have sowed the seeds of something terrible here, truly. Fully agreed. "Deny" is nasty. Maybe if we really need a way to disable "madv_collapse", it should be done differently, not using this toggle here. Regarding MADV_COLLAPSE, I strongly assume that we should not change it to collapse smaller mTHPs as part of the khugepaged mTHP work. For now, it will simply always collapse to PMD THPs. Once we want to support other sizes, likely MADV_COLLAPSE users want to have better control over which size to use, at which point it all gets nasty. -- Cheers, David / dhildenb