From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08AEC25B70 for ; Sat, 28 Oct 2023 01:36:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B08898002C; Fri, 27 Oct 2023 21:36:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB87780018; Fri, 27 Oct 2023 21:36:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9803F8002C; Fri, 27 Oct 2023 21:36:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 84D5780018 for ; Fri, 27 Oct 2023 21:36:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 563AF140ED1 for ; Sat, 28 Oct 2023 01:36:37 +0000 (UTC) X-FDA: 81393155634.15.DA4356E Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 8778B40002 for ; Sat, 28 Oct 2023 01:36:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vdsTsXrI; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698456995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IELGD68QeWnUvOrfpqSGo2BNQPupvv5ypFkOiDnBJWQ=; b=Efq+3fogHWQboYbfuo/dGhJUMWrXJXicoA2Q2m5R0ejnvrC4zDBnLBkEoqbtpqwFr0Mhjl ku9NwOdgHocPjoFFSM5bnK/xnNHIwD/trCcwiTuCWd6NxWUg1baA4olWN7+Q8gtQhdP25T N4ERog/AQuXsUWmeRpyYOWbzKYLWir0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vdsTsXrI; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698456995; a=rsa-sha256; cv=none; b=W/k+vdxMe1a1cYNfpZbEt0o80VCgswrnQ4eO3RVhFswVWatbT5FIriJ2rd0MzU1cPQ/6WS OK3RO/WY3GGAT5FxDa9rwlgqsvK2DpDa4FdewMZQHBTU4jTSpKAn9OFDB1B2v3IyXkg5UQ B9jJhB9qb4MmXlwlwNAvi3oi+eclx/Y= Message-ID: <23f21bf1-0f27-4091-b889-bf43290fa6f3@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698456993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IELGD68QeWnUvOrfpqSGo2BNQPupvv5ypFkOiDnBJWQ=; b=vdsTsXrIyli5JO7yC0/L6twGLUnDhL+qGEMALj5iryqYXHodZr/YFCP2Qr5RSlclXdm6N0 K0yHT3pifs7mjyUgVX6H6zUSHPFD/zkZ1/zKtGwpPAhI692iMnWsRdC/AVOACw+b4y9C6+ ERzZ6DkTDqUXy60eJitERlKH9si5UKU= Date: Sat, 28 Oct 2023 09:35:55 +0800 MIME-Version: 1.0 Subject: Re: [RFC PATCH v3 2/7] slub: Prepare __slab_free() for unfrozen partial slab out of node partial list Content-Language: en-US To: Vlastimil Babka , cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231024093345.3676493-1-chengming.zhou@linux.dev> <20231024093345.3676493-3-chengming.zhou@linux.dev> <43da5c9a-aeff-1bff-81a8-4611470c2514@suse.cz> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <43da5c9a-aeff-1bff-81a8-4611470c2514@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8778B40002 X-Stat-Signature: 6t4tj3cahdjdbe6rx5xw4k9puyob8k17 X-Rspam-User: X-HE-Tag: 1698456995-286908 X-HE-Meta: U2FsdGVkX1/D2aUP8RqKxA5ce99Q26qvrb5BwlDkkAcrDXB//oh+Ns1afy10+Q81c8iumo9vpdIB6S2y1Glu39r1Ty+UTj3ZH1NRIVa992HSeyMr1/mtAWe0Gyyzy37oHW6NEJjMer9ev9t4kAcyrYCd9xx10vT6AaqWmf0niLn//3k3sw1NATPTyQTthPNh5tdAQA4SLWBzeNwnfyXNIcZpeUzrkTpliYgq4fi3VwdPZmk79LM00wducdt223ZRR+HjfIkHECFqwcVBBJUXW+O7w5/dsRLnYc6rTmBqE5jB5UPwutmOT5xmIYY6Bc1Y2vtQQn73KVn7DfQISOGNXkcEfcgPvvgee20KNpa/rIb67F9Rl2esZXSdrjQZpKS9++ftDHvCIRmoOPv9IN23AFqb5rfO8+9vTZpPvyn9KgRkg2fNwI9hdqdNxhhcSdmrAp2bZ+szd28wca0FyXe4zC+ItE9jLMRmNBeX7N1hRk7tk32pLGsE4M8qTrQLCdZHAOHW65M8x7GZFa5F+2eN02M8ARgElBXbafcXf3VdkV2opEoAP8rxJEvHmBDwDMkLCmJm7KSF4DoiitzFVdlQzn53faMmOLOn1PPVWPSlbI5D4WeNx12z+T2XupTth7szYqrmdz0n3C/SBp33oRWA0iB3QAK9wwqIQPr81hoUAXHE09lS/EHwyxKKqy8lqX0/Y9QqC42L/HOhg3lILWTSyt+Nk9evHN4TWyTX0qAXkwLeZvfZodWpQOj7yxiTwzgUHtVGE4Fvvv2PmeJzMuvtYt3MuVke1WV8jk8I4CSSJNWQ1nEpt0jVUZqnJKJeKEPR8CoR+QkN5duTtiN6R+d1K9SslZaeH61XIu24/ew/G+dU3OhTISTb2S+L5rizoJkZVMEuk/8rKfM0/RMS3GPvualkf+zvPF+RGW1r/cYyWkS3jz+t1mZZ8YZHCKnjJs/9miH93gmCX6E5AYBDWEK 9SuGYCDV 0E0Knkwb4gI0NZ9xA3L+LLnokdgtvX4NdITe+poU6G0lg6QVKS6nE084ggKv8RXAG/LD5XMuh5SSwzCbt/WVmv4gCVRTNjJwAgMFFUP1b8rKq5K5f3nZLY+BSXCIFJn0UYTVWFqlw4OflSwj/0SltQsV1LUFEJrfQfwcxxPlRTJ1ShkzJP4kunUN+1CCjAHMDhSCHKyaV8E9LWPXv9aOqDjFfL7snTUzlEA/Ee4JoQUG2RTMohmy9+NdWAa0NawlJDEkq7UwfK0+fXJU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/10/27 23:18, Vlastimil Babka wrote: > On 10/24/23 11:33, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> Now the partial slub will be frozen when taken out of node partial list, > > partially empty slab > >> so the __slab_free() will know from "was_frozen" that the partial slab >> is not on node partial list and is used by one kmem_cache_cpu. > > ... is a cpu or cpu partial slab of some cpu. > >> But we will change this, make partial slabs leave the node partial list >> with unfrozen state, so we need to change __slab_free() to use the new >> slab_test_node_partial() we just introduced. >> >> Signed-off-by: Chengming Zhou >> --- >> mm/slub.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index 3fad4edca34b..f568a32d7332 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -3610,6 +3610,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, >> unsigned long counters; >> struct kmem_cache_node *n = NULL; >> unsigned long flags; >> + bool on_node_partial; >> >> stat(s, FREE_SLOWPATH); >> >> @@ -3657,6 +3658,7 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, >> */ >> spin_lock_irqsave(&n->list_lock, flags); >> >> + on_node_partial = slab_test_node_partial(slab); >> } >> } >> >> @@ -3685,6 +3687,15 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, >> return; >> } >> >> + /* >> + * This slab was partial but not on the per-node partial list, > > This slab was partially empty ... > > Otherwise LGTM! Ok, will fix. Thanks! > >> + * in which case we shouldn't manipulate its list, just return. >> + */ >> + if (prior && !on_node_partial) { >> + spin_unlock_irqrestore(&n->list_lock, flags); >> + return; >> + } >> + >> if (unlikely(!new.inuse && n->nr_partial >= s->min_partial)) >> goto slab_empty; >> >