From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7684C7115B for ; Mon, 23 Jun 2025 10:10:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D5CB6B00A0; Mon, 23 Jun 2025 06:10:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 286366B00A3; Mon, 23 Jun 2025 06:10:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 175036B00A4; Mon, 23 Jun 2025 06:10:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0432F6B00A0 for ; Mon, 23 Jun 2025 06:10:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AB8A880533 for ; Mon, 23 Jun 2025 10:10:45 +0000 (UTC) X-FDA: 83586246450.21.01D00A4 Received: from mailrelay-egress12.pub.mailoutpod2-cph3.one.com (mailrelay-egress12.pub.mailoutpod2-cph3.one.com [46.30.211.187]) by imf28.hostedemail.com (Postfix) with ESMTP id 7101AC0010 for ; Mon, 23 Jun 2025 10:10:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=konsulko.se header.s=rsa1 header.b=1QQ8GrHH; dkim=pass header.d=konsulko.se header.s=ed1 header.b=pFgAp1px; spf=none (imf28.hostedemail.com: domain of vitaly.wool@konsulko.se has no SPF policy when checking 46.30.211.187) smtp.mailfrom=vitaly.wool@konsulko.se; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750673444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e/4wAU2MMN25qAei27JXFenl3y/9Bx6y37wunFoJlec=; b=LXEPw2K+n//CbbrD2FwaQP8xqspDbIOpLjj15YTdu+8DYJVHQzYN0yKvj4fAHKtflJEoUH TfdEb1Ov3epHi66qZLnXpwGwEdI/tDP3G4IS/sFto42LgDX1iuRRq/JwsPcRtwVnxeW4QA OynMUllD5MPyz+ZlJusf6QOM9x65qcs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=konsulko.se header.s=rsa1 header.b=1QQ8GrHH; dkim=pass header.d=konsulko.se header.s=ed1 header.b=pFgAp1px; spf=none (imf28.hostedemail.com: domain of vitaly.wool@konsulko.se has no SPF policy when checking 46.30.211.187) smtp.mailfrom=vitaly.wool@konsulko.se; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750673444; a=rsa-sha256; cv=none; b=4bwQqfTWFTrdJy11RnDLAFLbF70GH075UrnIIHx6RZsWzx/8Y0PskQhxTjBdwFguntlRLt N6O45XAbqC/8SUmckmYYmnXrnNdPAY2nYG3fOGFEeOIUC5xLOvzr0Netmo5huhao2+Maop JltIfQ2z/DR08e0LOyhtbGHFpHXts3M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1750673441; x=1751278241; d=konsulko.se; s=rsa1; h=content-transfer-encoding:content-type:in-reply-to:from:references:cc:to: subject:mime-version:date:message-id:from; bh=e/4wAU2MMN25qAei27JXFenl3y/9Bx6y37wunFoJlec=; b=1QQ8GrHH2kVU413eR4MZvv37v+nN43qoniSktmfPwtmwC4zchTKWiG/EkTaB85v4LhU8S7K1WsEs8 khWWu9OqD+YM3G7EXqOzjDQ7nuRl+dd5yeJyQlIx5rLPVhETGDGon1nRYxdJIoSSpU5j9Ryp40z+V7 x3u7ONtc03DST5+wePFfMl0v9/4b1emtF2wgNmA12/kTls55ahYof/wCTdLNYg2ibF5vsr+wKskU/W f/K5GlGSusBfYcfhxxOEqzBk3UKj54s+Fc4+iZ9iBGxerFSAp9roFuDAomG79S0/86UxvwLdhzSgSd 9MXPp/qIMPYqeqxNZw+gmp/35zvfKhg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1750673441; x=1751278241; d=konsulko.se; s=ed1; h=content-transfer-encoding:content-type:in-reply-to:from:references:cc:to: subject:mime-version:date:message-id:from; bh=e/4wAU2MMN25qAei27JXFenl3y/9Bx6y37wunFoJlec=; b=pFgAp1pxldR1nK5Zc8BySWAC1b4XH1lCaoMsA2F6oRMQ5Y/3SbamBasRCBRQWfK2TdJCL+ocWS8gw quYZxpCCw== X-HalOne-ID: 50105f82-501a-11f0-a817-f78b1f841584 Received: from [192.168.10.245] (host-90-238-19-233.mobileonline.telia.com [90.238.19.233]) by mailrelay1.pub.mailoutpod2-cph3.one.com (Halon) with ESMTPSA id 50105f82-501a-11f0-a817-f78b1f841584; Mon, 23 Jun 2025 10:10:40 +0000 (UTC) Message-ID: <24bacfdd-ec42-4819-9b2d-f94e29fb1fbe@konsulko.se> Date: Mon, 23 Jun 2025 12:10:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/zswap: export zswap API to modules To: Matthew Wilcox Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Igor Belousov References: <20250620193552.2772125-1-vitaly.wool@konsulko.se> Content-Language: en-US From: Vitaly Wool In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7101AC0010 X-Stat-Signature: ypecob1cg7og771sy3oapkmbfc9bqhmx X-HE-Tag: 1750673443-341017 X-HE-Meta: U2FsdGVkX18ZZRBpe2EGariganvn/MRl1gyrDM7epDboKIbyOD6kPWpvy+18Es5Hxaq/acYm+/pngZkDksKyWpj2VZbSMaLxipmGRyMWu9pjl9DarSy/u5AbeSn39UGuZ9YDbCtVnDMqKzDKg0ZDqyS+uxpnluI6yQkTXW/uPK23qtmRAjf9NxtH1Ng2oam0KHgv+i96HTQ6x23qteiJpIvW9mZht/gr7hBi/rcYRr/HpM7oyPiU/audXYWjqS09DXTdAsqROAcEwr8NIRQucBpcKaoVAGdjrhp9HR+skIV9RLji73chwfmF30+PFkD+sbABgoV0+2NAT8rrCWhV5JSPqNa4ka9m4IKTlIsu96I004QlbjkNW3AtexqX2+WX5+KpIO2L8aIwV3GDtVD3MWiMWtLtA679DdQUeSVhOb/bO8D/uDLdalv2vCqvG2o0DJwaXaygzZSQki4UMR8juDVgy7yHv1gOVgkAzshB/J7pdGdvbsobOdXGKUAOeoucWXr9vOKoBNTxdgnp+xskNbMue1xPXdAooY33iJC1F/XIkFT6lkUlcRYdn1mT4iTE0YVcp3EI6BpavKU64lAht+MEVF15sgjBoMZWADRd8bZLpd2tN2yGs6H7d53I+dhvdCh21TYkvrCXQlfBpH+1k4xJu9QETaQLb/wYZmqMAUDrQDleJzwHjVwW6u9WFw87b0NMpgUncq9PYsWjM20lbLPSWQVYlxGegSznM++df9mcx/YLa2fRIy2ey9M/Cz26LdC8S9BEvWRXAAf3qx/m+J1opjVspyjsBTohIhSqp8saTOmUUBg/E+1J5zggrSryMKkC2HGeEhDHIRma2Cj4SJ+A80FHxJWR/Th3ZKV+edO0Ht3HGmDydfsRWGHMlf5EU2KL4bRtNI8fhVADbonUPxbuOMj2C1cJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.006861, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/25 21:47, Matthew Wilcox wrote: > On Fri, Jun 20, 2025 at 09:35:52PM +0200, Vitaly Wool wrote: >> There is no reason to not let modules use zswap capabilies to >> densely store unused pages in RAM. This will allow to remove some >> homebrew solutions for e.g. GPU drivers in favor of plainly using >> zswap pool. > > I really think these should be _GPL exports. And I'm not sure why the > GPU drivers are using "homebrew solutions" instead of using the shmem > APIs which work whether zswap is configured in or not. shmem API adds an extra copy which would be nice to avoid. Changing exports to _GPL I have indeed no problem with. ~Vitaly