From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23BBFC6FD1D for ; Mon, 20 Mar 2023 09:58:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A2496B0074; Mon, 20 Mar 2023 05:58:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 052976B0075; Mon, 20 Mar 2023 05:58:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5C6B6B0078; Mon, 20 Mar 2023 05:58:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D5D846B0074 for ; Mon, 20 Mar 2023 05:58:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A3C0C1C5BE4 for ; Mon, 20 Mar 2023 09:58:55 +0000 (UTC) X-FDA: 80588827830.30.74986DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 40AA6A0017 for ; Mon, 20 Mar 2023 09:58:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PCj9RSPj; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679306333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eusdBqGYQDxvoAs8ndLlA22S0Bv6aqSKMaLO9WfcaK4=; b=IJaUClnuqb7kWSLFqLMg6H7o841Aq4RKws7cBZ9Rk1+MHPMeiD7M0xlm3X0IBgIuDgfZct MoyJ9XGPNJ0+TuBtzE0jijOZLpCNbV2JreI9v7VeBMYrmols9cD7NRM10LB8BwuR5Hkfls +lG6k6rDgzbqysh/3qiWx/VLt7QdvPw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PCj9RSPj; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679306333; a=rsa-sha256; cv=none; b=VbN9wMWpNHhaB4F+qWO41alKritjvhNeGuxqY+/8YHORCHR0uIPF4Nm/h7GfF5KF1Lk/QN LT8NBhJnshp1LjR5zx/y4dXxmfhrzZFI1gRMkSR4fasdrIFhZ6a9RCJwFNQQvu5qZUdU3t SrJIZSTbAFZIFqS0LwpYBVtUl+du+w0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679306332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eusdBqGYQDxvoAs8ndLlA22S0Bv6aqSKMaLO9WfcaK4=; b=PCj9RSPjNxS7IM4JlKxc1weYQhCOhuwgxdZae97dYjt6cYcASygz4n08q1xTf3nCZ8IJNY G/FYbghigWCKMsi0HyWRp90ShPmNRUvMrxjPQ7cEQi4o1HOzNIQ6cIeX59QPHxpZJByFIf dcPjULCA/m7xvffrZJijwHbjQE1LmVk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-wTo7w3hZOy6OvJwvoBvlRw-1; Mon, 20 Mar 2023 05:58:51 -0400 X-MC-Unique: wTo7w3hZOy6OvJwvoBvlRw-1 Received: by mail-wm1-f71.google.com with SMTP id p10-20020a05600c358a00b003edf7d484d4so754790wmq.0 for ; Mon, 20 Mar 2023 02:58:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679306330; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eusdBqGYQDxvoAs8ndLlA22S0Bv6aqSKMaLO9WfcaK4=; b=QRuNEaJ3wjozsGyZDywX4O9sbSMINstsXq2g3wnCXME/UAYkZCLJlsVNCNEQ1qXwjm TtuC8gvC0OO3HZ91UnS9l2m0kuYfm1vR/Ytjt7n0XMEDl+dtMGqHudkPiiWaoDM8+dIh SF/1xQ8aHg5IgsSUXVusT5xdrXg93K6fXGZLd4G3XCulCfjqlfBzvLBZ+i2FvHRNkUTB i8vVOXuHAtP4Zy5d5WogpYl0xdfDTMm08dOWwt1o6rV8CyLBMdTlG4ZMgRd9CoX9cN04 FPvIkw+p+B+w+UZaGLYx0lhlToVdPhJY5PUgGkuweXN/+RyKDlTQhagofKGAbW75HbRE Ugeg== X-Gm-Message-State: AO0yUKUN4nitPZy4mWLs31y6tvFUpOwRzRzpT2Z+OHpVTErSm4BA/2Zd atifG2WHHg+gCWAcgCKSZKuj4qm9LzN19T0wbUysf3xz+BiNng8HXWyaXhx7cMpDYdncnVxnCSF 4t5BLF6k7DB4= X-Received: by 2002:a05:600c:3ca8:b0:3ed:b9ee:b436 with SMTP id bg40-20020a05600c3ca800b003edb9eeb436mr5407672wmb.7.1679306330237; Mon, 20 Mar 2023 02:58:50 -0700 (PDT) X-Google-Smtp-Source: AK7set/G9biqC479ICASHvl9gHffWMTV5W8wX+knwU5u+GUa24HaC6JE/ihsB8eKFFScolHb3CqGNQ== X-Received: by 2002:a05:600c:3ca8:b0:3ed:b9ee:b436 with SMTP id bg40-20020a05600c3ca800b003edb9eeb436mr5407658wmb.7.1679306329950; Mon, 20 Mar 2023 02:58:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id y13-20020a1c4b0d000000b003ed551b139csm10000745wma.36.2023.03.20.02.58.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 02:58:49 -0700 (PDT) Message-ID: <2593f450-f65b-53ea-8b5d-d0bab89c1bfb@redhat.com> Date: Mon, 20 Mar 2023 10:58:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/4] fs/proc/kcore: Avoid bounce buffer for ktext data To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton Cc: Baoquan He , Uladzislau Rezki , Matthew Wilcox , Liu Shixin , Jiri Olsa References: <2ed992d6604965fd9eea05fed4473ddf54540989.1679209395.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <2ed992d6604965fd9eea05fed4473ddf54540989.1679209395.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: t65gho46eczqj5jawk4fextbma7py4ko X-Rspam-User: X-Rspamd-Queue-Id: 40AA6A0017 X-Rspamd-Server: rspam06 X-HE-Tag: 1679306333-232405 X-HE-Meta: U2FsdGVkX19rf51J+U1E6fN8f5mIpNfPQdB/lWv8L71zNz/Akza9/KKa1vck6KTfrn0qvjhyy2O2MRTla/YmMOQmAnxHeew9Gtz5omKqKP40e8G2NbBJFWUiJ4FjbAQ0RGdLpGF9onQHVCELc9DpxhsAQbdCYcpRR7fxcs/SWRSbXNpFHD9tuVSvSFhkqvfimT4U+4WRQRIktCA/8uPfn/Hai6Stt92NJGhoMubUxFC2unVr+MNwKTjLLy4UcibnrU+FK5XJLqHtUhai+43eyQoF0ur56+MAiTOS02DkZXRdl/z91ZnX/jYvwr7otYBrzClXm044dLtGz+OwlihdN9iOvDHen1g2hKqXHZVGRh2AMRr+gZhDU9J+n4frIVHvbSi2wWq/1xGlLBPe/37prcxYNFssN9MXl7qM3QIpuzkLVOYRzIeHtt+MRBAJAkvVG9QqAyeLGv0Xob/3eulfgPfPEPH4tEzouFnzt0lGjFStL8OiTBqgm8o2FChWSCPQNvNNDSKBU87wPZyQWdMwj+TOrHmX8ZhrqIhOJJfVZn0QXUxfc4k/WKDvaCchtmFfx2TaIhn35771mJYSaAmrGcOg3Xxt/T4vI6YT7+lxRAaQII2W8CF/XGO7Va1ywTRByuqKJVn0k9xYnkhJnme1dLkD6BaLZjFxhYRZzdtyQHfPGpPNwX0binySgA76WP+xkUVHEK/1skjN0t8Eq7nfC8v6FwueNmjVGawpuJXgQGrII4qeuu8QE6QjYasYtVZDMmyXOG/xNOQmKLlMI6Aiuwqj7mNDh+H8OryFvruOzB1iJodijxRqDV/g6VI1701xtipKYjy8fGq+09okfO4qd8QqgGmS8oorJPZ8QWi5fltwiVygi82SrqvYKjIR5cYcx8REYxH9Wzud9QtTIEkQiH0IGNEtW4yIcbdhpkUoO6rKqNnaty1kzLUXQJO7kpAEqqNT4u/PeSPr1B1X8jM bQgXXCoM thmXGq5SXt5mJyxDPSE1Ay5ZViZNOHd5Ja3vgszDwWZQIpXySQxsMiHJC8+3GBNgWsVC69e79H7JvZpyPTjx2Aun2UgBxeM5oxIp3M9BC2VZGZF82FeoKzUW8RKCvhdK0S7mSk+GnXX2H7CB0YhAJjZjG03tU6S+YS8mU5G6CftlA9jS3NNu4r3kfIeb43wRFqMYAAVENfO9SQstfbvfTVzvYkSFBQ//QYgleGB0Oj0pCCzrlgpNgfBPHfKt2VgIn/dl3/SeW8cDjhUNx/Zd7QB7qfjORUqtPnUhOW2keKxd99P/TMy0QmiTdy2gaHFn/brmHT2El1MTldEuO/yFkcU5bOLfUgtbFxD0LxOstQkGq1XPHUaN0xU+mpJSxi88fM0yG4xbZ178uvig0z4swvGYpHVYImAyOuOCZYKvqN01T0SyXeltd4vw13h+gZAk4pZY/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.03.23 08:09, Lorenzo Stoakes wrote: > Commit df04abfd181a ("fs/proc/kcore.c: Add bounce buffer for ktext data") > introduced the use of a bounce buffer to retrieve kernel text data for > /proc/kcore in order to avoid failures arising from hardened user copies > enabled by CONFIG_HARDENED_USERCOPY in check_kernel_text_object(). > > We can avoid doing this if instead of copy_to_user() we use _copy_to_user() > which bypasses the hardening check. This is more efficient than using a > bounce buffer and simplifies the code. > > We do so as part an overall effort to eliminate bounce buffer usage in the > function with an eye to converting it an iterator read. > > Signed-off-by: Lorenzo Stoakes > --- > fs/proc/kcore.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c > index 71157ee35c1a..556f310d6aa4 100644 > --- a/fs/proc/kcore.c > +++ b/fs/proc/kcore.c > @@ -541,19 +541,12 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) > case KCORE_VMEMMAP: > case KCORE_TEXT: > /* > - * Using bounce buffer to bypass the > - * hardened user copy kernel text checks. > + * We use _copy_to_user() to bypass usermode hardening > + * which would otherwise prevent this operation. > */ > - if (copy_from_kernel_nofault(buf, (void *)start, tsz)) { > - if (clear_user(buffer, tsz)) { > - ret = -EFAULT; > - goto out; > - } > - } else { > - if (copy_to_user(buffer, buf, tsz)) { > - ret = -EFAULT; > - goto out; > - } > + if (_copy_to_user(buffer, (char *)start, tsz)) { > + ret = -EFAULT; > + goto out; > } > break; > default: Looks correct to me. The only difference between copy_to_user() and _copy_to_user() is the check_copy_size() check, that ends up calling check_kernel_text_object(). Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb