From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B80FC3DA49 for ; Tue, 23 Jul 2024 21:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CDAB6B007B; Tue, 23 Jul 2024 17:22:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67DF56B0082; Tue, 23 Jul 2024 17:22:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51E416B0083; Tue, 23 Jul 2024 17:22:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 356AD6B007B for ; Tue, 23 Jul 2024 17:22:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9DE0416046B for ; Tue, 23 Jul 2024 21:22:10 +0000 (UTC) X-FDA: 82372290420.07.C84B0AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 5D3FD40007 for ; Tue, 23 Jul 2024 21:22:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XN3Qp4e5; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721769681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g2K985F+JisyaO1P/JvvQtZwZa+DhsuE69ZrR+fszhY=; b=4wl+il3hDp1qGciH9Cu73iXOhrbfPq6rWM8T+ewwTl6dMd29WYLRUO88d7XKAE9ImFHrfy 5UGReJEqs0sVzkKwkesZrAzA31y/xtMiZmFQi6veV8A+WSFLPJogOQdpBCyRS1NfvaeA3D kdD+XGGtJZNq1aTW45RYpJy0nryqt0I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721769681; a=rsa-sha256; cv=none; b=OLtop6scc363TLyVNiVXUUkQ50mJeOrQIA0BK/Tx0hX1b1b8EGIZ9CuLq/7siYWLpqPOFj 7K+lfTUcJC2Ij6Rxa52eU2bx/LzgbjdLph10DOXyhTBYCFGZwqY6MGwfQNfXZoCQq7C9mh Qw474ZPiZssrVRvEyfC2grz/kRXXdio= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XN3Qp4e5; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721769727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g2K985F+JisyaO1P/JvvQtZwZa+DhsuE69ZrR+fszhY=; b=XN3Qp4e5liel8eofgyl0Xy0ch/m4trotEunQ5LvifTN5vwH5s8u2AJjEjW/wsQui/4mOxC vuVGSCsmE0ixIxIUzV2vWhrMKTfnehCkWysDmLoC+zX2djIsVpNd20kxOBfHIIiJSefH3F pDzH4wkc3nEkKmRMKKuoVa7obYvNOS4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-wuuNeZaROi-4bnrcuVZwgA-1; Tue, 23 Jul 2024 17:22:06 -0400 X-MC-Unique: wuuNeZaROi-4bnrcuVZwgA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3683f34d8d9so3412108f8f.3 for ; Tue, 23 Jul 2024 14:22:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721769725; x=1722374525; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=g2K985F+JisyaO1P/JvvQtZwZa+DhsuE69ZrR+fszhY=; b=CGKTYfjqvlu3W7FMdIeOoTTtlUuP1uJDB8C334uZ1/oHPKUUz9crhlCJSuiZbZMi4s txiTc8lybd+yLvjnUbnh/lJHTs3eC6pSacvEAsSKa+fagDaMgGMVhFFPUN0JWWTdSd3i crz4KJ7yqeShvkZ4yvLH/j2Zs2g5Pu/71XOQLaimBi10OsugzZNSehEe2LFbhUGgFywN C4ekXepyd9tA2aeQxZN7ozGSJwuQt25MBLZHtqUu4BsnOEjDPCme0QxrdPL5Ej6wJ11k 5FSbKQY9+ZTCrlBdaDTdCPIHkEJNyArgR3pZSObcwuD4wthntDVMbd8rtin1FJsKC9aG ullA== X-Forwarded-Encrypted: i=1; AJvYcCUobS43L0flmGB8P4XKiXj0iRgUKljKUhE/SHxzVv2v+Q37wsqMoaBLF8Tqj2Ouj6+6AtU3yIbCrscS+chKHTilonA= X-Gm-Message-State: AOJu0YyxABN62c/dRZAGZWLrc1jVabYqr4t7aLu3cfz+edlILzGWNLTV PK2Ma1wYgdgIz505lIg4HBWVlScVCKCTmkqaVdSaaBSpf3ibvuo1HXhNRqZFD7LcTlwUWB4YsYF KM7Zz5ctZUTFHGGFDeEMbf/ldpd+N/lrgl8fLTKjFuqqQFfAO X-Received: by 2002:a5d:64a8:0:b0:367:94b8:1df1 with SMTP id ffacd0b85a97d-369bae97e75mr7352135f8f.55.1721769725080; Tue, 23 Jul 2024 14:22:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZpJY61ZWZsVtUXIZgPXhIWFxqPYeKoLxP8USF6rP/yxwg/LgUFS9ATMnvRHeV1H1e/zaoew== X-Received: by 2002:a5d:64a8:0:b0:367:94b8:1df1 with SMTP id ffacd0b85a97d-369bae97e75mr7352118f8f.55.1721769724633; Tue, 23 Jul 2024 14:22:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ed00:9dc2:1adb:d133:4434? (p200300cbc72fed009dc21adbd1334434.dip0.t-ipconnect.de. [2003:cb:c72f:ed00:9dc2:1adb:d133:4434]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36878684839sm12529422f8f.22.2024.07.23.14.22.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 14:22:04 -0700 (PDT) Message-ID: <263e4414-24c0-4245-9c6d-7799c7bb9f77@redhat.com> Date: Tue, 23 Jul 2024 23:22:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/6] mm: THP-agnostic refactor on huge mappings To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Oscar Salvador , linux-s390@vger.kernel.org, Andrew Morton , Matthew Wilcox , Dan Williams , Michal Hocko , linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org, Alex Williamson , Jason Gunthorpe , x86@kernel.org, Alistair Popple , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Ryan Roberts , Hugh Dickins , Axel Rasmussen References: <20240717220219.3743374-1-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5D3FD40007 X-Stat-Signature: zs7kki38534p9f3ow867nqdbxuwgh6r7 X-HE-Tag: 1721769728-182532 X-HE-Meta: U2FsdGVkX1+Yy42WXClw6T5ylbJ9F33hVsjMNufSVjFtL6GnxG8IsdhnPEiunFZw1P6S4AFotwus1SFwAC7loNcphDHArtT32l0OPDKKd5d5dho2YJ6KCf3uana0rLaj80NmeSIVXDUbGDHK9qaOVoIsowkEFMw409ungPtuxf22AztDo8oRw7vrcxu7WoDlqCj6780XL6XracYbyKMak4r4RN5o2rIBmTVqEtLwQYnIqAP8Y/YHaKg6gFXGgM0PbE99r16QvvIZHwrZL9bkZfvXu+jtMVjeaNfik+bbA6/etx8dMIlfvR4GK/IMq+jSBCppWRLU5iBLhk9rNNuCKke7074PbeyRvegJWlu7UBVwkitPiL8VLaxgaVciT8+VPL8LB2L/W6nYlomDVZC+d8Y6rbauZYyOPNDO0EfMOFzS0EBX9UzQLw64vlB/UOPAHWVR2jVITjOIsMIMKKV9pVcJEWZNlYKTLn1uZj65Az1aDrozhm7I764cw/wPRl/OKgSMLBQJdgYBxS8v7aEZ1NIDNaWlNTQJiRNjvUsL+hVv2NsC7aZrk454I6HAMi+sQnZrU/NI2UPgCaMkgr6ghxoMP6gZnIGRl7xsjzG6ccZszGnAECiOEVrd4B9vw6XtarWmvNy1N+ZETnC0nKIAqgk9+9cf8yaALCmrYgAUDGBHHE2hOazrdrytqL9SRgZfwr3C6qir5lPUKi7rVdHd+TId/a6fGZ6hPRIOPSQUA9FhTWiVO99q8ZNzmL5alQEn/ci6jhrxA183m4j5U9ftTlYADtBToJH6Yj2er/jF2T6pmOl7s03jQq3wAcUgqhCZzMO4v8+9acsmKATUKCk4dplB+otZabiFnL+qzz9tZCLEgOCBQyLa2g0vrs3nJHYLWkYr3xNXAtp4I7fSg7CB72z1D1V4a4G1z3tODJ6Dw/Sf5vmIPay6YDGvkpkWPlInrRrzeqzNt2UFhI4QFtl j5kqJ4J4 idi1rOyjQignu1Fdp9l2Si/9hnWJFYdVWNcTt62XTu5Pe1A6l4+UFmnozptnUPafpBjrDORLVf3H1BGJW0OYPY86VfAcwn4z/r9YruiBxkL5Yv5npWimxn/g6mVr5HTt/KyPJ2v+jh5A4ICEV6MMsX1EuxsyBp+yslKSMIemSzJoJj17oahQqoPHWwjFONqF6fDlvDmXokIPEj6xafBH+nXEXGrhaA0dnJgNTI7r7OCwFmSzmWizNalnbRROf/cAfzozlbn59OvMbjFOKpPE3X6ttXku1ZoFcHOQdms5nfLgUWdT+5dCyetUu6pK1ZzpSWSzY5/jTXp70c3jegxBYWPCQClgNkAz5hc2D/eGK8eegikTtxzYfPAAEIlKB7P72TdzMQbr89dxF1cOxA7RjPzX8+8TIhFk4fr4qvBETw74oCGIxjiJQuyjGz0uVQwhlRF9ncIea1Z/QgRvWfwq/Zy55o/HCSXkE2KA/epK4IVmCOXCZKu2b3SPl810f5NiGGngZG9YKIlityoABTt89Yq7WwvpwfIZQt0zMQ8OCh6Y87VM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.07.24 23:04, Peter Xu wrote: > On Tue, Jul 23, 2024 at 10:18:37AM +0200, David Hildenbrand wrote: >> On 22.07.24 17:31, Peter Xu wrote: >>> On Mon, Jul 22, 2024 at 03:29:43PM +0200, David Hildenbrand wrote: >>>> On 18.07.24 00:02, Peter Xu wrote: >>>>> This is an RFC series, so not yet for merging. Please don't be scared by >>>>> the code changes: most of them are code movements only. >>>>> >>>>> This series is based on the dax mprotect fix series here (while that one is >>>>> based on mm-unstable): >>>>> >>>>> [PATCH v3 0/8] mm/mprotect: Fix dax puds >>>>> https://lore.kernel.org/r/20240715192142.3241557-1-peterx@redhat.com >>>>> >>>>> Overview >>>>> ======== >>>>> >>>>> This series doesn't provide any feature change. The only goal of this >>>>> series is to start decoupling two ideas: "THP" and "huge mapping". We >>>>> already started with having PGTABLE_HAS_HUGE_LEAVES config option, and this >>>>> one extends that idea into the code. >>>>> >>>>> The issue is that we have so many functions that only compile with >>>>> CONFIG_THP=on, even though they're about huge mappings, and huge mapping is >>>>> a pretty common concept, which can apply to many things besides THPs >>>>> nowadays. The major THP file is mm/huge_memory.c as of now. >>>>> >>>>> The first example of such huge mapping users will be hugetlb. We lived >>>>> until now with no problem simply because Linux almost duplicated all the >>>>> logics there in the "THP" files into hugetlb APIs. If we want to get rid >>>>> of hugetlb specific APIs and paths, this _might_ be the first thing we want >>>>> to do, because we want to be able to e.g., zapping a hugetlb pmd entry even >>>>> if !CONFIG_THP. >>>>> >>>>> Then consider other things like dax / pfnmaps. Dax can depend on THP, then >>>>> it'll naturally be able to use pmd/pud helpers, that's okay. However is it >>>>> a must? Do we also want to have every new pmd/pud mappings in the future >>>>> to depend on THP (like PFNMAP)? My answer is no, but I'm open to opinions. >>>>> >>>>> If anyone agrees with me that "huge mapping" (aka, PMD/PUD mappings that >>>>> are larger than PAGE_SIZE) is a more generic concept than THP, then I think >>>>> at some point we need to move the generic code out of THP code into a >>>>> common code base. >>>>> >>>>> This is what this series does as a start. >>>> >>>> Hi Peter! >>>> >>>> From a quick glimpse, patch #1-#4 do make sense independent of patch #5. >>>> >>>> I am not so sure about all of the code movement in patch #5. If large folios >>>> are the future, then likely huge_memory.c should simply be the home for all >>>> that logic. >>>> >>>> Maybe the goal should better be to compile huge_memory.c not only for THP, >>>> but also for other use cases that require that logic, and fence off all THP >>>> specific stuff using #ifdef? >>>> >>>> Not sure, though. But a lot of this code movements/churn might be avoidable. >>> >>> I'm fine using ifdefs in the current fine, but IMHO it's a matter of >>> whether we want to keep huge_memory.c growing into even larger file, and >>> keep all large folio logics only in that file. Currently it's ~4000 LOCs. >> >> Depends on "how much" for sure. huge_memory.c is currently on place 12 of >> the biggest files in mm/. So there might not be immediate cause for action >> ... just yet :) [guess which file is on #2 :) ] > > 7821, hugetlb.c > 7602, vmscan.c > 7275, slub.c > 7072, page_alloc.c > 6673, memory.c > 5402, memcontrol.c > 5239, shmem.c > 5155, vmalloc.c > 4419, filemap.c > 4060, mmap.c > 3882, huge_memory.c > > IMHO a split is normally better than keeping everything in one file, but > yeah I'd confess THP file isn't that bad comparing to others.. And I'm > definitely surprised it's even out of top ten. It's always interesting looking at the numbers here. For v6.10 we had: 8521 mm/memcontrol.c 7813 mm/hugetlb.c 7550 mm/vmscan.c 7266 mm/slub.c 7018 mm/page_alloc.c 6468 mm/memory.c 5154 mm/vmalloc.c 5002 mm/shmem.c 4419 mm/filemap.c 4019 mm/mmap.c 3954 mm/ksm.c 3740 mm/swapfile.c 3730 mm/huge_memory.c 3689 mm/gup.c 3542 mm/mempolicy.c I suspect memcontrol.c shrunk because of the v1 split-off, leaving hugetlb.c now at #1 :) -- Cheers, David / dhildenb