From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46BEECAAD3 for ; Fri, 9 Sep 2022 11:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64CE58D0003; Fri, 9 Sep 2022 07:32:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D63A8D0002; Fri, 9 Sep 2022 07:32:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 476FF8D0003; Fri, 9 Sep 2022 07:32:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 38EEB8D0002 for ; Fri, 9 Sep 2022 07:32:03 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 087741204CF for ; Fri, 9 Sep 2022 11:32:03 +0000 (UTC) X-FDA: 79892332926.04.573DBF6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 68639C009C for ; Fri, 9 Sep 2022 11:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662723121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F2oeKJx7G2NhC1w+c8eq8auddLUonMGciT45UzuZW/c=; b=SSJ3MyApK20PzooT9aFOis7iX44qV7PhaNKsaBT8d+DYA9jvx+FQZHB2QcrOMdJ67wDQKj zf7sv1PhlIyZ40kZVQfT3bfYGI0qxE6ZA2kHnjS9lH5z4x89bXZ4wJjBNSjSQkcaWQ49cl H/0kXqRVwIP09mPQlMWQEjilQpZ9Dtk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-70-ChO4ZYliOUKXsnaNAKUE3A-1; Fri, 09 Sep 2022 07:31:53 -0400 X-MC-Unique: ChO4ZYliOUKXsnaNAKUE3A-1 Received: by mail-wr1-f71.google.com with SMTP id i29-20020adfa51d000000b00228fa8325c0so278801wrb.15 for ; Fri, 09 Sep 2022 04:31:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=F2oeKJx7G2NhC1w+c8eq8auddLUonMGciT45UzuZW/c=; b=td1fqrlureLoLNvzw15EQCyuRZH7BZ4FuyKZ2Ygj0PMoJer4SApiCzzJqKpLdLgcop FZE9ci2DH7bU3o1uv7SZOufHr2u1jfLaYC44k7q4TA6hg3FwNbiSWjBHaeQxdeXOg93p xF5xoEZP0+/+iHnDtww/gM4HXM8Qkd+owDYLaFRTNyvEfIS5rER77d20kWP5krfoM9g8 ejjQSNkniTvTUji867NYtai056EsIIq+qnLbPIx9tQLMhia/mBXB9RfW/AJopOFN9sGl EzysJKi1mxrTOxxGv20Nz2cjDmCFJLh4onJ5xxQ6vccBiawAFRHC40Va/WCJQndnUDd7 p8ug== X-Gm-Message-State: ACgBeo2P45zdazSY8Yqssg8J4jiNEwHPp0TrfzCwb2spQ/tXJaZNcfFu lNJccHBkGh6e3btiaBXjxnQ1xB+0A+jDdcF9IEL9NecksXJ4au+ofY3o33wbHbg5LKMz4HuSpUN P8H7sbpWCcIs= X-Received: by 2002:a05:600c:5106:b0:3a8:411c:7366 with SMTP id o6-20020a05600c510600b003a8411c7366mr5143744wms.204.1662723112175; Fri, 09 Sep 2022 04:31:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR4QJQF19h8ckQdSAMcJvVPq2I7tGt7Zut0J/2lOWjNSEOrT6l2tVEyQ/4I7Omip4It4QstTNg== X-Received: by 2002:a05:600c:5106:b0:3a8:411c:7366 with SMTP id o6-20020a05600c510600b003a8411c7366mr5143728wms.204.1662723111895; Fri, 09 Sep 2022 04:31:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id j24-20020a05600c1c1800b003a8434530bbsm494211wms.13.2022.09.09.04.31.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:31:51 -0700 (PDT) Message-ID: <270fbfd7-bf16-e3cc-85c3-21acd0587d94@redhat.com> Date: Fri, 9 Sep 2022 13:31:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 09/16] mm/page_alloc: use local variable zone_idx directly To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-10-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-10-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662723122; a=rsa-sha256; cv=none; b=2V/F8G8zAvs7cC2fIaz9EwbOktrhvx4qdutCTjHtV9P56ChHOfnJbiu2+O9qD99Jup+hW3 tmr8LIptMJoG0dElUCq0XgwA0oecvfKdM2gLMLB6+mtEHm2i3Qv9I1fOdmgRigEc1U5ACy +9Lkv/U9Z7TMwriIsoQE+cACvHQrN6k= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SSJ3MyAp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662723122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F2oeKJx7G2NhC1w+c8eq8auddLUonMGciT45UzuZW/c=; b=XfgTkioftAEjG5Svz3pCK7qZU6kiEi+yxHV5S9t2yRQDZSz/PARwhwc9u8YIvM8M5vTmg3 CaRr3FA1odsipbSd9gnFVeaXgi9h26PPUOzEgFo368b/rfZFP/9SaFy6T5JxfS/BYpU90a uSuQtDInog1YPtHgIzQnhMpsY796Lok= X-Rspam-User: X-Rspamd-Server: rspam05 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SSJ3MyAp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Stat-Signature: zd8zmn8d8e4fpad5678qrn961drmy896 X-Rspamd-Queue-Id: 68639C009C X-HE-Tag: 1662723122-835947 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > Use local variable zone_idx directly since it holds the exact value of > zone_idx(). No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 94baf33da865..3417232afa45 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6878,7 +6878,7 @@ void __ref memmap_init_zone_device(struct zone *zone, > unsigned long start = jiffies; > int nid = pgdat->node_id; > > - if (WARN_ON_ONCE(!pgmap || zone_idx(zone) != ZONE_DEVICE)) > + if (WARN_ON_ONCE(!pgmap || zone_idx != ZONE_DEVICE)) > return; > > /* Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb