From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DFCC48BCF for ; Wed, 9 Jun 2021 10:52:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E7EC7613AD for ; Wed, 9 Jun 2021 10:52:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7EC7613AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 820E36B0036; Wed, 9 Jun 2021 06:52:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F6916B006E; Wed, 9 Jun 2021 06:52:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 697C26B0070; Wed, 9 Jun 2021 06:52:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 3AD436B0036 for ; Wed, 9 Jun 2021 06:52:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C3084181AEF23 for ; Wed, 9 Jun 2021 10:52:16 +0000 (UTC) X-FDA: 78233871072.17.9169621 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 72E1F2001060 for ; Wed, 9 Jun 2021 10:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623235935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZPPxlVuFpma5nN0KBwsgNEj1D60a3U+wCT7M5MPOro=; b=Km5r1M+sxIq4QxvZF6wtjHOv+NX0GD/tnBHzME3FShlP42FQZPxI28LSs2skwcRMKR6KJh 0XJz2rmTh/jJT0lX2DtPOYM/XEAPwKAOmVwutgOGYzNlj3DmYYtDvRxwcjs6H58IXcjOxC UvVr5TV7PvMy2NUxlLSDVJZr9BvC36k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-DrEMLsU7M-aOKOxW9Mwmvg-1; Wed, 09 Jun 2021 06:52:14 -0400 X-MC-Unique: DrEMLsU7M-aOKOxW9Mwmvg-1 Received: by mail-wr1-f70.google.com with SMTP id k25-20020a5d52590000b0290114dee5b660so10617156wrc.16 for ; Wed, 09 Jun 2021 03:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=VZPPxlVuFpma5nN0KBwsgNEj1D60a3U+wCT7M5MPOro=; b=kG9DUBLtfOaig8GvIE439sq/LR6YuNGL6b4Uz+R3jax4S7ruJri+7TT6zUg/zxH/3v isNcycQhry7FFmIzB1JIMcBgygzV9cW4iNEKadvoeweXQXXuSpaOxPVhIwz8vXATW/QL QwW/+jyLve2HX+e2pkAxsGCpcEZNyBE/yneKsBkVrNyM1jPO+xkyOCsKTAQJmtdmwp4D S1zG7COTBbf1UKg/dpuha8DIvlR6AHSdQa0jN35LldhClsLF1S93hhUyXkKx/QsieGX2 l4CLPwb3J1qU3yK9sUN+CJLu/F/qSqwQnCD3v8BYCKRWNq3SOYRc4ncR0zZjfdis582U mPzQ== X-Gm-Message-State: AOAM532LbpFQzyol8dW2PdP/cplbsWdMnKIwkpegsZ2EeYyaEfU84AiP Th7vv7V6SC2TMjQObzwzenUy9TRXOhrLNv8lXzTvYwxOkmeOV11yUuih9Xzq8uDwdsvQYImXPIe 2B/n8NEOyXWI= X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr26528246wmm.156.1623235933484; Wed, 09 Jun 2021 03:52:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOhpm0kR/qb02GnRlZAdwrQqqdavzoWPuk2BGBrMztminfq9lmdrK+j2M/FH+Xh9QtwaeMHg== X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr26528228wmm.156.1623235933268; Wed, 09 Jun 2021 03:52:13 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id 89sm25391165wrq.14.2021.06.09.03.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:52:13 -0700 (PDT) Subject: Re: [PATCH 2/9] arc: update comment about HIGHMEM implementation To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Geert Uytterhoeven , Ivan Kokshaysky , Jonathan Corbet , Matt Turner , Mike Rapoport , Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org References: <20210602105348.13387-1-rppt@kernel.org> <20210602105348.13387-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <2764dca8-f395-f76a-0939-215eccdfd82e@redhat.com> Date: Wed, 9 Jun 2021 12:52:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602105348.13387-3-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 72E1F2001060 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Km5r1M+s; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 7xa19wsnnpoi7ksk3eywy3b78o1aru1r X-HE-Tag: 1623235932-124888 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.06.21 12:53, Mike Rapoport wrote: > From: Mike Rapoport > > Arc does not use DISCONTIGMEM to implement high memory, update the comment > describing how high memory works to reflect this. > > Signed-off-by: Mike Rapoport > --- > arch/arc/mm/init.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/arch/arc/mm/init.c b/arch/arc/mm/init.c > index e2ed355438c9..397a201adfe3 100644 > --- a/arch/arc/mm/init.c > +++ b/arch/arc/mm/init.c > @@ -139,16 +139,13 @@ void __init setup_arch_memory(void) > > #ifdef CONFIG_HIGHMEM > /* > - * Populate a new node with highmem > - * > * On ARC (w/o PAE) HIGHMEM addresses are actually smaller (0 based) > - * than addresses in normal ala low memory (0x8000_0000 based). > + * than addresses in normal aka low memory (0x8000_0000 based). > * Even with PAE, the huge peripheral space hole would waste a lot of > - * mem with single mem_map[]. This warrants a mem_map per region design. > - * Thus HIGHMEM on ARC is imlemented with DISCONTIGMEM. > - * > - * DISCONTIGMEM in turns requires multiple nodes. node 0 above is > - * populated with normal memory zone while node 1 only has highmem > + * mem with single contiguous mem_map[]. > + * Thus when HIGHMEM on ARC is enabled the memory map corresponding > + * to the hole is freed and ARC specific version of pfn_valid() > + * handles the hole in the memory map. > */ > #ifdef CONFIG_DISCONTIGMEM > node_set_online(1); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb