From: David Howells <dhowells@redhat.com>
To: Nick Piggin <npiggin@suse.de>
Cc: dhowells@redhat.com, torvalds@osdl.org,
akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com,
corbet@lwn.net, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] radix_tree_tag_get() is not as safe as the docs make out
Date: Tue, 06 Apr 2010 22:18:58 +0100 [thread overview]
Message-ID: <27834.1270588738@redhat.com> (raw)
In-Reply-To: <20100406194843.GJ5288@laptop>
Nick Piggin <npiggin@suse.de> wrote:
> Nack, just drop the BUG_ON.
I can do that.
> I don't know what you mean by "untrustworthy answer".
I was thinking that the answer you get from radix_tree_tag_get() may be invalid
if the tag chain is being modified as you read it. So if you do:
rcu_read_lock()
...
x = radix_tree_tag_get(r, i, t);
...
y = radix_tree_tag_get(r, i, t);
...
rcu_read_unlock()
Then you can't guarantee that x == y, even though you were holding the RCU read
lock.
As you suggested, I'll try and come up with a comment modification to this
effect.
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-04-06 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 19:31 [PATCH] radix_tree_tag_get() is not as safe as the docs make out David Howells
2010-04-06 19:39 ` Linus Torvalds
2010-04-06 19:48 ` Nick Piggin
2010-04-06 21:12 ` David Howells
2010-04-06 21:18 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27834.1270588738@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).