From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F26ECAAD3 for ; Fri, 9 Sep 2022 11:27:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E9418D0003; Fri, 9 Sep 2022 07:27:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 697B38D0002; Fri, 9 Sep 2022 07:27:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5608E8D0003; Fri, 9 Sep 2022 07:27:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 47FA38D0002 for ; Fri, 9 Sep 2022 07:27:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 20DBC1613E0 for ; Fri, 9 Sep 2022 11:27:54 +0000 (UTC) X-FDA: 79892322468.20.AE356A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id A1E6C10008B for ; Fri, 9 Sep 2022 11:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662722873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CpDkHaXnSCsM/ZoB4suIHBbFFXOjSmaxDG4e8GA+GC8=; b=PV3hacalNKlJ0FaX7XRUyF+bY8PPDsnv8GcKVrnBOFah9hdbVBgDQSE3DLPLtAwlkwZN4K oWEIXQ30HOrEheZNYI4bAX3f2o6DxXamZW3aBfTyUNvBZtMxLGJ+4RYr4ZgKD1TWJpatM+ gxjX3i34xNe0QsIfn5+NAk5ogWMwB4U= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-375--Zxqzn9uNWqURh2LK452SQ-1; Fri, 09 Sep 2022 07:27:52 -0400 X-MC-Unique: -Zxqzn9uNWqURh2LK452SQ-1 Received: by mail-wm1-f70.google.com with SMTP id a17-20020a05600c349100b003a545125f6eso2628855wmq.4 for ; Fri, 09 Sep 2022 04:27:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=CpDkHaXnSCsM/ZoB4suIHBbFFXOjSmaxDG4e8GA+GC8=; b=nbjzPl7D1jz1kN/qwJLTHkWzBqD12v0QGk+0SCGn7dtgVsnqbjxtaoAyfbwEOdaXkc jHsxRGkIv4tSBCRtrnTKgE+szSdp107APcdup9Md+ZgtG+ULZ+n+a74O3idlkNUA4Zyu WxrjWi2f4O0WwVuFvW2cgP2PviZj+hRQkHZUpAzKfcT6vSj/GrjcFOKwUHI2y0QFI6QS C7FCdinNePRWNCIl1AOkpQar+QjMfLl3ixLgpsqH997kRhDd2A3UcE02Yzkk6C7Tz60p Ht3ug4dtoZBBo1lFBYYnbSU3knmD0GpDaLpOsP9OrhxvTvmKVh03WazEW2kdeQnFFTXm vK4A== X-Gm-Message-State: ACgBeo30OL4mkt8QrWBLjNoVBmtihE2pVmIvy8viMVKRbveMdYPYDgQ7 eEt+4MjCdIO4iAccLip0jdRlUWvRYEH8JKYQLexpKjwxyeZP9kmthER0aTlvFxHD/5F2KWR9jb8 y8JvxZrTUlGk= X-Received: by 2002:a05:600c:4148:b0:3a5:4f94:577b with SMTP id h8-20020a05600c414800b003a54f94577bmr5277062wmm.167.1662722870965; Fri, 09 Sep 2022 04:27:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR7ID9YjImwe7Jx4eKIMHs9zUvU8ficM9t1XwGQlYU82810wLPJqZGwwt6OEcD5IyqWX2Z32CQ== X-Received: by 2002:a05:600c:4148:b0:3a5:4f94:577b with SMTP id h8-20020a05600c414800b003a54f94577bmr5277051wmm.167.1662722870743; Fri, 09 Sep 2022 04:27:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id bg14-20020a05600c3c8e00b003a840690609sm525048wmb.36.2022.09.09.04.27.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:27:50 -0700 (PDT) Message-ID: <27b09e1e-21dc-33ac-f26b-86ab74d25bed@redhat.com> Date: Fri, 9 Sep 2022 13:27:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 05/16] mm/page_alloc: add __init annotations to init_mem_debugging_and_hardening() To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-6-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-6-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PV3hacal; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662722873; a=rsa-sha256; cv=none; b=I8fApQboTHJ6VDeO+n+TSN4MQPF76i7040+T2zNcehK6QWU7O4srpPO4m/XY64/CmuhgPs OMF5iecUeyq0zvlQnTElQ3lnxP36B+14de/DoxY4zhFxs3SL6vXAlOYfm2cdpBneryyDx5 BhMdVFbaE/2llJ+eFT39OkpUAAZIRJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662722873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CpDkHaXnSCsM/ZoB4suIHBbFFXOjSmaxDG4e8GA+GC8=; b=rbX046HR7NfAtzUhI2yq/dywuGBl++mjytHj54I0Hsjhj4bBuVHr/kUwqinbT70DJZFdI1 GEpcfqwoNbn9FVAk2Pe937o6yC1prhPaSrH/pB3iNnpcwVNW7PqZye9EBIN6NFnS67LSWD fRAdsL2U4R8W1SC18F1VEfnfs0VjbNc= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PV3hacal; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: fkddswbcoembdojphg138n9myjg9doah X-Rspamd-Queue-Id: A1E6C10008B X-HE-Tag: 1662722873-583035 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > It's only called by mm_init(). Add __init annotations to it. > > Signed-off-by: Miaohe Lin > --- > include/linux/mm.h | 2 +- > mm/page_alloc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 364bcadb4d20..c2277f5aba9e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3093,7 +3093,7 @@ extern int apply_to_existing_page_range(struct mm_struct *mm, > unsigned long address, unsigned long size, > pte_fn_t fn, void *data); > > -extern void init_mem_debugging_and_hardening(void); > +extern void __init init_mem_debugging_and_hardening(void); > #ifdef CONFIG_PAGE_POISONING > extern void __kernel_poison_pages(struct page *page, int numpages); > extern void __kernel_unpoison_pages(struct page *page, int numpages); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index c81f06d8a4f5..3497919f4ef5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -903,7 +903,7 @@ static inline void clear_page_guard(struct zone *zone, struct page *page, > * order of appearance. So we need to first gather the full picture of what was > * enabled, and then make decisions. > */ > -void init_mem_debugging_and_hardening(void) > +void __init init_mem_debugging_and_hardening(void) > { > bool page_poisoning_requested = false; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb