From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188E8D462A5 for ; Wed, 13 Nov 2024 14:07:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E9486B00B0; Wed, 13 Nov 2024 09:07:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 672806B00B1; Wed, 13 Nov 2024 09:07:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C6926B00B3; Wed, 13 Nov 2024 09:07:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A0CC6B00B0 for ; Wed, 13 Nov 2024 09:07:25 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C760A1A0A39 for ; Wed, 13 Nov 2024 14:07:24 +0000 (UTC) X-FDA: 82781248788.28.E1EAB94 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 897FA10002E for ; Wed, 13 Nov 2024 14:06:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=IQpawc2M; dmarc=none; spf=pass (imf05.hostedemail.com: domain of axboe@kernel.dk designates 209.85.160.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731506779; a=rsa-sha256; cv=none; b=rhDvRWNjQ1TXzJItYqKdHa52N8jflE0tqp1nRXdzFRKZwZJbTQ+7bS9IhjNzxkcZ2SNfNG 7EYBBFeDFIReXfXUYRHwHXiMdpHESbMizB1KjXTAWhQGr85RiewnoJg2Un5tB+xODYUpl+ s/WhBZrZ4snmFcI3JR/XefkFqpfa5gw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=IQpawc2M; dmarc=none; spf=pass (imf05.hostedemail.com: domain of axboe@kernel.dk designates 209.85.160.54 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731506779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C7W+yd2pa7dbAq2BPJ7ZVQ3S890XNBOMrajqML3cc6g=; b=t/j1Lrpf+U1D/wHGiR6gaM8XeTsuqvr1G6pb8hkma9pGIXy5+8mmvMIcqQTZmoJW6zRiKV 7oSoO19mW9wPsx8gebu4k0z69m5C4Xfd2c7UdLJexg3/2aqfud6Y/w61OEdqwl/fxHL2Yt d61J9f0SkBFtiiHorgMNMCnugip3nNE= Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-28845df360fso355355fac.1 for ; Wed, 13 Nov 2024 06:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731506841; x=1732111641; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=C7W+yd2pa7dbAq2BPJ7ZVQ3S890XNBOMrajqML3cc6g=; b=IQpawc2My8vui6xvXWsbhGCz1knDVi6TfaA20wdXjke1JYsivva0v+f/NvV0SFlbcX LH3misPYW7/bgQ0NpxXgTkY6Q/N43OhtfPETQtldrdc8QC5pV3pmfcZivK4WbKoIeDJu eLQ/fvSfSfm3g3ALmjcPddihhgGH10fVOe2EwWxnUUNNimF3l7EnDZseTPL86wZiqC8L 9ASotxgWc9lZRFa+Jea/LURKM3sfjl4OHa+pyflmsuwuRRy1PUmQbmj3BKPc6/s81HUJ SGAqWKPLn7yGY6srOGRk6wmd7PTVCwh7NXwZ/67tjkr4vuDf/ibcSYTkuAbpRa5qN1PH yRsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731506841; x=1732111641; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C7W+yd2pa7dbAq2BPJ7ZVQ3S890XNBOMrajqML3cc6g=; b=Gca9gnXxwujZhmKU17N8oj5io2qGTPD4Vzz5bXc3RskTA7ohGPTLcU0sizgzdVmdDG IWNRhUcFpmRCFIEYn+I1cn0sL/7008iqDXJG51mjivOZwiURwPgYou/HdTx7FzvH/0xu JFD0ronoDh92fn8PWql3jIqTIHFp8Hvb4En8BIdtOmTQjSn9k/JCVlr6CnTSlxNobHfz UNr9InvW5+0/ZE/CvLddsSxtoY9MkU0J86xSLFvUFa/S+AYTGotMVF2XxqxTdb2ianVD hwjeaadPS4Gs8+0AuQ3RZb2N3EUf6G+7qPwjfPe2gkcbYLwh6O+gFzAzZF7f/RJTG6f9 knuQ== X-Forwarded-Encrypted: i=1; AJvYcCXn6QK6RQdWHB4Qk3oFtDp/iFJdvSdD9g7w/ErViPl0OKIBmyG0QodX0DKFQwBdgJOk1vIQWwnBmQ==@kvack.org X-Gm-Message-State: AOJu0YxjF04Q+QuHajOWwwQ4AUv0+TKGQC6X+WoRtaJdynqxpk7ztkEP PIEnwxVsA+/kv2G8ZrpFhUiVNQzgEITDaz/tC5H6zLyDJBX8Zh6KIuKMxSG79k0= X-Google-Smtp-Source: AGHT+IEhQtwJqw8FYkoHlxC5JPevShyCoOPyIG4UY1W3uspVlh/+ActuzVEUskOUpaeDpHYJeA9Tgw== X-Received: by 2002:a05:6870:198d:b0:27b:a693:fa11 with SMTP id 586e51a60fabf-2955c59baebmr11328407fac.19.1731506841530; Wed, 13 Nov 2024 06:07:21 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-295e8f5f81esm714501fac.20.2024.11.13.06.07.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Nov 2024 06:07:20 -0800 (PST) Message-ID: <27cd53e0-981e-42f0-b965-e9e2cf3d5894@kernel.dk> Date: Wed, 13 Nov 2024 07:07:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/15] mm/filemap: add read support for RWF_UNCACHED From: Jens Axboe To: Brian Foster Cc: Christoph Hellwig , "Kirill A. Shutemov" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org References: <3da73668-a954-47b9-b66d-bb2e719f5590@kernel.dk> <7a4ef71f-905e-4f2a-b3d2-8fd939c5a865@kernel.dk> <3f378e51-87e7-499e-a9fb-4810ca760d2b@kernel.dk> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 897FA10002E X-Rspamd-Server: rspam11 X-Stat-Signature: a5hszae75cbjjt81o489wtd5r46ymu49 X-HE-Tag: 1731506761-410307 X-HE-Meta: U2FsdGVkX1/lIT+iFd0RsjRak4S61BpNT6pP/QTp5khkRYUx/lLvQLkQM7Re549KcIMNqF8cZ2ojug+T8dsvn7C7VJul4z+gKz7IZGfj3iOeTCv2JfIGnd+sjZtTrnV2WyujoauutFY/ecTkaarl6yrjrBMBfEsNgx8OKA7EjYijkNmfe8jfsHTfYGYMPMl+cvLCrF2RkDxDSEXyaw3sQroJQ38FbSgoVX1om6g729WQY9ys41hCm6SOnzMhvczvL/VOPCJy46vg+xZhNAgx0B0MIHWo+b6OpZYV18nbP1HRIM8FkQHoCwTLMVCoBaX9UjHDcaOmpu7nFRIMkHPHeBvvQEk6gvnWmOgasw45SkE65s+5dxItxjTYSnvwrO705Lw+nHNfQ8PquM6ySAjnog+7j5Xs7vQ9yL47xxdPfMjZ5hErhZ+KLonaPNBXZi1mrmysSEmkJBnHS7CT+E58AoL+SwoFbEwhFvWJymT7QKdQPgxa5id2grY7Q6esN+3fnyHM0y5pMqTu9bTXMQ3i4NahdJ0rneWIn7xTArQ6NBY9f/afhBrgqOatraaFOXY32Yytf64uNd43Ry+g7FQhx9YMe5N4OTGlipfnCAFHXFbOdq8I/Qd3d5EHuQiRj9dlvUMJqNSo3PDeLlGtkyK5cizQX9D1YSGeAYpZS4CprrLrGgPIg0k757udJlipQiP7xoolC/tm5PFQ/IY1xf0OGTh1FubrLvE6s5HEZbVdDLu+QLA/j2QFqHoGe8/Yt7cEOzKTL70Ajf7dEhTg3+7VuAl2NU4eUfkijmNXTr71ZoTkDE5LPZ/kY1OY6I/zvqC3FOFnhTJsF4RcRwtl7LFS+/rx8HuODzJt7UM6wRPL36xJR0IOmYCXoy8motqEUopktSsVD82DlCh9kBImgFk1C3sNjLbJRURJhaydiiKG07tqzMOG57Pi/wfzqrZLTf2S4ax3UdJAVYmtLPs7GuK /EJ8JY+4 DWY0+a/D4e+m76/bUaQzXbe3FCJP51SFcjNBUaxteysrVKphrupOe27LY0PMsGl2vv7Ft+QpOYjdfdyBh9L0oyCCU2b2Io5dqhQohgRWY8Jz8XihyWer82/sppdyprDR9wFLrcnxFtbJchd0sPnfY8Ee1/j3zWN6Xk+uNU5EJ/7/cH7zCKMAumeV7v+ZyOSLC+eVNedwlDbDGDBv9yquSL+hPCPgxZ0cht+ldQFjhGqdP6em5NDMk8CFmH1UkML6ur8PN03W4k5HVrxoUGbYui/9SFHpCUv1MzkP72Wz/40Z+kQEHHTSSiK4H/N3ASl7gkSaDslehQtqwnZMacPoiDTGO1IyDBFe63bew6E82/d67+cR0zIW3HXYAGq75IiCpl7HB4sQTbBEMT7YAuAFMDxfqycKMK4+wcN+YaOzFVlRFgFDl8G+/VUSkh5XoHAzZvpwKzwpwnalSPjk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/12/24 1:25 PM, Jens Axboe wrote: >>>>>> BTW, I should have also mentioned that fsx is also useful for longer >>>>>> soak testing. I.e., fstests will provide a decent amount of coverage as >>>>>> is via the various preexisting tests, but I'll occasionally run fsx >>>>>> directly and let it run overnight or something to get the op count at >>>>>> least up in the 100 millions or so to have a little more confidence >>>>>> there isn't some rare/subtle bug lurking. That might be helpful with >>>>>> something like this. JFYI. >>>>> >>>>> Good suggestion, I can leave it running overnight here as well. Since >>>>> I'm not super familiar with it, what would be a good set of parameters >>>>> to run it with? >>>>> >>>> >>>> Most things are on by default, so I'd probably just go with that. -p is >>>> useful to get occasional status output on how many operations have >>>> completed and you could consider increasing the max file size with -l, >>>> but usually I don't use more than a few MB or so if I increase it at >>>> all. >>> >>> When you say default, I'd run it without arguments. And then it does >>> nothing :-) >>> >>> Not an fs guy, I never run fsx. I run xfstests if I make changes that >>> may impact the page cache, writeback, or file systems. >>> >>> IOW, consider this a "I'm asking my mom to run fsx, I need to be pretty >>> specific" ;-) >>> >> >> Heh. In that case I'd just run something like this: >> >> fsx -p 100000 >> >> ... and see how long it survives. It may not necessarily be an uncached >> I/O problem if it fails, but depending on how reproducible a failure is, >> that's where a cli knob comes in handy. > > OK good, will give that a spin. Ran overnight, no issues seen. Just terminated the process. For funsies, I also added RWF_UNCACHED support to qemu and had the vm booted with that as well, to get some host side testing too. Everything looks fine. This is running: https://git.kernel.dk/cgit/linux/log/?h=buffered-uncached.7 which is the current branch. -- Jens Axboe