From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 498CBC5AD49 for ; Tue, 3 Jun 2025 16:57:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D552A6B04C2; Tue, 3 Jun 2025 12:57:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE35D6B04C4; Tue, 3 Jun 2025 12:57:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA61F6B04C5; Tue, 3 Jun 2025 12:57:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9A99B6B04C2 for ; Tue, 3 Jun 2025 12:57:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3DF24EE379 for ; Tue, 3 Jun 2025 16:57:48 +0000 (UTC) X-FDA: 83514696216.16.E686DB6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 9CB5740009 for ; Tue, 3 Jun 2025 16:57:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MCYGYca7; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748969865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TsWufTxM6T/lOznMAum9LyTlhueOavo6JnEpttTHknM=; b=dJnjaH9Z4OG8QYeYuIMM1dqvWA1fd1bMlE9WKG25VPyUpmU+YoF/e6S2ad2/zLOU/rVRZi RtBORrFO1FTJ/azMRn4vJ0w+qlWo8FFL/dFrpY4jPxo7WyBrQz5PuQ/8ZACi41Y0R00CB6 8X15JZSvqUjq9rylPjA+rpkQ43tvrlU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MCYGYca7; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748969865; a=rsa-sha256; cv=none; b=KV8k+o+P6K5rRmkiWi5cucVO86QApKg92DLtSr6yKi5HBM5ge0jPhGnQ4SgcUUbxDZ9xRc x9lfaK6eQiVzD/tcNz+G1p+RL2vZ3O7N9LCiaxcbo1Vl1T4iZUiyuTYDYTKeqJsbBDtNr1 o7JqXe0fJhaB5gSujwSlHeDvPcbGqVY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748969865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TsWufTxM6T/lOznMAum9LyTlhueOavo6JnEpttTHknM=; b=MCYGYca7g3pUVBRObsQjMsujNrygUUkc4weAIePG5hC644RJpdydaZp/qPQO4XbVFwLfXN YIdXL6KEXm4xYP7WGkgy3a2eRntqzXUet2xTh1iz+p2L1nthNsRnZex3Lpb6hYNrjN8MHZ 9N8i/s2e6eXgAq31wp1D5Z+a3iyTrQ4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-N9Sy205lMCm8NAoND_gGkQ-1; Tue, 03 Jun 2025 12:57:41 -0400 X-MC-Unique: N9Sy205lMCm8NAoND_gGkQ-1 X-Mimecast-MFC-AGG-ID: N9Sy205lMCm8NAoND_gGkQ_1748969860 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4eb6fcd88so3495438f8f.1 for ; Tue, 03 Jun 2025 09:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748969860; x=1749574660; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TsWufTxM6T/lOznMAum9LyTlhueOavo6JnEpttTHknM=; b=QXIpCsgAbOotpJ4L/fRSAPYSH63UO+cd6vA3ssXjtk0X8bKp2CQdw2QA9oFoJsrd4y MrhqJviqLtQJzw8c++45vfeE6OQPlcgbr5Lewq5Nrrm7IjA6b6Hax45TztzgA2RSI4nn xiXvaUGCLDltk11zh/XlzNux0F8z7dbadwkI3tWUNN7jxO/mWefagn1r0NfZ2kNMWldp WVI8VQJyt6w7b5ISGcmQa0RaFecYAvWyBHsJVFadW5h4iMedOdloSg2NlxNvHLSEdrmL K7SGS2d6CvTnvvRDJEqQj/ovNw6CdV2BQpBoakAJ27tCDJRvraFc5MLlLJC0ceoApmcE s2yA== X-Forwarded-Encrypted: i=1; AJvYcCXF746cqeOBfeDe2glTAYU58ns8aOl+bWT+Xh8I4dtCoRHfYbJiuDkRAHqr7ED8poehKQ/RkXgUvQ==@kvack.org X-Gm-Message-State: AOJu0Ywm0cMvwgArburiCzyUOhNp8oP3gNBNsheeVXAeeFVovkPzg33t eXvAG9B1sAf3YR8irFNFdL2nOeQY7mZmZruCSvkDoDsYdLEd+4O6A0AJZidoJ9EKRohYICqmWWF +8W70WR5Sc6NVJlZf6ZVIaPcMazTtdNRaOJdwUM7f43GtjZWS1xM1 X-Gm-Gg: ASbGncum3E/MuVHAR4eII0tUdBYTOEP80zqJcMeL7FhoraPVU7zMWuY0DVpxkB38dMZ F61AeGbHCB2ND7rnSgudOw5y5vjjf++g8i2sx85OEw85iKly3ZKcRxbpOolhP/wLkfVuJGlg6g/ Mj93xIVRIIYYDnOMUKStL9K7zU6TE5iFYUvnSuWz/zIyqKcWNX22VGkUppA9mDfei6OGlCqyFHM YXnKxcmuy/BSlExdQWRiHUHhkPusPAw3H9dHktYJFSn0UW8pBZZFd5I8p3JB2bJjCK5qHtq/X7p 1sRPozDpVBf1ODDENb7lkDDf1Qy3xzpxekTk3Gtv8HObLI3EAWFDFTCDUcIQtv+jRGA8TEM3bpo 1NJtfxsg4YBv7fLY+8EP7dvpSxiE4EdEgFSuj3iM= X-Received: by 2002:a05:6000:2008:b0:3a4:cfbf:51ae with SMTP id ffacd0b85a97d-3a4fe154ecfmr10333672f8f.4.1748969860441; Tue, 03 Jun 2025 09:57:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGgs6au14eWy2ITejaOEvH4DqqBrW7sZzo/zIVmyw7fLfiIoYIpcMV4FEg9HzXFEdWlhUtj8g== X-Received: by 2002:a05:6000:2008:b0:3a4:cfbf:51ae with SMTP id ffacd0b85a97d-3a4fe154ecfmr10333651f8f.4.1748969860033; Tue, 03 Jun 2025 09:57:40 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fa270csm171210165e9.16.2025.06.03.09.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 09:57:39 -0700 (PDT) Message-ID: <27f74a9c-8bf9-4877-ba14-82dcd79f6d0d@redhat.com> Date: Tue, 3 Jun 2025 18:57:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] selftests/mm: Report unique test names for each cow test To: Mark Brown Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-3-ff198df8e38e@kernel.org> <9961082f-848d-43d3-b97d-3df675ca4415@sirena.org.uk> <4676a010-a977-4d5a-b42a-edbbea7d356d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jmblp3mAmQtf99krkBD0aeVOTCHCLhEra_8gsC1-czc_1748969860 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9CB5740009 X-Stat-Signature: 6twdnyrgidted18jfymmfxw78geaa4k3 X-Rspam-User: X-HE-Tag: 1748969865-468633 X-HE-Meta: U2FsdGVkX18eqtwcIcNeKClSNOxM2l0s+dgFtf4K0q6FwvaNXy3sLTPRtmj4fhe773uLp07ie5OSAjl8qaRw4gGiU7yNj4agNYBbCAQcPGpwAueXjGL9c6X2W/xtY4O2jkK5q1PxfqA6eGmwDudKaCrTjuzt9wGYbIQVXteNlvYgRoKJCRJOB1SDq9Ieb2hGzI5kAtDP3sex8R4GmQYEPh6TnQoZ/7RY54etJFN2l92Q3N48fGmHG+2v4PNH/n1RYA6cMluIfT06cUblS85hXgH4m5MvkqrGTQhwyyk4XUGu5ea0asp3dzQPplSQKfKfNHyF6vVehayJyB67QdQ5t71Kwi6VqbWS9mPqIfGjEFBrDxn7YACQDbRAzOAUHzP8oQGMOSGbyTJErlsyoT1fNuxDJLEZYhFPbYufIjpKhAPNJ3eHha3q98BmFJ8oXi4yfzS7Be60Nm+3iGrknLnL9pgJLJlBO2KfKrvGBOEpxetzE9qq7C6q8PowQJ/M9YbmUnv/NAKEWExo7NduGiLLMYPIUCH+PHHv/C39X9fQPE+kEG41XqqucxO0TjrN5pVvTbgCFj6mFdeXsg0NVD0C90Y0VeVhJepG8+/USkGznjK1N9XHQf6kSNv7soOb8rp+OZJUM/XKmEjJMSslUCdqRHh9tfjwZovx9ZhAhMXJQTCPL9is+majMnwwcDrIQvTG5xz6hkc7xehKQgaAA1pML+IeM3a1l00yJA98cyPGWL1Iljy4oxr47lbYBFKPb1V5ZQe1YuzXXHgq7cdSacx0NeXKzcGmc6LYSlYhDl2GWO1dy36aghxCibwrhoBgwCnwx5XAFqhdOqujh4kHpRNrA3sszWVQoOu10VqcVgvAyIRxCBBRjiiCM/OhoIeTeXUNw1oV7JBqNVCFp6K7xWCz8waswxGuKOIod10L01vChLqwL8lQZIBYe0cy9L4Y/Ch+rwupWZ8dyEC7hjzjEtx U/MsZTmH iqkcEdEYH2TiVZ+Omk7hy3dgCvxtkun90Ydl+cSK3GHUv2KzhiSWCCpy/0ixAgDMglJftPn2war9zz7hUpc5GmYTsH/6MEmtEf5CJiDXTitt/tHDs0GMAI8NQ9nWB2m6FQBO6eLWmVa47j8xHvDelQ+JMlAke6DmrEeE+YY9tO8BG69KhL2QGZWTcY7PrOqlAR2QH4rW5S8R+Zo1bnlIp2IIw71KpWSsbDfOLdCr/Cemtl5/dAcXgVnCJh8yip5tquuSJz3G0d82dDIvUI3O2ho8duHmxLn4GKFFlU+KhRnvi+BJsnF5FWcf69CbhFSH52NgOEzlkT7lH5B1C0uiRLZ+IMTerlZV3q/0yzriv+by0eGDLgd6XOYa+adVrJJGBhzAEqIK1kdStiR5XMdEzBGWEpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 17:22, Mark Brown wrote: > On Tue, Jun 03, 2025 at 05:06:17PM +0200, David Hildenbrand wrote: >> On 03.06.25 16:58, Mark Brown wrote: > >>> Like I said I suspect the test name is just unclear here... > >> I would hope we find some mechanical replacement. > >> E.g., > >> ksft_test_result_pass("No leak from parent into child\n"); > >> becomes > >> ksft_print_msg("No leak from parent into child\n"); >> log_test_result(KSFT_PASS); > > Like I've been saying this is just the final test result, in this case I > would expect that for the actual thing we're trying to test any > confusion would be addressed in the name of the test so that it's clear > what it was trying to test. So adding "Leak from parent to child" to > the name of all the tests? I agree that printing something in case KSFT_PASS does not make sense indeed. But if something goes wrong (KSFT_FAIL/KSFT_SKIP) I would expect a reason in all cases. IIRC kselftest_harness.h behaves that way: $ ./pfnmap TAP version 13 1..6 # Starting 6 tests from 1 test cases. # RUN pfnmap.madvise_disallowed ... # SKIP Cannot open '/dev/mem' Changing the tests names really sounds suboptimal, if all we want do indicate is that the final memcp revealed a leak (part of the cow test). -- Cheers, David / dhildenb