From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7D0C4167B for ; Thu, 9 Nov 2023 15:43:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1EB38D00EB; Thu, 9 Nov 2023 10:43:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE838D0073; Thu, 9 Nov 2023 10:43:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895F28D00EB; Thu, 9 Nov 2023 10:43:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 795458D0073 for ; Thu, 9 Nov 2023 10:43:15 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4600B1CBCA2 for ; Thu, 9 Nov 2023 15:43:15 +0000 (UTC) X-FDA: 81438834750.10.3370C54 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf29.hostedemail.com (Postfix) with ESMTP id 6AE2E120009 for ; Thu, 9 Nov 2023 15:43:13 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="cRIn5/hn"; spf=pass (imf29.hostedemail.com: domain of jeff.xie@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=jeff.xie@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699544593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xVC5kvj11UWNazgoKPaQxDH585CeKpol97QYH/btY2Y=; b=sZT/IZiOIeWkMPFR48BD5pCtB5zWlkFeSUtPlRgxk9bKn4Egyf/49iLN0DKqIppmoUzyRR XGP1Z3wZ84fsBmUiIrqt/OiYVuUxVv1Yo6InMVxBRLepD6IWaRd/sBZW/LIHu8js23pL+3 B3mIdldDTpMlkzzF3cU8JnzDd6vrGiE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699544593; a=rsa-sha256; cv=none; b=xKvwlUALSJ0JfOyZ2cpPQME/YaF+NHhTKgjudTX3mUBWGliphdn3hwLDA+bIscD9t3P45K yFg1WeEu4zZ+Dj0iBn7HidHHQtUgnsEXGlk4qDNlkZMHxJjMR5u0XeHufB8YfmAANXN+Jf rICRns1YrU3ZTC47ssIwnxCxdLK8NH0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="cRIn5/hn"; spf=pass (imf29.hostedemail.com: domain of jeff.xie@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=jeff.xie@linux.dev; dmarc=pass (policy=none) header.from=linux.dev MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1699544591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xVC5kvj11UWNazgoKPaQxDH585CeKpol97QYH/btY2Y=; b=cRIn5/hnElVTePcq0N4hui9EdkEbSeRs5uPwln7WSsqdaZwiIPrA0UWXOF6c6yI9xlANmj Im4dVwsy/MJsZNJvarMIcYHsP2/3Oru2iHs9rL7w0RSQffu+uwy9iX29s+tu3H6NC+YKkx 5yiHgRK9ryEly4q9oloh0LPiSNFPxGo= Date: Thu, 09 Nov 2023 15:43:10 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: jeff.xie@linux.dev Message-ID: <27f7b8c52e2da5e8003de2226bff181fdc7a7f69@linux.dev> TLS-Required: No Subject: Re: [RFC][PATCH 3/4] filemap: implement filemap allocate post callback for page_owner To: "Matthew Wilcox" Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, chensong_2000@189.cn, xiehuan09@gmail.com In-Reply-To: References: <20231109032521.392217-1-jeff.xie@linux.dev> <20231109032521.392217-4-jeff.xie@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 6AE2E120009 X-Rspam-User: X-Stat-Signature: qaik5yyk1g46hs88rawhrstn1jgp5b4c X-Rspamd-Server: rspam03 X-HE-Tag: 1699544593-214480 X-HE-Meta: U2FsdGVkX18lHRKMMrIkgYRSKgaxTF1fwMAbEje29A0My0xciVSYP5Ds60/6926xvWKntqRIjdpPLSuSI0DqVDzAUFKo7aY7OHF3/KxegqGZhFs22I8H/7kBBKUnIenF1XDHTUwuph6MYy2J4gigZdiJ1iKmo3vYSH7iHdvHRW47vO0TWU4IBPFXdZZJE+kHeI1saO4rjTtXCzrmgDWoHUD7HRUUo0y7nrtuwcP94jau4XKLJQ1ChH+9nktcstNh0kEHnkb/MlCD6BdyWkaCVDr5HIA4S7h9QvTGx+/Yh1mTdivHTCeFPtMIlAP57/qWXEG8oVhJR5pjv8wi/BBKL4NECq0stS4tNx1+E3o04xGxMMww9yn8moIXyE5m+XmHBrovwiEH+FDh6lIKgitH+bzc3NbJIzK9mYwGdkV8A1xMcycVrjx5GKXbUyseLXQAzMdt1oQ8IaWdSH7t3EaR7Qn5xMb9jkXT4/hxz5cPme+9jdEXbyxXbMNfYCI53oZcQ4o0ylVwLnJt6OuLi2e5aLgY8p3ktNousmL+MAWqO+IyaAa1LAN3P7XwYz9Rmci967X+7RBLfuWhI7/fsTYhYOdQhnZv53FM6NiYWOjd51nRPc41Ogq2IST1hk2pyW6nqiPVbN6qOD1JuGJeWR53aUlWoGY3WqlIQ0WMCmrSUFIrBDidl6p/72vET1nnLoOsVM0rJ1+QMYTrqogjhrrjoYbZwfAvPTCFP8avw1LZRVANCJ+T9neNVz2sERmHhe87CufAuo883q8w/38woTfeZvdRPsQfE9h9RLt6TSteiE6w2nyLOkoDGNxiD+jswMDk9QPL9pzEEAxAsqXapL++1Ty6RAdis0zE6JtvwVtulrDweOxEAxKZBQOUj3rAuJvIAcFdnteVJgjBXNQ73Wx+k6aNH7NJbXcjzSk/33ugEi+nFMP0SplhoClPCwlO03eSQ3T+nywMzhdoSrC1vq4 2lBZWWNe fbsinpJuB2oPkWSlqBkLpBgQXaRHMm95oCBOFeCUqzCqS2ZUj+tmgp0b1OWOhL8KvqLxouM/dxt14GJrqTSbDDWWdRo6QKXwbpvd8IZoNemUJNF9gy5VwYPnqI9vNVrSxrryliTUXORRO2LcqzQghh6a05HHH6Q9H1VUq3Ok05tWehiSZE3JDH+82MxW8kljPOtHTgWaTFhBIBeMLSagYnpNNJ/Rlb+GP0BA+GdeiuZR1inRKit+KmdT5P37p8iBYSbWl+rF86VN6who= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: November 9, 2023 at 10:09 PM, "Matthew Wilcox" wrot= e: >=20 >=20On Thu, Nov 09, 2023 at 11:25:20AM +0800, Jeff Xie wrote: >=20 >=20>=20 >=20> +static int filemap_alloc_post_page_owner(struct folio *folio, stru= ct task_struct *tsk, > > + void *data, char *kbuf, size_t count) > > +{ > > + int ret; > > + int mapcount; > > + dev_t s_dev; > > + struct inode *inode; > > + struct vm_area_struct *vma; > > + struct mm_struct *mm; > > + unsigned long virtual_start =3D 0x0; > > + unsigned long virtual_end =3D 0x0; > > + struct address_space *mapping =3D data; > >=20 >=20 > This is just folio->mapping. Thanks, I need to know more about struct folio ;-) >=20 >=20>=20 >=20> + mapcount =3D folio_mapcount(folio); > > + if (mapcount && tsk && tsk->mm) { > > + mm =3D tsk->mm; > > + VMA_ITERATOR(vmi, mm, 0); > > + mmap_read_lock(mm); > > + for_each_vma(vmi, vma) { > > + if (page_mapped_in_vma(&folio->page, vma)) { > > + virtual_start =3D vma_address(&folio->page, vma); > > + virtual_end =3D virtual_start + folio_nr_pages(folio) * PAGE_SIZE; > > + break; > > + } > > + } > > + mmap_read_unlock(mm); > > + } > >=20 >=20 > Why not just walk the rmap directly to find out where it's mapped in > any process instead of the one which allocated it? Since the page_owner's result only shows which PID allocated this page, w= e only need to obtain the address space of the corresponding process for = that PID. -- Jeff Xie