From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A84E7716A for ; Sat, 14 Dec 2024 10:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A816F6B0093; Sat, 14 Dec 2024 05:16:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A31CD6B0095; Sat, 14 Dec 2024 05:16:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D25A6B0096; Sat, 14 Dec 2024 05:16:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7232D6B0093 for ; Sat, 14 Dec 2024 05:16:26 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CB320161DC2 for ; Sat, 14 Dec 2024 10:16:25 +0000 (UTC) X-FDA: 82893159342.05.7358378 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf02.hostedemail.com (Postfix) with ESMTP id DAE2B8000E for ; Sat, 14 Dec 2024 10:15:32 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="F8O/MEIt"; spf=pass (imf02.hostedemail.com: domain of akiyks@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=akiyks@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734171371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WC99pq7hRHFrLDw7siiOrZ7FqbwdIbl7gLGxK8elhYI=; b=6Dkkr6NoqdKPRgnxS/wP87e7ZZCu9yg08ylfZH+GB8obcwkAikNoOY350ZEF+o6IvHEDEu r/ZThfJg4b0k90O0X6bLZltQewi+W78DhQkk9jtpqZB8Lp+6lvOqzo1JozxbkZlTKpon2w PmydTDvKaOss8z3KXlQi1/V5VrehPRE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="F8O/MEIt"; spf=pass (imf02.hostedemail.com: domain of akiyks@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=akiyks@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734171371; a=rsa-sha256; cv=none; b=4mJfhMmgNwFSe7qFrAnXpv6tWibwzUDLbsEkN5PrbVDLC+UFSM8ytwecgIg3xhTfPeGbC4 S5k2J8CpuETUA9wW35CibytqNueT8i/uVAVNE+DEv3aMMcfuk+LNR/ctAFTljltUjPmraX Y41sH6b43VEy1emL3vz1sylyqmi+Dqk= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2161eb95317so23944515ad.1 for ; Sat, 14 Dec 2024 02:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734171382; x=1734776182; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WC99pq7hRHFrLDw7siiOrZ7FqbwdIbl7gLGxK8elhYI=; b=F8O/MEItaeVeG3EtVZp6L5gPENW585m20CfCpIrOtkkMNUeBP9ofmfQpqbeySvgTrY yoGGuwUHz647bBNZTldgJajNK6avVmfU4Q7LielR8DugZR0MBnqnCpd3wJuO5vKelGFb C7fu7pTdV4If3VCTQWQhlJF6FFRK1qQDEf3g5hAiuPsfpmZnVnxUlPXmiRFWSB1lqlNk tinUUPgXBCwCxpdb3groex18OgEGGjEcKPmLUVxdDBAyLyW2m4hEmYx8f7I87tnCFoeF PDMB04VMWYhnTU406HitdctKg2j0TycRG10foFrTpCNBJqnQmay99UBDEs3aZLXcb/wR uLJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734171382; x=1734776182; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WC99pq7hRHFrLDw7siiOrZ7FqbwdIbl7gLGxK8elhYI=; b=pMIGR3xH/filkbLzNWbxhEF/+oDMqjq2liND6uYVmBh7fL/2e8Hz6aHiWCaLpnIutG C/pl1DkLfmz+88vZyYUG8RBN0uMGK/TdG8To3wbbtiG/TwTMwP9uEp05sXyGg8o7YCKx p5tjhJd5vPJRFo9dHDbEN6O4SrGbi5Oqt+QLNiYfOBwjKc3LeH8orG/D6L7lAtcoDAmb JkTKMFbDpNWWewN/MQIxCd/cDfM8cbvlYwG88c1un5Il8lWCZ/1JokvzaX9PS8Li2CMl 9eU8JawX16XMZLOlT6ZyV8IgGCrSKBXXEa34r4g5tHp1l6tSuzxlQfwLLI6k55pxT8Xm 3q2A== X-Forwarded-Encrypted: i=1; AJvYcCVcXsRl1G7TrwKl927KYx/cluACr7a/IoysPqcxcMumHdSvuSNSnOFxwYIH5DLIUTwDz560Xkc36g==@kvack.org X-Gm-Message-State: AOJu0YxNSSDDbErDIhMC42NqvLpBsH6PayCG6FdqpmeaZ9NmVDbgcAe/ 8MZ7Aik6XxBm+OlDo7ex0tAKYDwnxOsZCssFGujIqh4FKscx9FeW X-Gm-Gg: ASbGnctY6GmczuVhrL0MkLxXbZm3EjRR72PBbU5KXXfGdPgvSWbbL6h9JyyY73oUDBy 0gvg3a6baeVygRNmzMHdiaMa/EVEvbzwcyWBejhpl3oNmgPqhKmK/KLpyxjHKNHXakPuUMaYQeW va2RjxdGCBpplDJfXWa8xZ4JHPzAqOHHr1QufyepJ9PCLOUvezBHAZDPFC+zUCEVfAhOtUOG+os nz4L6+8x86mdg+hcpmnFBAYejRNwBtx6iZCHRDfSZF4VxhVyeZh5srAApk1R12c7r0cYioYPmCU f4qeK+UitDGPfgmGBXDrGiA= X-Google-Smtp-Source: AGHT+IEZVE15/vEAohikUk6vjIGzOeFn+yVnxHcYlw+pZKWRHHAPNEYP1GeDSZ8W1ZJPAeFwPcezZw== X-Received: by 2002:a17:902:f70b:b0:216:28c4:61c6 with SMTP id d9443c01a7336-218929fb17bmr82919535ad.34.1734171382443; Sat, 14 Dec 2024 02:16:22 -0800 (PST) Received: from [10.0.2.15] (KD106167137155.ppp-bb.dion.ne.jp. [106.167.137.155]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e50455sm10069475ad.159.2024.12.14.02.16.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Dec 2024 02:16:22 -0800 (PST) Message-ID: <27fff669-bec4-4255-ba2f-4b154b474d97@gmail.com> Date: Sat, 14 Dec 2024 19:16:18 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] netfs: Fix missing barriers by using clear_and_wake_up_bit() To: David Howells , Christian Brauner Cc: Max Kellermann , Ilya Dryomov , Xiubo Li , Trond Myklebust , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zilin Guan , Akira Yokosawa References: <20241213135013.2964079-1-dhowells@redhat.com> <20241213135013.2964079-8-dhowells@redhat.com> Content-Language: en-US From: Akira Yokosawa In-Reply-To: <20241213135013.2964079-8-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DAE2B8000E X-Stat-Signature: 44useqpyyubmzjymuzq64kieqhx4fzqn X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734171332-108977 X-HE-Meta: U2FsdGVkX18OgDb449ffEoyhIXLGeJ+6O9GCnqVIBUlxDfw/r81IXGU88fEMdCXa/BI7qYOHSA5+bdKX6uALwwS5poCmBUQnbWkm/6aRyx70PAmKH343Q0Z9vloU75U/EjWEQK+Wl00+I6kRGEu3soYMEQBN1gicuLy4pmNOflhJmQEvgDLM+vanVFPUjAt0YTOUkxH2FdAK2IHVq4jfjd9S+/7BcELZDa01EEHeUK8c9ZNbxy3Vxj++FmUyS3b65ojMkGoJq81fyqq1krOh+l97dTtuwEJ3X4+5pkcI1hm53B4JoJ6S3MXZaiBm3DqN08oIcwhveW+EKaw8A6FdSnv3w3f8zdOrWjQt/b295puumTzvupqeaXq/iqImagiyuzRL/ne7fovTi4+20gbkqbMA4TJ3GNzV2cdRHAcgsO+fuQz2JpgEtvffVQSuq/yAdO30qChVqmCnIOSaZzaYN/zsTf3aKA3QeOhWG/QIWaE3QGZlFl4IKdXf+qJQtxRbE2JMABzeJnwoIwxkv1TxRL8+vRk4Kw2uJ09Sk4p6lfyXQmkaq9IJQEWuj39cZX5LQHFc4G2SjU5hbWjjgzZIngLtYd5bNUrSJ6qfsxjQdAVDcnKX8EbSyPusyV2oR1b/y2TtXf/HGdqyPqQyIkbVsF7vaInun4FDKzoYV3Ebj2Mi/dB/uVBkjxqhKox6rYOlGXb35go8ex1Ciiu2sawEPEBHGe2BRo6+/zhNk8VDIy3UwiYc7mWlf9/6iZf8UajI5gz2BFU2Lde7Zk5jVedxbZEUJiEpya/n+EMjKLOHP7g2KBgmv6NYopl7ZtIOsgFV03okXVccBk+U7B3azqfVd0hXel42s7cnN2p1TeUU/YFuy78u9NGgsCit3ncTXxov2smTIWYmdFF0GTS/tn94HH99Orf9Xqw4tGIy9pqGPDgR7ucoRWH5PLTUdFZSi14q50cx9ikAgN6Vj2VsEVw 5N6kPoVT JXd4FAJx4CDJaN+ElAutv4oUyd3C/oZz8TKMsk7I6/uLnRwt6LoujhOroYyB+qvLMgZjjObpldyR5un1prSi+MUKHmbJsauv/duwf8GLYfK81QFznfZHWyjW532tkZACCoNwJDLWhIzln20AVeYCt0QvZX/TcqocE5vLKS1gocejMM4USNdBtl0W7OAt5AXEzZsLjQFs1ArDF6rYYas86u6d+giAOtO7Bir2tjGv2oILRuWH022spv3CxLPbjE/h2OKbx/y3DlOcLnSjhTjatvIbipQFWLMhhVpaeeycqmejHX3nkjJ5COhfyN521j8f5prfPPPhfWb+6YMYsqQTzAaNYDlFwCrEK49PDTyJccaEeUb6EkX/9lnN4qs3n2Q+2lkto/pbf0tFis7MnUk7EV7LcCOGTO0fd6UDljeAZ77PJeKigigIPRLPEk5qJKTy2y4Ub/DDTCPF0cSc2xL5djIkjkMKuwp6MpG4SLEX6H1Tg86U2y8UwLFZutowVqFG8JVbGjx6nPhYisO+UPHkALD7HOH8LgA833Z9sioDOXgarwMosKuS8WLtAp08V/sJqNFl9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.166549, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, David Howells wrote: > Use clear_and_wake_up_bit() rather than something like: > > clear_bit_unlock(NETFS_RREQ_IN_PROGRESS, &rreq->flags); > wake_up_bit(&rreq->flags, NETFS_RREQ_IN_PROGRESS); > > as there needs to be a barrier inserted between which is present in > clear_and_wake_up_bit(). If I am reading the kernel-doc comment of clear_bit_unlock() [1, 2]: This operation is atomic and provides release barrier semantics. correctly, there already seems to be a barrier which should be good enough. [1]: https://www.kernel.org/doc/html/latest/core-api/kernel-api.html#c.clear_bit_unlock [2]: include/asm-generic/bitops/instrumented-lock.h > > Fixes: 288ace2f57c9 ("netfs: New writeback implementation") > Fixes: ee4cdf7ba857 ("netfs: Speed up buffered reading") So I'm not sure this fixes anything. What am I missing? Thanks, Akira > Signed-off-by: David Howells > cc: Zilin Guan > cc: Akira Yokosawa > cc: Jeff Layton > cc: netfs@lists.linux.dev > cc: linux-fsdevel@vger.kernel.org > --- > fs/netfs/read_collect.c | 3 +-- > fs/netfs/write_collect.c | 9 +++------ > 2 files changed, 4 insertions(+), 8 deletions(-) > [...]