From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B386C433FE for ; Thu, 12 May 2022 13:05:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B70C6B0074; Thu, 12 May 2022 09:05:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63DE86B0075; Thu, 12 May 2022 09:05:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E0506B0078; Thu, 12 May 2022 09:05:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C4766B0074 for ; Thu, 12 May 2022 09:05:09 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1354D20E6F for ; Thu, 12 May 2022 13:05:09 +0000 (UTC) X-FDA: 79457111538.21.7BC7BA3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id E2294200B0 for ; Thu, 12 May 2022 13:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652360707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=efOMr3P/7pGohN9ErE4jqv2LFNSoc71Z8ICykAkWQU4=; b=N3VHZ2lHqnjfHKUI6c55BVE9myEUO2WqxKj2HkJFCrcCoCWjPyxdtZUhr8VOmiiGid0M/k F45k1QF1hWSiCT2uzwDEjKaLI1w2jR0xcWOPAY98Z0AL2y4NvVY27dDAW6Ad6KA4QRlP7Q B+wOz5hd7gU4davTH0g1ijyni1AnU5E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-IKzQvOlIPqWsfJpTaMlWBw-1; Thu, 12 May 2022 09:05:03 -0400 X-MC-Unique: IKzQvOlIPqWsfJpTaMlWBw-1 Received: by mail-wr1-f70.google.com with SMTP id j27-20020adfb31b000000b0020c4ca11566so2030517wrd.14 for ; Thu, 12 May 2022 06:05:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=efOMr3P/7pGohN9ErE4jqv2LFNSoc71Z8ICykAkWQU4=; b=jv4H4eclCHDeZUoM/NGQpppZEPMDLATbqnLWahKlSeCPhtoSkLFxrDuF8RAwTiSbmL GAnMXPzCYHz2PwnvkfSq80x2Z71sThwzw0z4rg4m9MvEzPMAk7YJmSvSbG8N+IF4y1R2 H8KDNH6FaRcNdu0IYuWWzdy80IePgziqusKgOoaUlvQqpqS0rVtvlBF8cb8DfglNS9aN o2FIDhvC53OHktTbMbqRPg/QnSQjZUoBfsFmO0Zf5rDHd0mSwDcD4DfRn3ThnQQtOqSG 0r46YsQLBXBJsuPbsuofUweifflhV85E7uMl/CpOF3YHAsiiy9eVOHxTG4fjR65jo/xn 7AKQ== X-Gm-Message-State: AOAM531vJAmrVNWDK+BniR2CRaeo//bTzHzumeW0DnXEKT5wgbltLXZs B5+TRikSoZSXitw8Hm3z6AkSqls7fJ7qJnG+vmk9wxfHhDFNn1TjrkF4UH3m+IfawzDk0Dj3IH7 TtgRyuYn0Xmw= X-Received: by 2002:a5d:5502:0:b0:20a:e0aa:90bd with SMTP id b2-20020a5d5502000000b0020ae0aa90bdmr28284039wrv.551.1652360700699; Thu, 12 May 2022 06:05:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdbDUlWFRb1WciroIQ1XDBEiFyzj/9JbtF68Ro3xbJ4jLGkiv/MQOmwWuOkoPWwT9ahyEkiw== X-Received: by 2002:a5d:5502:0:b0:20a:e0aa:90bd with SMTP id b2-20020a5d5502000000b0020ae0aa90bdmr28284017wrv.551.1652360700457; Thu, 12 May 2022 06:05:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:d200:ee5d:1275:f171:136d? (p200300cbc701d200ee5d1275f171136d.dip0.t-ipconnect.de. [2003:cb:c701:d200:ee5d:1275:f171:136d]) by smtp.gmail.com with ESMTPSA id a7-20020a7bc1c7000000b0039429bfebeasm2647067wmj.2.2022.05.12.06.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 06:04:59 -0700 (PDT) Message-ID: <284eec3f-a79d-c5f0-3cd6-53b8e64100cd@redhat.com> Date: Thu, 12 May 2022 15:04:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v10 2/4] mm: memory_hotplug: override memmap_on_memory when hugetlb_free_vmemmap=on To: Muchun Song Cc: corbet@lwn.net, mike.kravetz@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, osalvador@suse.de, masahiroy@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com References: <20220509062703.64249-1-songmuchun@bytedance.com> <20220509062703.64249-3-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N3VHZ2lH; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E2294200B0 X-Stat-Signature: b5kzn6tzcpnu4xeopspj6nprare73pxr X-HE-Tag: 1652360689-186869 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.05.22 14:50, Muchun Song wrote: > On Thu, May 12, 2022 at 09:36:15AM +0200, David Hildenbrand wrote: >> On 09.05.22 08:27, Muchun Song wrote: >>> Optimizing HugeTLB vmemmap pages is not compatible with allocating memmap on >>> hot added memory. If "hugetlb_free_vmemmap=on" and >>> memory_hotplug.memmap_on_memory" are both passed on the kernel command line, >>> optimizing hugetlb pages takes precedence. >> >> Why? >> > > Because both two features are not compatible since hugetlb_free_vmemmap cannot > optimize the vmemmap pages allocated from alternative allocator (when > memory_hotplug.memmap_on_memory=1). So when the feature of hugetlb_free_vmemmap > is introduced, I made hugetlb_free_vmemmap take precedence. BTW, I have a plan > to remove this restriction, I'll post it out ASAP. I was asking why vmemmap optimization should take precedence. memmap_on_memory makes it more likely to succeed memory hotplug in close-to-OOM situations -- which is IMHO more important than a vmemmap optimization. But anyhow, the proper approach should most probably be to simply not mess with the vmemmap if we stumble over a vmemmap that's special due to memmap_on_memory. I assume that's what you're talking about sending out. -- Thanks, David / dhildenb