From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E471EC61DA4 for ; Wed, 22 Feb 2023 15:49:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 624C36B0072; Wed, 22 Feb 2023 10:49:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D51F6B0073; Wed, 22 Feb 2023 10:49:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 475BF6B0074; Wed, 22 Feb 2023 10:49:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 363ED6B0072 for ; Wed, 22 Feb 2023 10:49:05 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 00EAF160C5F for ; Wed, 22 Feb 2023 15:49:04 +0000 (UTC) X-FDA: 80495361450.18.03D8F98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id AA8BD100019 for ; Wed, 22 Feb 2023 15:49:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mh78JGuk; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677080941; a=rsa-sha256; cv=none; b=gAAvVzMi43MKc1NKnyj+iizsp6b2bfDXfDis8UbJDVtN2mrDho0YW1hgnqfUnhoWYMc27v rZ7UVZv+RpYvD1mu1eIQ7YW8V5txbxrp8z9x7UTuSfszSDQ2JTqITvX5gXNjn6AkBDj3R0 Cb9CdFgdSAtJM5+q9ot61LonzN69+Ic= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mh78JGuk; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677080941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GVZBOKGD+V7dnhmBUhnfKIR5wlVaDW+yBjCOv4O7PbE=; b=6B/XUPld+frez+kFSM3k4bkUh/bLSaWQK49BrpaOnMtkcBYkSJWOmNtdTtqHW2M3yFefsL CogE0cIu9Y6xuzP7CxCNBTb5Xenmo5VJOTUhHwVz7VrB1f/8n4I6Myzqvn7jxxvsg8TrkJ ziWrZ9zyKPVMnSJyLvzm+unf6v/8kJ8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677080941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GVZBOKGD+V7dnhmBUhnfKIR5wlVaDW+yBjCOv4O7PbE=; b=Mh78JGukovE6zBFCTleVgkAKsid+TDEa/kJszmjqjpLL6x35m4cA3XtHEYaPwFRhc7UHVr B32xnnwUZBQe1v1rH3967+v5MYfMBCh3Gu4RpINYg5o7gzDT3DIk9mBMzQGvvP6ilpCA5b uVU3nQyIXbJ63a7KnZVDAt5sGtAvk0w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-350-QqmL8avlNp6R0JpawIgnyw-1; Wed, 22 Feb 2023 10:48:59 -0500 X-MC-Unique: QqmL8avlNp6R0JpawIgnyw-1 Received: by mail-wm1-f72.google.com with SMTP id m28-20020a05600c3b1c00b003e7d4662b83so2397333wms.0 for ; Wed, 22 Feb 2023 07:48:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GVZBOKGD+V7dnhmBUhnfKIR5wlVaDW+yBjCOv4O7PbE=; b=TZ8vlqdn89mmQYsgPSZgy+f/ZCmcUpXIf8XhSwmcSu87w2psWuNMdgCPOZAzDuHlg4 slnoh/M9vtysySOeRJVTqS7Ui0hBzEUsph7dy9LiKz7avroR8OOFg0kEG5oBntTdwddm lEHZLwVKhANoWMnReDwpQuy/+s/FF19dCR2bsxvFm08v57CVTDSED0Ni8QwVlZl8u58H 1OFqrDK7BQuw6OdxAXN13dFYaKIFk5XB3eQC6j/zhmTM7M1PaNQNzCqUHbzu6Fd7KUU3 9IM6xjtdT4wLpd7X7gyQe7XaGhoiaFQOPUNBYpm371mYRwDTyr1Cfb0mOh9UfRokO9t7 kTHg== X-Gm-Message-State: AO0yUKWvse35k7FyK+CCLq2W9cWR5UmZuU+vI0lB1SI9KLBMnFhV4qmw wSKTq60re1E2bGLoYxlQjigP9xMVofdiZvOEGWk8klWwlfi66jhWNf7WvN6jmgx+M2jTVTSzYAZ a8c7/bKM5TFc= X-Received: by 2002:adf:e505:0:b0:2c5:56ab:ee5b with SMTP id j5-20020adfe505000000b002c556abee5bmr7765721wrm.48.1677080938435; Wed, 22 Feb 2023 07:48:58 -0800 (PST) X-Google-Smtp-Source: AK7set/2d8R8uayDlkM/vphgzaY3W11nRhaJF1cal3UEr+GSyZKqWne3weKffIQjki6hs0rJ/X8gKQ== X-Received: by 2002:adf:e505:0:b0:2c5:56ab:ee5b with SMTP id j5-20020adfe505000000b002c556abee5bmr7765692wrm.48.1677080937997; Wed, 22 Feb 2023 07:48:57 -0800 (PST) Received: from ?IPV6:2003:cb:c704:a100:95ad:6325:131:6b1d? (p200300cbc704a10095ad632501316b1d.dip0.t-ipconnect.de. [2003:cb:c704:a100:95ad:6325:131:6b1d]) by smtp.gmail.com with ESMTPSA id o24-20020a5d58d8000000b002c7066a6f77sm4586083wrf.31.2023.02.22.07.48.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 07:48:57 -0800 (PST) Message-ID: <28a7208c-939c-19ea-1cf0-298444dffe85@redhat.com> Date: Wed, 22 Feb 2023 16:48:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 00/46] hugetlb: introduce HugeTLB high-granularity mapping To: Mike Kravetz , James Houghton Cc: Muchun Song , Peter Xu , Andrew Morton , David Rientjes , Axel Rasmussen , Mina Almasry , Zach O'Keefe , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Frank van der Linden , Jiaqi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230218002819.1486479-1-jthoughton@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: AA8BD100019 X-Rspamd-Server: rspam01 X-Stat-Signature: affit5g4tgwjk6mkwx91377n4468tuop X-HE-Tag: 1677080941-120944 X-HE-Meta: U2FsdGVkX19SFshuI6W1RBosgrBWpsk1aPRiP5ilLCWiEU8yY4T5DjutZEO1xqjOJ0H+yUKWnuFRM2fGPgqt9HdrhqqNTicIeapUMiCN5+9h8sFgNhu5mpxVyXX8EIHMRcXzFDDaDy0Ki2eo7IW3KhdAJhPLPTspzThJGtscQ9sE/DByQCg3hvFu5p1A3NV8djzYa7NoHQ39mGtC94N9zDfuOVVz3rd5tIpcDFL9MlG6XX8auwpBgLwAGp4+Z3fgzkGF0aU1yFaDZkwju43Ems68xFCR6nVR/isin9/0s23SPcnlIoHQOspWD3PWCMTDn9UJ8OD06AHXCgU1/kb3UP+EvDttxL797xfkW0vkZI5AqDjpj3k02ki/jfEcWMj/YRqIIgbESa8I3GJzd5SCMFlOsijNJpcFRPyYrlaewXwoe1rtjmhOZ8tPcs9XhnaM3bInoKjlLCbqwotAqBkrbWS/HrZr0xXkYjzXY3YefH7X8Tx8SQXZpJEKPA1lHZfHzJP6XTTPQtkroy46eULSJGZRxvgjmAdZXmgw1864UE1evna3u9MK4/07m1IvTDxcPrfaRldk+9HwHVqXXbGuQJ233gIk/KLG6UyX7i5mhjHJiCFwWxznagsBmeQApQBnI9ttFBne2JiQseag0DLmhqCs8Xy8CEwMSsIGS9HEKlEv/NMsmjLnSghzZuR8pCqR6alkmz8OfqXWhax59Z3CpQg7ETKgPwwTQ6DlKszJd7vi1qizXyb867UCW9uhkNWbzkvJCAw89i4FpXSH7JdeZiEnvDVAxm4faQRNs9r+Qtvm3MgYIzUSPrS8Ra/1CGn6Oe/SSX47+sd/akPMNvKzSgzQfNx7uqJc+Qa1vfjIR7krOg63twD4aZWzhHcV8o4levmwWC82qOHpJVDog5yOINoVAqiiAvtmeOefjrnCWr5eEc9FBEHwgJoW6TvKLvux1w21NlsSlQMpe5Is5F2 uOhKcRQW ZZZ//yINB7W9EqEte0LUG91MVlMvqMbbt6uN/JK5OSl3AFJDiOTCdjv0NRaU022JS9bICfBsihEAi43hM+eSoYkN8AS2We1GcVfpe62wWbLsoS+oJdlwnhI6MVFBJXPFC8jwTHH6/KRK5pYbgdepy+OtIARzqzhirFQAQ85+k2gMCWT3ZoOeDMOflEhPHxaUTKHfG8O0QS87YmrIP2v1vNAIFDFZnn9R2Fsexgzy3WylFABKofANyiKosN7Z0moy2p+iMs4G8xqkMSnsihZavwujAr5Pv7nFFh8s2qWH/ii4of5MGPao7WCCzE99GaJNNIHzzOO+hbdDPknutZHCmqhNImZ2IRkXYg8OT3sg4Z33OszVTtvbwjb4h3qc6oCkK3OI63e4K3/+iTiXfGi7p3QJAXbtO/nglMP3dlKXG1cNh0KDIExeoyD7uAN+k99Aw+ysPuQEc+ziLoy4OmWjEJ9ZcOdIRfpxLX+DW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.02.23 22:46, Mike Kravetz wrote: > On 02/18/23 00:27, James Houghton wrote: >> This series introduces the concept of HugeTLB high-granularity mapping >> (HGM). This series teaches HugeTLB how to map HugeTLB pages at >> high-granularity, similar to how THPs can be PTE-mapped. >> >> Support for HGM in this series is for MAP_SHARED VMAs on x86_64 only. Other >> architectures and (some) support for MAP_PRIVATE will come later. >> >> This series is based on latest mm-unstable (ccd6a73daba9). >> >> Notable changes with this series >> ================================ >> >> - hugetlb_add_file_rmap / hugetlb_remove_rmap are added to handle >> mapcounting for non-anon hugetlb. >> - The mapcounting scheme uses subpages' mapcounts for high-granularity >> mappings, but it does not use subpages_mapcount(). This scheme >> prevents the HugeTLB VMEMMAP optimization from being used, so it >> will be improved in a later series. >> - page_add_file_rmap and page_remove_rmap are updated so they can be >> used by hugetlb_add_file_rmap / hugetlb_remove_rmap. >> - MADV_SPLIT has been added to enable the userspace API changes that >> HGM allows for: high-granularity UFFDIO_CONTINUE (and maybe other >> changes in the future). MADV_SPLIT does NOT force all the mappings to >> be PAGE_SIZE. >> - MADV_COLLAPSE is expanded to include HugeTLB mappings. >> >> Old versions: >> v1: https://lore.kernel.org/linux-mm/20230105101844.1893104-1-jthoughton@google.com/ >> RFC v2: https://lore.kernel.org/linux-mm/20221021163703.3218176-1-jthoughton@google.com/ >> RFC v1: https://lore.kernel.org/linux-mm/20220624173656.2033256-1-jthoughton@google.com/ >> >> Changelog: >> v1 -> v2 (thanks Peter for all your suggestions!): >> - Changed mapcount to be more THP-like, and make HGM incompatible with >> HVO. >> - HGM is now disabled by default to leave HVO enabled by default. > > I understand the reasoning behind the move to THP-like mapcounting, and the > incompatibility with HVO. However, I just got to patch 5 and realized either > HGM or HVO will need to be chosen at kernel build time. That may not be an > issue for cloud providers or others building their own kernels for internal > use. However, distro kernels will need to pick one option or the other. > Right now, my Fedora desktop has HVO enabled so it would likely not have > HGM enabled. That is not a big deal for a desktop. > > Just curious, do we have distro kernel users that want to use HGM? Most certainly I would say :) -- Thanks, David / dhildenb