From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 480F16B004F for ; Sat, 16 May 2009 21:23:52 -0400 (EDT) Received: by gxk20 with SMTP id 20so5211680gxk.14 for ; Sat, 16 May 2009 18:24:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20090516090448.535217680@intel.com> References: <20090516090005.916779788@intel.com> <20090516090448.535217680@intel.com> Date: Sun, 17 May 2009 10:24:13 +0900 Message-ID: <28c262360905161824p7022748esb0f8600a8317eab9@mail.gmail.com> Subject: Re: [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list() From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: Andrew Morton , LKML , Rik van Riel , Christoph Lameter , KOSAKI Motohiro , "hannes@cmpxchg.org" , "peterz@infradead.org" , "tytso@mit.edu" , "linux-mm@kvack.org" , "elladan@eskimo.com" , "npiggin@suse.de" List-ID: On Sat, May 16, 2009 at 6:00 PM, Wu Fengguang wrote: > The "move pages to active list" and "move pages to inactive list" > code blocks are mostly identical and can be served by a function. > > Thanks to Andrew Morton for pointing this out. > > Note that buffer_heads_over_limit check will also be carried out > for re-activated pages, which is slightly different from pre-2.6.28 > kernels. Also, Rik's "vmscan: evict use-once pages first" patch > could totally stop scans of active list when memory pressure is low. To clarify, active file list. otherwise is good to me. Thanks for your great effort to enhance VM. :) > CC: Rik van Riel > Signed-off-by: Wu Fengguang Reviewed-by: Minchan Kim -- Kinds regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org