Re: [PATCH 2/3] check unevictable flag in lumy reclaim v2

[Minchan Kim <minchan.kim@gmail.com>]

On Thu, Jun 11, 2009 at 5:38 PM, KAMEZAWA
Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> How about this ?
>
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Lumpy reclaim check pages from their pfn. Then, it can find unevictable pages
> in its loop.
> Abort lumpy reclaim when we find Unevictable page, we never get a lump
> of pages for requested order.
>
> Changelog: v1->v2
>  - rewrote commet.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> ---
>  mm/vmscan.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
> Index: lumpy-reclaim-trial/mm/vmscan.c
> ===================================================================
> --- lumpy-reclaim-trial.orig/mm/vmscan.c
> +++ lumpy-reclaim-trial/mm/vmscan.c
> @@ -936,6 +936,15 @@ static unsigned long isolate_lru_pages(u
>                        /* Check that we have not crossed a zone boundary. */
>                        if (unlikely(page_zone_id(cursor_page) != zone_id))
>                                continue;
> +                       /*
> +                        * We tries to free all pages in this range to create
> +                        * a free large page. Then, if the range includes a page
> +                        * never be reclaimed, we have no reason to do more.
> +                        * PageUnevictable page is not a page which can be
> +                        * easily freed. Abort this scan now.
> +                        */
> +                       if (unlikely(PageUnevictable(cursor_page)))
> +                               break;

__isolate_lru_pages already checked PageUnevictable to return error.
I want to remove repeated check although it is trivial.

By your patch, It seems to remove PageUnevictable check in __isolate_lru_pages.

But I know that. If we remove PageUnevictable check in
__isolate_lru_pages, it can't go into BUG in non-lumpy case. ( I
mentioned following as code)

                case -EBUSY:
                        /* else it is being freed elsewhere */
                        list_move(&page->lru, src);
                        continue;

                default:
                        BUG();
                }


It means we can remove BUG in non-lumpy case and then add BUG into
__isolate_lru_pages directly.

If we can do it, we can remove unnecessary PageUnevictable check in
__isolate_lru_page.

I am not sure this is right in case of memcg.

-- 
Kinds regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>