From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id AAEE26B005D for ; Thu, 11 Jun 2009 07:20:06 -0400 (EDT) Received: by gxk28 with SMTP id 28so2220927gxk.14 for ; Thu, 11 Jun 2009 04:20:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4c72e5b8de091845036fe2b5227168f5.squirrel@webmail-b.css.fujitsu.com> References: <20090611165535.cf46bf29.kamezawa.hiroyu@jp.fujitsu.com> <20090611170018.c3758488.kamezawa.hiroyu@jp.fujitsu.com> <28c262360906110218t6a3ed908g9a4fba7fa7dd7b22@mail.gmail.com> <4c72e5b8de091845036fe2b5227168f5.squirrel@webmail-b.css.fujitsu.com> Date: Thu, 11 Jun 2009 20:20:42 +0900 Message-ID: <28c262360906110420g666df03cl49d008dd7a608ae6@mail.gmail.com> Subject: Re: [PATCH 1/3] remove wrong rotation at lumpy reclaim From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "kosaki.motohiro@jp.fujitsu.com" , "nishimura@mxp.nes.nec.co.jp" , "balbir@linux.vnet.ibm.com" , "akpm@linux-foundation.org" , apw@canonical.com, riel@redhat.com, mel@csn.ul.ie List-ID: 2009/6/11 KAMEZAWA Hiroyuki : > Minchan Kim wrote: >> On Thu, Jun 11, 2009 at 5:00 PM, KAMEZAWA >> Hiroyuki wrote: >>> From: KAMEZAWA Hiroyuki >>> >>> At lumpy reclaim, a page failed to be taken by __isolate_lru_page() can >>> be pushed back to "src" list by list_move(). But the page may not be >>> from >>> "src" list. And list_move() itself is unnecessary because the page is >>> not on top of LRU. Then, leave it as it is if __isolate_lru_page() >>> fails. >>> >>> This patch doesn't change the logic as "we should exit loop or not" and >>> just fixes buggy list_move(). >>> >>> Signed-off-by: KAMEZAWA Hiroyuki >>> --- >>> ?mm/vmscan.c | ? ?9 +-------- >>> ?1 file changed, 1 insertion(+), 8 deletions(-) >>> >>> Index: lumpy-reclaim-trial/mm/vmscan.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- lumpy-reclaim-trial.orig/mm/vmscan.c >>> +++ lumpy-reclaim-trial/mm/vmscan.c >>> @@ -936,18 +936,11 @@ static unsigned long isolate_lru_pages(u >>> ? ? ? ? ? ? ? ? ? ? ? ?/* Check that we have not crossed a zone >>> boundary. */ >>> ? ? ? ? ? ? ? ? ? ? ? ?if (unlikely(page_zone_id(cursor_page) !=3D >>> zone_id)) >>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?continue; >>> - ? ? ? ? ? ? ? ? ? ? ? switch (__isolate_lru_page(cursor_page, mode, >>> file)) { >>> - ? ? ? ? ? ? ? ? ? ? ? case 0: >>> + ? ? ? ? ? ? ? ? ? ? ? if (__isolate_lru_page(cursor_page, mode, file) >>> =3D=3D 0) { >>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?list_move(&cursor_page->lru, dst); >>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?nr_taken++; >>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?scan++; >>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?break; >> >> break ?? >> > good catch. I'll post updated one tomorrow. > I'm very sorry ;( Never mind. :) > Thanks, > -Kame > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. =C2=A0For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > --=20 Kinds regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org