From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 827A36B004F for ; Sun, 5 Jul 2009 13:21:56 -0400 (EDT) Received: by vwj42 with SMTP id 42so2441630vwj.12 for ; Sun, 05 Jul 2009 08:04:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <2f11576a0907050619t5dea33cfwc46344600c2b17b5@mail.gmail.com> References: <20090705182533.0902.A69D9226@jp.fujitsu.com> <20090705121308.GC5252@localhost> <20090705211739.091D.A69D9226@jp.fujitsu.com> <20090705130200.GA6585@localhost> <2f11576a0907050619t5dea33cfwc46344600c2b17b5@mail.gmail.com> Date: Mon, 6 Jul 2009 00:04:17 +0900 Message-ID: <28c262360907050804p70bc293uc7330a6d968c0486@mail.gmail.com> Subject: Re: [PATCH 5/5] add NR_ANON_PAGES to OOM log From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Wu Fengguang , LKML , linux-mm , Andrew Morton , Christoph Lameter , David Rientjes , Rik van Riel List-ID: On Sun, Jul 5, 2009 at 10:19 PM, KOSAKI Motohiro wrote: >>> > > + printk("%ld total anon pages\n", global_page_state(NR_ANON_PAGES)= ); >>> > > =C2=A0 printk("%ld total pagecache pages\n", global_page_state(NR_F= ILE_PAGES)); >>> > >>> > Can we put related items together, ie. this looks more friendly: >>> > >>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 Anon:XXX active_anon:XXX inactive_anon:XX= X >>> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 File:XXX active_file:XXX inactive_file:XX= X >>> >>> hmmm. Actually NR_ACTIVE_ANON + NR_INACTIVE_ANON !=3D NR_ANON_PAGES. >>> tmpfs pages are accounted as FILE, but it is stay in anon lru. >> >> Right, that's exactly the reason I propose to put them together: to >> make the number of tmpfs pages obvious. >> >>> I think your proposed format easily makes confusion. this format cause = to >>> imazine Anon =3D active_anon + inactive_anon. >> >> Yes it may confuse normal users :( >> >>> At least, we need to use another name, I think. >> >> Hmm I find it hard to work out a good name. >> >> But instead, it may be a good idea to explicitly compute the tmpfs >> pages, because the excessive use of tmpfs pages could be a common >> reason of OOM. > > Yeah, =C2=A0explicite tmpfs/shmem accounting is also useful for /proc/mem= info. Do we have to account it explicitly? If we know the exact isolate pages of each lru, tmpfs/shmem =3D (NR_ACTIVE_ANON + NR_INACTIVE_ANON + isolate(anon)) - NR_ANON_PAGES. Is there any cases above equation is wrong ? > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" i= n > the body of a message to majordomo@vger.kernel.org > More majordomo info at =C2=A0http://vger.kernel.org/majordomo-info.html > Please read the FAQ at =C2=A0http://www.tux.org/lkml/ > --=20 Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org