From: Minchan Kim <minchan.kim@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [BUGFIX][PATCH] memcg: fix oom killer kills a task in other cgroup
Date: Tue, 9 Feb 2010 19:18:38 +0900 [thread overview]
Message-ID: <28c262361002090218w62bb49bcp5151f1e8b61af801@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1002090150390.16525@chino.kir.corp.google.com>
On Tue, Feb 9, 2010 at 6:55 PM, David Rientjes <rientjes@google.com> wrote:
> On Tue, 9 Feb 2010, Minchan Kim wrote:
>
>> My point was following as.
>> We try to kill child of OOMed task at first.
>> But we can't know any locked state of child when OOM happens.
>
> We don't need to, child->alloc_lock can be contended in which case we'll
> just spin but it won't stay locked because we're out of memory. In other
> words, nothing takes task_lock(child) and then waits for memory to become
> available while holding it, that would be fundamentally broken. So there
> is a dependency here and that is that task_lock(current) can't be taken in
> the page allocator because we'll deadlock in the oom killer, but that
> isn't anything new.
I understand it so I don't oppose Kame's original patch from now on. :)
Thanks for kind explanation. David.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-09 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 0:39 [BUGFIX][PATCH] memcg: fix oom killer kills a task in other cgroup KAMEZAWA Hiroyuki
2010-02-05 0:57 ` David Rientjes
2010-02-05 16:30 ` Minchan Kim
2010-02-09 0:32 ` KAMEZAWA Hiroyuki
2010-02-09 0:56 ` KAMEZAWA Hiroyuki
2010-02-09 1:24 ` Minchan Kim
2010-02-09 1:34 ` KAMEZAWA Hiroyuki
2010-02-09 6:49 ` David Rientjes
2010-02-09 7:08 ` KAMEZAWA Hiroyuki
2010-02-09 9:40 ` Minchan Kim
2010-02-09 9:55 ` David Rientjes
2010-02-09 10:18 ` Minchan Kim [this message]
2010-02-09 3:02 ` [BUGFIX][PATCH] memcg: fix oom killer kills a task in other cgroup v2 KAMEZAWA Hiroyuki
2010-02-09 7:50 ` David Rientjes
2010-02-09 8:02 ` KAMEZAWA Hiroyuki
2010-02-09 8:21 ` David Rientjes
2010-02-09 9:22 ` KAMEZAWA Hiroyuki
2010-02-09 9:35 ` David Rientjes
2010-02-09 9:27 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c262361002090218w62bb49bcp5151f1e8b61af801@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).