From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC21C25B50 for ; Mon, 23 Jan 2023 11:33:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8A536B0071; Mon, 23 Jan 2023 06:33:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3AAA6B0072; Mon, 23 Jan 2023 06:33:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E5966B0073; Mon, 23 Jan 2023 06:33:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D5CF6B0071 for ; Mon, 23 Jan 2023 06:33:54 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 53AF01C6137 for ; Mon, 23 Jan 2023 11:33:54 +0000 (UTC) X-FDA: 80385854388.01.9898C1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 113D9C0012 for ; Mon, 23 Jan 2023 11:33:51 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U4Qh02CV; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674473632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFYAxFs5rwgfxj0ri1ncElv5homkGo21RLH4knBIJeE=; b=W6zjCwyWnSor/XK+QmnlhxaiTbUYZ9ayb/R8IXbxEEyGfiXiiA85cQo2cmm4z3uEzomoCz RhMy/nmTqmLOcr78pksKdkHO/TKTlntwzxkwDtDU8juF0P3VmCsLHo1aVXx3Q8DYypf9uc Nu1/pY+J/JxNnr+HIa8fSJZz/jCRWT8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U4Qh02CV; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674473632; a=rsa-sha256; cv=none; b=8Ksdhh4lpGvvp3b9dBsbT/Tw3xeNRKO33MRCN5YnoQHmavfQ9axe7d95KfU1/8FJZI/FuN 3/J9CUU4MazP/ugITMpcqomRfq5gBmXxx6B+T+AX6fFazAVddaAMsi2xo1PD/xOtaBUPlI Gi7GYsgq20FW9Oqi+8BWlmiptJVSa/4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674473631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tFYAxFs5rwgfxj0ri1ncElv5homkGo21RLH4knBIJeE=; b=U4Qh02CV/1cCL24vtf9XTLgDUwET+X9ZhJ5FEmg28xYqflfPb9TZJXPqOFsDof7bW8tvl/ usv2wXViJH6JeTPKAkngkwHIXLzUs4S4gGpF7cuZXgpe6pkOWeD1jh8k2hohcTpZOkw6dF FeFABO1vDiZk6EFzOBDFw3lUBOguWWg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-493-oefS6XmzOl2H2rDXX3YTGA-1; Mon, 23 Jan 2023 06:33:50 -0500 X-MC-Unique: oefS6XmzOl2H2rDXX3YTGA-1 Received: by mail-wm1-f72.google.com with SMTP id z11-20020a1c4c0b000000b003db062505b9so2744133wmf.4 for ; Mon, 23 Jan 2023 03:33:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tFYAxFs5rwgfxj0ri1ncElv5homkGo21RLH4knBIJeE=; b=OpIWAOtqeiBdCHXLk8xUzoHk1SENt1YBk0HP9q1aMSkRWQVNJWgRh15dQBVqzFMpWo 0haQZxoJbKwqBDo6G7rjKB6aU8UuAdy9ySYgJbbpsTy5mS0uWHMMPvGvu9Lp1fD74jeF GQFivk0/Nff9nghg5Ir5igYad1nAMOmXsLQIlpNKgjjIJvINqqRlGkOTTkafL6pZ7V9+ 5OM2jnNbGMh9IpX7OuMn0fAW/Qr4kKDeW8sANmNpSbnVkfWCUlJGrQtuACfKTNhHLlMk t9G3t+XNzp/5VTwG9Z9Nfae89nibNtxwLIFnMUKH1Z+yKzwd2nyyPzx14OuD/bEV+bab QfUA== X-Gm-Message-State: AFqh2krgumxzQBGsev+HURuntzHhEzDmGu3CVXZ6FWbvNRr6CBBmidas 24AvEju/x/G+GRZhP8r5I1CbhcaM/jw2pxPs6geeqSXUJzHlqteUBQ/55FqWEBiWB4OZfvk9CHW 0RaiKC6ignj4= X-Received: by 2002:a05:600c:3d16:b0:3d0:6a57:66a5 with SMTP id bh22-20020a05600c3d1600b003d06a5766a5mr23770954wmb.0.1674473629015; Mon, 23 Jan 2023 03:33:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXvpOT1NSkKkXXy9D60nU9KMq1gISqadxY+wEPLWVWeDhLkCbC9jTD/XtWuGwQnCaxvZxoWbDQ== X-Received: by 2002:a05:600c:3d16:b0:3d0:6a57:66a5 with SMTP id bh22-20020a05600c3d1600b003d06a5766a5mr23770936wmb.0.1674473628704; Mon, 23 Jan 2023 03:33:48 -0800 (PST) Received: from ?IPV6:2003:cb:c704:1100:65a0:c03a:142a:f914? (p200300cbc704110065a0c03a142af914.dip0.t-ipconnect.de. [2003:cb:c704:1100:65a0:c03a:142a:f914]) by smtp.gmail.com with ESMTPSA id i8-20020a05600c4b0800b003da2932bde0sm11808211wmp.23.2023.01.23.03.33.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 03:33:48 -0800 (PST) Message-ID: <291ae6fe-b0c2-3309-893a-8f27ba3e8252@redhat.com> Date: Mon, 23 Jan 2023 12:33:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 8/8] mm/gup: make get_user_pages_fast_only() return the common return value To: Jason Gunthorpe Cc: Alistair Popple , John Hubbard , linux-mm@kvack.org References: <8-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <8-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 113D9C0012 X-Stat-Signature: nsjwcmwz43xrg6qiucqhwhoh6nhegi8y X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674473631-158346 X-HE-Meta: U2FsdGVkX197WUePaFN9ffmGSx7oTXLyb3OBwK1YHHV0t340aMPZPOAP/dAYpJseoMbE3vBn9YUaaXFZnzLPZgcW+1MCAQFOqFzVWpRSixQSc6Cpr+KufBcqULZM+XvhrzAAWofC1Rb1dy/V2fG8Ivfs4nybsJKs6VxFqiJvgfaXn8T87549fqfmH2O5kU8MIjvPfBl3NFbZjRzyWDJTSASIBx4HfEoN1qxaaoOvHWwuP6gcOH8QUm9eLjMNvlH4SoTQaTIU2MZRzHLva3OfaWWCBTTdqHxRUl1RYdy/owJ5diOHz5fEiy3JOg8/uTiQMpsKaa5BoGwwjpr49cDBZGkrsz4i/EHD/A8NKiAVgwWtFaz40HkWZYZBxQ13mdYf9Ea39kYTNo1mVJKVrd3qlsoLRc7Fb/+Zy9FwxWyMNezgdbS1JKjbadjUo0Pn1nv4P0Bi3y1HZEw56XLTLk0lsIOSrBi0VZYs26zqOOQQy1MzStYVVuyZEBRTxVkZC4UEcjq+t3ZtDJJzxMA4lc7DBZ/zqs8OhDAOyA9NZrV0J1EVx/ny/gr5OQkM/Z0p/F65+sE+w8i4KqEaCt6oBhCz7HsiuHpu3LG+vdptEqKjiBdVklJLohvHCBfHu7n1ww6m86Wj1j4to0kVzmdEhnDbKqqvjv0R2G7mK7s4BTiObBikJOcrYLlvaA0tiWd/BfcCDk9g9WcJKEIcya4tLNeNEVn1OU5ICWPO8g+dNMYggBlsUy3cfh5yBRTH/THXLHwj530G38NP1MHY/pD0jdESWaf0ztvgZEUa35QrBSCWorVOEceVcwmg3VMhVvOKfZAN/XlagvYQ0a4TehtWlO8t5ZyddbMn9wkwaY6nng2HEvlVP47PYuEv5WvpwT/Kv6Wi6mQlddPqUrdnTytzGsMQN0n4CYyY1NwZGde0NqNSKETqBlfrykSmwdR3NvcF6DR2PnOO52IU732gyp9CkHQ OjxDZ/Fw KUn2zSPelTIxtQNZ6Bwk0wZ6Jl58+303y7WaR2OE2pGm/U+WW6qknfi7Yw3wENY52hhxMUynnVion680LLD05H9Nq8x+Jai4+XXPKwKeYc3AWfEjVSiP6t6hNY+gY3ysauKYMELXqhUK2hxJ4woNB49HBpJYrvge+E2qxWzo0Z59Vb1s9T2bTLN97OSYk4g0Km59EqKYzbYEAfbOepg4G81x9/l0++AtGLX5F14wBc4j3Ie52P9v6Cs/XT21wf2YR/4TW+sqqAOezRZPOAI/KiyOF6jAHUThoS4ZttTVvh1QjIR8Jq3BLyR9lYinsWCaqmMa5gK93H69HRMxW7VuT3dOv4oRy//HhY0Qu56UDd2O5I+u83JdksCg+5ldEPxOgqplWeEQwDVVPrW03q2QTO/O0cKGpyNRvLgQHz2qg8voPQLo/vHNBI3A2MIlrWo10QSQcKX6YU8r+t69AXyxgoNbfSysjMMRKjpuyrj+RHUpgQtk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.01.23 16:58, Jason Gunthorpe wrote: > There are only two callers, both can handle the common return code: > > - get_user_page_fast_only() checks == 1 > > - gfn_to_page_many_atomic() already returns -1, and the only caller > checks for -ve > > Remove the restriction against returning negative values. > > Signed-off-by: Jason Gunthorpe > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb