From: "Nish Aravamudan" <nish.aravamudan@gmail.com>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: linux-mm <linux-mm@kvack.org>,
Christoph Lameter <clameter@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
mel@skynet.ie, y-goto@jp.fujitsu.com,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Eric Whitney <eric.whitney@hp.com>
Subject: Re: [PATCH/RFC] Add node states sysfs class attributeS - V4
Date: Thu, 30 Aug 2007 09:44:36 -0700 [thread overview]
Message-ID: <29495f1d0708300944o9aafdc5ob9dd30a687402ab@mail.gmail.com> (raw)
In-Reply-To: <1188487157.5794.40.camel@localhost>
On 8/30/07, Lee Schermerhorn <Lee.Schermerhorn@hp.com> wrote:
> Try, try again. Maybe closer this time.
>
> Question: do we need/want to display the normal and high memory masks
> separately for systems with HIGHMEM? If not, I'd suggest changing the
> print_nodes_state() function to take a nodemask_t* instead of a state
> enum and expose a single 'has_memory' attribute that we print using
> something like:
I feel like we should keep them separate. They are distinct in the
kernel for a reason, right? Do we perhaps actually want
has_normal_memory
has_highmem_memory
has_memory
That might be overkill, though -- and perhaps folks will argue you can
figure out the third by or'ing the results of the first two in a
script?
Thanks,
Nish
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-30 16:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200708242228.l7OMS5fU017948@imap1.linux-foundation.org>
2007-08-27 15:58 ` [PATCH] 2.6.23-rc3-mm1 - update N_HIGH_MEMORY node state for memory hotadd Lee Schermerhorn
2007-08-27 17:48 ` [PATCH/RFC] Add node 'states' sysfs class attribute Lee Schermerhorn
2007-08-27 19:11 ` Christoph Lameter
2007-08-27 20:08 ` Lee Schermerhorn
2007-08-27 20:15 ` Christoph Lameter
2007-08-27 21:02 ` [PATCH/RFC] Add node 'states' sysfs class attribute - V2 Lee Schermerhorn
2007-08-27 21:04 ` Christoph Lameter
2007-08-28 0:01 ` Andrew Morton
2007-08-28 0:08 ` Christoph Lameter
2007-08-28 1:14 ` Andrew Morton
2007-08-28 1:29 ` Christoph Lameter
2007-08-28 3:18 ` Andrew Morton
2007-08-28 5:15 ` Christoph Lameter
2007-08-28 5:29 ` Andrew Morton
2007-08-28 5:34 ` Andrew Morton
2007-08-28 5:53 ` Christoph Lameter
2007-08-28 6:12 ` Andrew Morton
2007-08-28 14:05 ` Lee Schermerhorn
2007-08-28 22:02 ` Christoph Lameter
2007-08-28 22:13 ` Nish Aravamudan
2007-08-29 14:43 ` Lee Schermerhorn
2007-08-29 17:39 ` Christoph Lameter
2007-08-29 21:31 ` [PATCH/RFC] Add node states sysfs class attributeS - V3 Lee Schermerhorn
2007-08-29 22:14 ` Christoph Lameter
2007-08-30 13:34 ` Lee Schermerhorn
2007-08-29 22:36 ` Nish Aravamudan
2007-08-30 15:19 ` [PATCH/RFC] Add node states sysfs class attributeS - V4 Lee Schermerhorn
2007-08-30 16:44 ` Nish Aravamudan [this message]
2007-08-30 18:20 ` Christoph Lameter
2007-08-30 18:19 ` Christoph Lameter
2007-08-30 18:41 ` Lee Schermerhorn
2007-09-11 13:56 ` [PATCH/RFC] Add node states sysfs class attributeS - V5 Lee Schermerhorn
2007-09-11 20:25 ` Christoph Lameter
2007-09-14 10:50 ` Andrew Morton
2007-09-14 11:35 ` Andy Whitcroft
2007-09-14 14:34 ` Lee Schermerhorn
2007-09-14 14:43 ` Mel Gorman
2007-09-14 15:00 ` Paul Mundt
2007-09-16 12:10 ` Mel Gorman
2007-09-14 16:00 ` Martin J. Bligh
2007-08-28 19:34 ` [PATCH/RFC] Add node 'states' sysfs class attribute - V2 Christoph Lameter
2007-08-28 1:16 ` Yasunori Goto
2007-08-28 1:21 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d0708300944o9aafdc5ob9dd30a687402ab@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=eric.whitney@hp.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).